Title: [203511] trunk
- Revision
- 203511
- Author
- [email protected]
- Date
- 2016-07-21 10:54:27 -0700 (Thu, 21 Jul 2016)
Log Message
playsInline IDL attribute has the wrong casing
https://bugs.webkit.org/show_bug.cgi?id=160029
<rdar://problem/27474031>
Reviewed by Jon Lee.
Source/WebCore:
Fix case from video.playsinline to video.playsInline in order to match
the specification:
- https://html.spec.whatwg.org/multipage/embedded-content.html#the-video-element:dom-video-playsinline
It still reflects the "playsinline" content attribute though, as per
the specification:
- https://html.spec.whatwg.org/multipage/embedded-content.html#dom-video-playsinline
No new tests, updated existing test.
* html/HTMLVideoElement.idl:
LayoutTests:
Update test to use the correct case.
* media/video-playsinline-expected.txt:
* media/video-playsinline.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (203510 => 203511)
--- trunk/LayoutTests/ChangeLog 2016-07-21 17:20:44 UTC (rev 203510)
+++ trunk/LayoutTests/ChangeLog 2016-07-21 17:54:27 UTC (rev 203511)
@@ -1,5 +1,18 @@
2016-07-21 Chris Dumez <[email protected]>
+ playsInline IDL attribute has the wrong casing
+ https://bugs.webkit.org/show_bug.cgi?id=160029
+ <rdar://problem/27474031>
+
+ Reviewed by Jon Lee.
+
+ Update test to use the correct case.
+
+ * media/video-playsinline-expected.txt:
+ * media/video-playsinline.html:
+
+2016-07-21 Chris Dumez <[email protected]>
+
Drop [TreatNullAs=EmptyString] from CanvasRenderingContext2D.globalCompositeOperation
https://bugs.webkit.org/show_bug.cgi?id=160026
Modified: trunk/LayoutTests/media/video-playsinline-expected.txt (203510 => 203511)
--- trunk/LayoutTests/media/video-playsinline-expected.txt 2016-07-21 17:20:44 UTC (rev 203510)
+++ trunk/LayoutTests/media/video-playsinline-expected.txt 2016-07-21 17:54:27 UTC (rev 203511)
@@ -1,23 +1,23 @@
RUN(internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(true))
-RUN(video.playsinline = false)
+RUN(video.playsInline = false)
EVENT(canplaythrough)
RUN(video.play())
EVENT(playing)
EXPECTED (video.webkitDisplayingFullscreen == 'true') OK
RUN(internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(true))
-RUN(video.playsinline = true)
+RUN(video.playsInline = true)
EVENT(canplaythrough)
RUN(video.play())
EVENT(playing)
EXPECTED (video.webkitDisplayingFullscreen == 'false') OK
RUN(internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(false))
-RUN(video.playsinline = false)
+RUN(video.playsInline = false)
EVENT(canplaythrough)
RUN(video.play())
EVENT(playing)
EXPECTED (video.webkitDisplayingFullscreen == 'false') OK
RUN(internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(false))
-RUN(video.playsinline = true)
+RUN(video.playsInline = true)
EVENT(canplaythrough)
RUN(video.play())
EVENT(playing)
Modified: trunk/LayoutTests/media/video-playsinline.html (203510 => 203511)
--- trunk/LayoutTests/media/video-playsinline.html 2016-07-21 17:20:44 UTC (rev 203510)
+++ trunk/LayoutTests/media/video-playsinline.html 2016-07-21 17:54:27 UTC (rev 203511)
@@ -24,7 +24,7 @@
document.body.appendChild(video);
video.controls = true;
video.src = "" 'content/test');
- run('video.playsinline = ' + hasPlaysInline);
+ run('video.playsInline = ' + hasPlaysInline);
waitForEventOnce('canplaythrough', () => {
runWithKeyDown(() => {
run('video.play()');
@@ -68,4 +68,4 @@
</head>
<body _onload_="go()">
</body>
-</html>
\ No newline at end of file
+</html>
Modified: trunk/Source/WebCore/ChangeLog (203510 => 203511)
--- trunk/Source/WebCore/ChangeLog 2016-07-21 17:20:44 UTC (rev 203510)
+++ trunk/Source/WebCore/ChangeLog 2016-07-21 17:54:27 UTC (rev 203511)
@@ -1,5 +1,25 @@
2016-07-21 Chris Dumez <[email protected]>
+ playsInline IDL attribute has the wrong casing
+ https://bugs.webkit.org/show_bug.cgi?id=160029
+ <rdar://problem/27474031>
+
+ Reviewed by Jon Lee.
+
+ Fix case from video.playsinline to video.playsInline in order to match
+ the specification:
+ - https://html.spec.whatwg.org/multipage/embedded-content.html#the-video-element:dom-video-playsinline
+
+ It still reflects the "playsinline" content attribute though, as per
+ the specification:
+ - https://html.spec.whatwg.org/multipage/embedded-content.html#dom-video-playsinline
+
+ No new tests, updated existing test.
+
+ * html/HTMLVideoElement.idl:
+
+2016-07-21 Chris Dumez <[email protected]>
+
Drop [TreatNullAs=EmptyString] from CanvasRenderingContext2D.globalCompositeOperation
https://bugs.webkit.org/show_bug.cgi?id=160026
Modified: trunk/Source/WebCore/html/HTMLVideoElement.idl (203510 => 203511)
--- trunk/Source/WebCore/html/HTMLVideoElement.idl 2016-07-21 17:20:44 UTC (rev 203510)
+++ trunk/Source/WebCore/html/HTMLVideoElement.idl 2016-07-21 17:54:27 UTC (rev 203511)
@@ -33,7 +33,7 @@
readonly attribute unsigned long videoHeight;
[Reflect, URL] attribute DOMString poster;
- [Reflect] attribute boolean playsinline;
+ [Reflect=playsinline] attribute boolean playsInline;
readonly attribute boolean webkitSupportsFullscreen;
readonly attribute boolean webkitDisplayingFullscreen;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
