Diff
Modified: trunk/LayoutTests/ChangeLog (203527 => 203528)
--- trunk/LayoutTests/ChangeLog 2016-07-21 21:22:58 UTC (rev 203527)
+++ trunk/LayoutTests/ChangeLog 2016-07-21 21:23:28 UTC (rev 203528)
@@ -1,5 +1,17 @@
2016-07-21 Chris Dumez <[email protected]>
+ Fix null handling for HTMLObjectElement.border
+ https://bugs.webkit.org/show_bug.cgi?id=160040
+
+ Reviewed by Ryosuke Niwa.
+
+ Update existing test to reflect the behavior change.
+
+ * fast/dom/element-attribute-js-null-expected.txt:
+ * fast/dom/element-attribute-js-null.html:
+
+2016-07-21 Chris Dumez <[email protected]>
+
Fix null handling for td.bgColor / tr.bgColor
https://bugs.webkit.org/show_bug.cgi?id=160043
Modified: trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt (203527 => 203528)
--- trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt 2016-07-21 21:22:58 UTC (rev 203527)
+++ trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt 2016-07-21 21:23:28 UTC (rev 203528)
@@ -147,7 +147,7 @@
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.code]
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.align]
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.archive]
-TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.border]
+TEST SUCCEEDED: The value was the empty string. [tested HTMLObjectElement.border]
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.codeBase]
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.codeType]
TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.height]
Modified: trunk/LayoutTests/fast/dom/element-attribute-js-null.html (203527 => 203528)
--- trunk/LayoutTests/fast/dom/element-attribute-js-null.html 2016-07-21 21:22:58 UTC (rev 203527)
+++ trunk/LayoutTests/fast/dom/element-attribute-js-null.html 2016-07-21 21:23:28 UTC (rev 203528)
@@ -383,7 +383,7 @@
{name: 'code', expectedNull: 'null'},
{name: 'align', expectedNull: 'null'},
{name: 'archive', expectedNull: 'null'},
- {name: 'border', expectedNull: 'null'},
+ {name: 'border', expectedNull: ''},
{name: 'codeBase', expectedNull: 'null'},
{name: 'codeType', expectedNull: 'null'},
{name: 'height', expectedNull: 'null'},
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203527 => 203528)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-21 21:22:58 UTC (rev 203527)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-21 21:23:28 UTC (rev 203528)
@@ -1,5 +1,16 @@
2016-07-21 Chris Dumez <[email protected]>
+ Fix null handling for HTMLObjectElement.border
+ https://bugs.webkit.org/show_bug.cgi?id=160040
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline W3C test now that more checks are passing.
+
+ * web-platform-tests/html/dom/reflection-embedded-expected.txt:
+
+2016-07-21 Chris Dumez <[email protected]>
+
Fix null handling for td.bgColor / tr.bgColor
https://bugs.webkit.org/show_bug.cgi?id=160043
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (203527 => 203528)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-07-21 21:22:58 UTC (rev 203527)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-07-21 21:23:28 UTC (rev 203528)
@@ -6574,8 +6574,8 @@
PASS object.border: IDL set to "\0" followed by getAttribute()
PASS object.border: IDL set to "\0" followed by IDL get
PASS object.border: IDL set to null should not throw
-FAIL object.border: IDL set to null followed by getAttribute() assert_equals: expected "" but got "null"
-FAIL object.border: IDL set to null followed by IDL get assert_equals: expected "" but got "null"
+PASS object.border: IDL set to null followed by getAttribute()
+PASS object.border: IDL set to null followed by IDL get
PASS object.border: IDL set to object "test-toString" should not throw
PASS object.border: IDL set to object "test-toString" followed by getAttribute()
PASS object.border: IDL set to object "test-toString" followed by IDL get
Modified: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (203527 => 203528)
--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-07-21 21:22:58 UTC (rev 203527)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-07-21 21:23:28 UTC (rev 203528)
@@ -6574,8 +6574,8 @@
PASS object.border: IDL set to "\0" followed by getAttribute()
PASS object.border: IDL set to "\0" followed by IDL get
PASS object.border: IDL set to null should not throw
-FAIL object.border: IDL set to null followed by getAttribute() assert_equals: expected "" but got "null"
-FAIL object.border: IDL set to null followed by IDL get assert_equals: expected "" but got "null"
+PASS object.border: IDL set to null followed by getAttribute()
+PASS object.border: IDL set to null followed by IDL get
PASS object.border: IDL set to object "test-toString" should not throw
PASS object.border: IDL set to object "test-toString" followed by getAttribute()
PASS object.border: IDL set to object "test-toString" followed by IDL get
Modified: trunk/Source/WebCore/ChangeLog (203527 => 203528)
--- trunk/Source/WebCore/ChangeLog 2016-07-21 21:22:58 UTC (rev 203527)
+++ trunk/Source/WebCore/ChangeLog 2016-07-21 21:23:28 UTC (rev 203528)
@@ -1,5 +1,23 @@
2016-07-21 Chris Dumez <[email protected]>
+ Fix null handling for HTMLObjectElement.border
+ https://bugs.webkit.org/show_bug.cgi?id=160040
+
+ Reviewed by Ryosuke Niwa.
+
+ Fix null handling for HTMLObjectElement.border to match the specification:
+ - https://html.spec.whatwg.org/#HTMLObjectElement-partial
+
+ We are supposed to treat null as the empty string.
+
+ Both Firefox and Chrome agree with the specification.
+
+ No new tests, rebaselined existing tests.
+
+ * html/HTMLObjectElement.idl:
+
+2016-07-21 Chris Dumez <[email protected]>
+
Fix null handling for td.bgColor / tr.bgColor
https://bugs.webkit.org/show_bug.cgi?id=160043
Modified: trunk/Source/WebCore/html/HTMLObjectElement.idl (203527 => 203528)
--- trunk/Source/WebCore/html/HTMLObjectElement.idl 2016-07-21 21:22:58 UTC (rev 203527)
+++ trunk/Source/WebCore/html/HTMLObjectElement.idl 2016-07-21 21:23:28 UTC (rev 203528)
@@ -27,7 +27,7 @@
[Reflect] attribute DOMString code;
[Reflect] attribute DOMString align;
[Reflect] attribute DOMString archive;
- [Reflect] attribute DOMString border;
+ [Reflect, TreatNullAs=EmptyString] attribute DOMString border;
[Reflect] attribute DOMString codeBase;
[Reflect] attribute DOMString codeType;
[Reflect, URL] attribute DOMString data;
