Title: [203549] trunk/Source/WebCore
- Revision
- 203549
- Author
- [email protected]
- Date
- 2016-07-21 20:00:07 -0700 (Thu, 21 Jul 2016)
Log Message
REGRESSION(r62549): Objective-C DOM bindings sometimes fail to regenerate when CodeGenerator.pm is modified
https://bugs.webkit.org/show_bug.cgi?id=160031
Reviewed by Darin Adler.
This bug was caused by a refactoring 6 years ago. Not all uses of a variable
were renamed, so the ObjC bindings target pattern was not specifying any
build scripts as target dependencies.
* DerivedSources.make: Standardize on {COMMON,JS,DOM}_BINDINGS_SCRIPTS.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (203548 => 203549)
--- trunk/Source/WebCore/ChangeLog 2016-07-22 02:43:10 UTC (rev 203548)
+++ trunk/Source/WebCore/ChangeLog 2016-07-22 03:00:07 UTC (rev 203549)
@@ -1,3 +1,16 @@
+2016-07-21 Brian Burg <[email protected]>
+
+ REGRESSION(r62549): Objective-C DOM bindings sometimes fail to regenerate when CodeGenerator.pm is modified
+ https://bugs.webkit.org/show_bug.cgi?id=160031
+
+ Reviewed by Darin Adler.
+
+ This bug was caused by a refactoring 6 years ago. Not all uses of a variable
+ were renamed, so the ObjC bindings target pattern was not specifying any
+ build scripts as target dependencies.
+
+ * DerivedSources.make: Standardize on {COMMON,JS,DOM}_BINDINGS_SCRIPTS.
+
2016-07-21 Darin Adler <[email protected]>
Remove unneeded content attribute name "playsinline"
Modified: trunk/Source/WebCore/DerivedSources.make (203548 => 203549)
--- trunk/Source/WebCore/DerivedSources.make 2016-07-22 02:43:10 UTC (rev 203548)
+++ trunk/Source/WebCore/DerivedSources.make 2016-07-22 03:00:07 UTC (rev 203549)
@@ -1181,7 +1181,7 @@
# Common generator things
-GENERATE_SCRIPTS = \
+COMMON_BINDINGS_SCRIPTS = \
bindings/scripts/CodeGenerator.pm \
bindings/scripts/IDLParser.pm \
bindings/scripts/generate-bindings.pl \
@@ -1217,7 +1217,7 @@
IDL_COMMON_ARGS = $(IDL_INCLUDES:%=--include %) --write-dependencies --outputDir .
-JS_BINDINGS_SCRIPTS = $(GENERATE_SCRIPTS) bindings/scripts/CodeGeneratorJS.pm
+JS_BINDINGS_SCRIPTS = $(COMMON_BINDINGS_SCRIPTS) bindings/scripts/CodeGeneratorJS.pm
SUPPLEMENTAL_DEPENDENCY_FILE = ./SupplementalDependencies.txt
SUPPLEMENTAL_MAKEFILE_DEPS = ./SupplementalDependencies.dep
@@ -1363,7 +1363,7 @@
# Objective-C bindings
-DOM_BINDINGS_SCRIPTS = $(GENERATE_BINDING_SCRIPTS) bindings/scripts/CodeGeneratorObjC.pm
+DOM_BINDINGS_SCRIPTS = $(COMMON_BINDINGS_SCRIPTS) bindings/scripts/CodeGeneratorObjC.pm
DOM%.h : %.idl $(DOM_BINDINGS_SCRIPTS) bindings/objc/PublicDOMInterfaces.h $(PLATFORM_FEATURE_DEFINES)
$(call generator_script, $(DOM_BINDINGS_SCRIPTS)) $(IDL_COMMON_ARGS) --defines "$(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_OBJECTIVE_C" --generator ObjC --supplementalDependencyFile $(SUPPLEMENTAL_DEPENDENCY_FILE) $<
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
