Title: [203712] trunk
Revision
203712
Author
cdu...@apple.com
Date
2016-07-25 22:27:51 -0700 (Mon, 25 Jul 2016)

Log Message

DOMTokenList.prototype.toString should be enumerable
https://bugs.webkit.org/show_bug.cgi?id=160182

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

* web-platform-tests/dom/interfaces-expected.txt:

Source/WebCore:

DOMTokenList.prototype.toString should be enumerable:
- https://dom.spec.whatwg.org/#interface-domtokenlist
- http://heycam.github.io/webidl/#es-stringifier

Firefox and Chrome agree with the specification.

No new tests, rebaselined existing test.

* html/DOMTokenList.idl:

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203711 => 203712)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-07-26 05:27:33 UTC (rev 203711)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-07-26 05:27:51 UTC (rev 203712)
@@ -1,5 +1,16 @@
 2016-07-25  Chris Dumez  <cdu...@apple.com>
 
+        DOMTokenList.prototype.toString should be enumerable
+        https://bugs.webkit.org/show_bug.cgi?id=160182
+
+        Reviewed by Ryosuke Niwa.
+
+        Rebaseline W3C test now that one more check is passing.
+
+        * web-platform-tests/dom/interfaces-expected.txt:
+
+2016-07-25  Chris Dumez  <cdu...@apple.com>
+
         Parameters to DOMImplementation.createDocumentType() should be mandatory and non-nullable
         https://bugs.webkit.org/show_bug.cgi?id=160167
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (203711 => 203712)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt	2016-07-26 05:27:33 UTC (rev 203711)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt	2016-07-26 05:27:51 UTC (rev 203712)
@@ -1535,7 +1535,7 @@
 FAIL DOMTokenList interface: operation replace(DOMString,DOMString) assert_own_property: interface prototype object missing non-static operation expected property "replace" missing
 FAIL DOMTokenList interface: operation supports(DOMString) assert_own_property: interface prototype object missing non-static operation expected property "supports" missing
 PASS DOMTokenList interface: attribute value 
-FAIL DOMTokenList interface: stringifier assert_true: property is not enumerable expected true got false
+PASS DOMTokenList interface: stringifier 
 PASS DOMTokenList must be primary interface of document.body.classList 
 PASS Stringification of document.body.classList 
 PASS DOMTokenList interface: document.body.classList must inherit property "length" with the proper type (0) 

Modified: trunk/Source/WebCore/ChangeLog (203711 => 203712)


--- trunk/Source/WebCore/ChangeLog	2016-07-26 05:27:33 UTC (rev 203711)
+++ trunk/Source/WebCore/ChangeLog	2016-07-26 05:27:51 UTC (rev 203712)
@@ -1,3 +1,20 @@
+2016-07-25  Chris Dumez  <cdu...@apple.com>
+
+        DOMTokenList.prototype.toString should be enumerable
+        https://bugs.webkit.org/show_bug.cgi?id=160182
+
+        Reviewed by Ryosuke Niwa.
+
+        DOMTokenList.prototype.toString should be enumerable:
+        - https://dom.spec.whatwg.org/#interface-domtokenlist
+        - http://heycam.github.io/webidl/#es-stringifier
+
+        Firefox and Chrome agree with the specification.
+
+        No new tests, rebaselined existing test.
+
+        * html/DOMTokenList.idl:
+
 2016-07-25  Nan Wang  <n_w...@apple.com>
 
         AX: Expose autoFillButtonType to accessibility

Modified: trunk/Source/WebCore/html/DOMTokenList.idl (203711 => 203712)


--- trunk/Source/WebCore/html/DOMTokenList.idl	2016-07-26 05:27:33 UTC (rev 203711)
+++ trunk/Source/WebCore/html/DOMTokenList.idl	2016-07-26 05:27:51 UTC (rev 203712)
@@ -37,7 +37,7 @@
     attribute DOMString value;
 
 #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
-    [NotEnumerable] DOMString toString();
+    DOMString toString();
 #endif
 };
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to