Title: [203734] trunk
- Revision
- 203734
- Author
- [email protected]
- Date
- 2016-07-26 13:57:20 -0700 (Tue, 26 Jul 2016)
Log Message
Parameters to CustomEvent.initCustomEvent() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160205
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
* web-platform-tests/dom/interfaces-expected.txt:
Source/WebCore:
Parameters to CustomEvent.initCustomEvent() should be mandatory:
- https://dom.spec.whatwg.org/#interface-customevent
Firefox and Chrome agree with the specification.
No new tests, rebaselined existing test.
* dom/CustomEvent.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203733 => 203734)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-26 20:54:25 UTC (rev 203733)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-26 20:57:20 UTC (rev 203734)
@@ -1,5 +1,16 @@
2016-07-26 Chris Dumez <[email protected]>
+ Parameters to CustomEvent.initCustomEvent() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160205
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline W3C test now that more checks are passing.
+
+ * web-platform-tests/dom/interfaces-expected.txt:
+
+2016-07-26 Chris Dumez <[email protected]>
+
Second parameter to Range.isPointInRange() / comparePoint() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160202
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (203733 => 203734)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-07-26 20:54:25 UTC (rev 203733)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-07-26 20:57:20 UTC (rev 203734)
@@ -77,14 +77,12 @@
PASS CustomEvent interface: existence and properties of interface prototype object
PASS CustomEvent interface: existence and properties of interface prototype object's "constructor" property
PASS CustomEvent interface: attribute detail
-FAIL CustomEvent interface: operation initCustomEvent(DOMString,boolean,boolean,any) assert_equals: property has wrong .length expected 4 but got 0
+PASS CustomEvent interface: operation initCustomEvent(DOMString,boolean,boolean,any)
PASS CustomEvent must be primary interface of new CustomEvent("foo")
PASS Stringification of new CustomEvent("foo")
PASS CustomEvent interface: new CustomEvent("foo") must inherit property "detail" with the proper type (0)
PASS CustomEvent interface: new CustomEvent("foo") must inherit property "initCustomEvent" with the proper type (1)
-FAIL CustomEvent interface: calling initCustomEvent(DOMString,boolean,boolean,any) on new CustomEvent("foo") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
+PASS CustomEvent interface: calling initCustomEvent(DOMString,boolean,boolean,any) on new CustomEvent("foo") with too few arguments must throw TypeError
PASS Event interface: new CustomEvent("foo") must inherit property "type" with the proper type (0)
PASS Event interface: new CustomEvent("foo") must inherit property "target" with the proper type (1)
PASS Event interface: new CustomEvent("foo") must inherit property "currentTarget" with the proper type (2)
Modified: trunk/Source/WebCore/ChangeLog (203733 => 203734)
--- trunk/Source/WebCore/ChangeLog 2016-07-26 20:54:25 UTC (rev 203733)
+++ trunk/Source/WebCore/ChangeLog 2016-07-26 20:57:20 UTC (rev 203734)
@@ -1,5 +1,21 @@
2016-07-26 Chris Dumez <[email protected]>
+ Parameters to CustomEvent.initCustomEvent() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160205
+
+ Reviewed by Ryosuke Niwa.
+
+ Parameters to CustomEvent.initCustomEvent() should be mandatory:
+ - https://dom.spec.whatwg.org/#interface-customevent
+
+ Firefox and Chrome agree with the specification.
+
+ No new tests, rebaselined existing test.
+
+ * dom/CustomEvent.idl:
+
+2016-07-26 Chris Dumez <[email protected]>
+
Second parameter to Range.isPointInRange() / comparePoint() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160202
Modified: trunk/Source/WebCore/dom/CustomEvent.idl (203733 => 203734)
--- trunk/Source/WebCore/dom/CustomEvent.idl 2016-07-26 20:54:25 UTC (rev 203733)
+++ trunk/Source/WebCore/dom/CustomEvent.idl 2016-07-26 20:57:20 UTC (rev 203734)
@@ -29,6 +29,5 @@
] interface CustomEvent : Event {
[InitializedByEventConstructor, CustomGetter] readonly attribute any detail;
- // FIXME: Using "undefined" as default parameter value is wrong.
- [CallWith=ScriptState] void initCustomEvent(optional DOMString typeArg = "undefined", optional boolean canBubbleArg = false, optional boolean cancelableArg = false, optional any detailArg);
+ [CallWith=ScriptState] void initCustomEvent(DOMString type, boolean bubbles, boolean cancelable, any detail);
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
