Title: [203737] trunk/Source/WebCore
Revision
203737
Author
[email protected]
Date
2016-07-26 14:35:20 -0700 (Tue, 26 Jul 2016)

Log Message

Occasional crash in WebCore::RenderVTTCue::initializeLayoutParameters
https://bugs.webkit.org/show_bug.cgi?id=160208

Reviewed by Darin Adler.

* rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::initializeLayoutParameters): Return when firstChild is NULL so a
release build will not crash.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (203736 => 203737)


--- trunk/Source/WebCore/ChangeLog	2016-07-26 21:01:07 UTC (rev 203736)
+++ trunk/Source/WebCore/ChangeLog	2016-07-26 21:35:20 UTC (rev 203737)
@@ -1,3 +1,14 @@
+2016-07-26  Eric Carlson  <[email protected]>
+
+        Occasional crash in WebCore::RenderVTTCue::initializeLayoutParameters
+        https://bugs.webkit.org/show_bug.cgi?id=160208
+
+        Reviewed by Darin Adler.
+
+        * rendering/RenderVTTCue.cpp:
+        (WebCore::RenderVTTCue::initializeLayoutParameters): Return when firstChild is NULL so a
+        release build will not crash.
+
 2016-07-26  Chris Dumez  <[email protected]>
 
         Parameters to CustomEvent.initCustomEvent() should be mandatory

Modified: trunk/Source/WebCore/rendering/RenderVTTCue.cpp (203736 => 203737)


--- trunk/Source/WebCore/rendering/RenderVTTCue.cpp	2016-07-26 21:01:07 UTC (rev 203736)
+++ trunk/Source/WebCore/rendering/RenderVTTCue.cpp	2016-07-26 21:35:20 UTC (rev 203737)
@@ -70,6 +70,8 @@
 bool RenderVTTCue::initializeLayoutParameters(InlineFlowBox*& firstLineBox, LayoutUnit& step, LayoutUnit& position)
 {
     ASSERT(firstChild());
+    if (!firstChild())
+        return false;
 
     RenderBlock* parentBlock = containingBlock();
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to