Title: [203745] trunk
- Revision
- 203745
- Author
- [email protected]
- Date
- 2016-07-26 15:42:50 -0700 (Tue, 26 Jul 2016)
Log Message
Range.prototype.compareBoundaryPoints.length should be 2
https://bugs.webkit.org/show_bug.cgi?id=160217
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
* web-platform-tests/dom/interfaces-expected.txt:
Source/WebCore:
Range.prototype.compareBoundaryPoints.length:
- https://dom.spec.whatwg.org/#interface-range
We had a bug in our IDL which caused length to be 0 even though
both parameters were effectively mandatory.
No new tests, rebaselined existing test.
* dom/Range.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203744 => 203745)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-26 22:38:13 UTC (rev 203744)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-26 22:42:50 UTC (rev 203745)
@@ -1,5 +1,16 @@
2016-07-26 Chris Dumez <[email protected]>
+ Range.prototype.compareBoundaryPoints.length should be 2
+ https://bugs.webkit.org/show_bug.cgi?id=160217
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline W3C test now that one more check is passing.
+
+ * web-platform-tests/dom/interfaces-expected.txt:
+
+2016-07-26 Chris Dumez <[email protected]>
+
Parameters to CustomEvent.initCustomEvent() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160205
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (203744 => 203745)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-07-26 22:38:13 UTC (rev 203744)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-07-26 22:42:50 UTC (rev 203745)
@@ -1306,7 +1306,7 @@
PASS Range interface: constant END_TO_END on interface prototype object
PASS Range interface: constant END_TO_START on interface object
PASS Range interface: constant END_TO_START on interface prototype object
-FAIL Range interface: operation compareBoundaryPoints(unsigned short,Range) assert_equals: property has wrong .length expected 2 but got 0
+PASS Range interface: operation compareBoundaryPoints(unsigned short,Range)
PASS Range interface: operation deleteContents()
PASS Range interface: operation extractContents()
PASS Range interface: operation cloneContents()
Modified: trunk/Source/WebCore/ChangeLog (203744 => 203745)
--- trunk/Source/WebCore/ChangeLog 2016-07-26 22:38:13 UTC (rev 203744)
+++ trunk/Source/WebCore/ChangeLog 2016-07-26 22:42:50 UTC (rev 203745)
@@ -1,5 +1,22 @@
2016-07-26 Chris Dumez <[email protected]>
+ Range.prototype.compareBoundaryPoints.length should be 2
+ https://bugs.webkit.org/show_bug.cgi?id=160217
+
+ Reviewed by Sam Weinig.
+
+ Range.prototype.compareBoundaryPoints.length:
+ - https://dom.spec.whatwg.org/#interface-range
+
+ We had a bug in our IDL which caused length to be 0 even though
+ both parameters were effectively mandatory.
+
+ No new tests, rebaselined existing test.
+
+ * dom/Range.idl:
+
+2016-07-26 Chris Dumez <[email protected]>
+
Align CSSStyleDeclaration with the specification
https://bugs.webkit.org/show_bug.cgi?id=160214
Modified: trunk/Source/WebCore/dom/Range.idl (203744 => 203745)
--- trunk/Source/WebCore/dom/Range.idl 2016-07-26 22:38:13 UTC (rev 203744)
+++ trunk/Source/WebCore/dom/Range.idl 2016-07-26 22:42:50 UTC (rev 203745)
@@ -55,7 +55,7 @@
const unsigned short END_TO_END = 2;
const unsigned short END_TO_START = 3;
- [ObjCLegacyUnnamedParameters, RaisesException, ImplementedAs=compareBoundaryPointsForBindings] short compareBoundaryPoints(optional unsigned short how = 0, Range sourceRange);
+ [ObjCLegacyUnnamedParameters, RaisesException, ImplementedAs=compareBoundaryPointsForBindings] short compareBoundaryPoints(unsigned short how, Range sourceRange);
[RaisesException] void deleteContents();
[RaisesException, NewObject] DocumentFragment extractContents();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
