Title: [203773] trunk/Tools
- Revision
- 203773
- Author
- [email protected]
- Date
- 2016-07-27 08:30:36 -0700 (Wed, 27 Jul 2016)
Log Message
[Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
https://bugs.webkit.org/show_bug.cgi?id=160247
Reviewed by Michael Catanzaro.
* BuildSlaveSupport/built-product-archive:
(createZip):
(dirContainsdwo):
(archiveBuiltProduct):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (203772 => 203773)
--- trunk/Tools/BuildSlaveSupport/built-product-archive 2016-07-27 10:40:17 UTC (rev 203772)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive 2016-07-27 15:30:36 UTC (rev 203773)
@@ -133,6 +133,15 @@
return subprocess.call(["zip", "-y", "-r", archiveFile, "."], cwd=directoryToZip)
+def dirContainsdwo(directory):
+ sourcedir = os.path.join(_configurationBuildDirectory, directory)
+ for root, dirs, files in os.walk(sourcedir, topdown=False):
+ for name in files:
+ if name.endswith(".dwo"):
+ return True
+ return False
+
+
def archiveBuiltProduct(configuration, platform, fullPlatform):
assert platform in ('mac', 'win', 'gtk', 'efl', 'ios')
@@ -181,6 +190,12 @@
neededDirectories = ["bin", "lib"]
+ # When debug fission is enabled the directories below contain dwo files
+ # with the debug information needed to generate backtraces with GDB.
+ for objectDir in ["Tools", "Source"]:
+ if dirContainsdwo(objectDir):
+ neededDirectories.append(objectDir)
+
# On GTK we need this for the WebKit GObject DOM bindings API break test
if platform == 'gtk':
neededDirectories.append("DerivedSources/webkitdom")
Modified: trunk/Tools/ChangeLog (203772 => 203773)
--- trunk/Tools/ChangeLog 2016-07-27 10:40:17 UTC (rev 203772)
+++ trunk/Tools/ChangeLog 2016-07-27 15:30:36 UTC (rev 203773)
@@ -1,3 +1,15 @@
+2016-07-27 Carlos Alberto Lopez Perez <[email protected]>
+
+ [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
+ https://bugs.webkit.org/show_bug.cgi?id=160247
+
+ Reviewed by Michael Catanzaro.
+
+ * BuildSlaveSupport/built-product-archive:
+ (createZip):
+ (dirContainsdwo):
+ (archiveBuiltProduct):
+
2016-07-26 Alex Christensen <[email protected]>
Fix tests after r203743.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
