Title: [203775] trunk/Source/WebCore
- Revision
- 203775
- Author
- [email protected]
- Date
- 2016-07-27 08:52:24 -0700 (Wed, 27 Jul 2016)
Log Message
[Soup] Test http/tests/xmlhttprequest/auth-reject-protection-space.html fails since added in r203743
https://bugs.webkit.org/show_bug.cgi?id=160235
Reviewed by Michael Catanzaro.
It times out in release and crashes in debug due to an ASSERT_NOT_REACHED(). The soup backend doesn't really
support rejecting the protection space and continuing with the next one, but we can at least continue with the
request without crendential to make the test pass.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::receivedChallengeRejection):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (203774 => 203775)
--- trunk/Source/WebCore/ChangeLog 2016-07-27 15:49:57 UTC (rev 203774)
+++ trunk/Source/WebCore/ChangeLog 2016-07-27 15:52:24 UTC (rev 203775)
@@ -1,3 +1,17 @@
+2016-07-27 Carlos Garcia Campos <[email protected]>
+
+ [Soup] Test http/tests/xmlhttprequest/auth-reject-protection-space.html fails since added in r203743
+ https://bugs.webkit.org/show_bug.cgi?id=160235
+
+ Reviewed by Michael Catanzaro.
+
+ It times out in release and crashes in debug due to an ASSERT_NOT_REACHED(). The soup backend doesn't really
+ support rejecting the protection space and continuing with the next one, but we can at least continue with the
+ request without crendential to make the test pass.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::ResourceHandle::receivedChallengeRejection):
+
2016-07-27 Romain Bellessort <[email protected]>
[Streams API] Replace ReadableStreamReader by ReadableStreamDefaultReader
Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (203774 => 203775)
--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2016-07-27 15:49:57 UTC (rev 203774)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2016-07-27 15:52:24 UTC (rev 203775)
@@ -1247,9 +1247,11 @@
ASSERT_NOT_REACHED();
}
-void ResourceHandle::receivedChallengeRejection(const AuthenticationChallenge&)
+void ResourceHandle::receivedChallengeRejection(const AuthenticationChallenge& challenge)
{
- ASSERT_NOT_REACHED();
+ // This is only used by layout tests, soup based ports don't implement this.
+ notImplemented();
+ receivedRequestToContinueWithoutCredential(challenge);
}
static bool waitingToSendRequest(ResourceHandle* handle)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
