Title: [203778] trunk/Source/WebInspectorUI
- Revision
- 203778
- Author
- [email protected]
- Date
- 2016-07-27 09:14:24 -0700 (Wed, 27 Jul 2016)
Log Message
Regression(r203535): Uncaught Exception: TypeError: Not enough arguments at LayerTreeDataGridNode.js:47
https://bugs.webkit.org/show_bug.cgi?id=160187
<rdar://problem/27540435>
Reviewed by Eric Carlson.
After r203535, document.createTextNode() requires an argument.
* UserInterface/Views/LayerTreeDataGridNode.js:
(WebInspector.LayerTreeDataGridNode.prototype.createCellContent):
Since this use-site is for creating a cell in an unknown column,
initialize it to '–'. Previously it would have been the string
"undefined" or empty.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (203777 => 203778)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-07-27 16:00:16 UTC (rev 203777)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-07-27 16:14:24 UTC (rev 203778)
@@ -1,3 +1,19 @@
+2016-07-27 Brian Burg <[email protected]>
+
+ Regression(r203535): Uncaught Exception: TypeError: Not enough arguments at LayerTreeDataGridNode.js:47
+ https://bugs.webkit.org/show_bug.cgi?id=160187
+ <rdar://problem/27540435>
+
+ Reviewed by Eric Carlson.
+
+ After r203535, document.createTextNode() requires an argument.
+
+ * UserInterface/Views/LayerTreeDataGridNode.js:
+ (WebInspector.LayerTreeDataGridNode.prototype.createCellContent):
+ Since this use-site is for creating a cell in an unknown column,
+ initialize it to '–'. Previously it would have been the string
+ "undefined" or empty.
+
2016-07-24 Matt Baker <[email protected]>
Web Inspector: Filtering is broken in the Overview timeline view
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js (203777 => 203778)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js 2016-07-27 16:00:16 UTC (rev 203777)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js 2016-07-27 16:14:24 UTC (rev 203778)
@@ -44,7 +44,7 @@
createCellContent(columnIdentifier, cell)
{
- var cell = columnIdentifier === "name" ? this._makeNameCell() : this._makeOutlet(columnIdentifier, document.createTextNode());
+ cell = columnIdentifier === "name" ? this._makeNameCell() : this._makeOutlet(columnIdentifier, document.createTextNode("–"));
this._updateCell(columnIdentifier);
return cell;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
