Title: [203780] trunk/Source/WebKit2
Revision
203780
Author
[email protected]
Date
2016-07-27 10:03:19 -0700 (Wed, 27 Jul 2016)

Log Message

Fix m_isInBackground initialization for Safari View Services
https://bugs.webkit.org/show_bug.cgi?id=160255
<rdar://problem/27569255>

Reviewed by Tim Horton.

Fix m_isInBackground initialization for Safari View Services. The
code was using m_applicationStateMonitor without initializing it.
Instead, use the local applicationStateMonitor and make sure we
invalidate it before it gets released.

* UIProcess/ApplicationStateTracker.mm:
(WebKit::ApplicationStateTracker::ApplicationStateTracker):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (203779 => 203780)


--- trunk/Source/WebKit2/ChangeLog	2016-07-27 16:18:29 UTC (rev 203779)
+++ trunk/Source/WebKit2/ChangeLog	2016-07-27 17:03:19 UTC (rev 203780)
@@ -1,3 +1,19 @@
+2016-07-27  Chris Dumez  <[email protected]>
+
+        Fix m_isInBackground initialization for Safari View Services
+        https://bugs.webkit.org/show_bug.cgi?id=160255
+        <rdar://problem/27569255>
+
+        Reviewed by Tim Horton.
+
+        Fix m_isInBackground initialization for Safari View Services. The
+        code was using m_applicationStateMonitor without initializing it.
+        Instead, use the local applicationStateMonitor and make sure we
+        invalidate it before it gets released.
+
+        * UIProcess/ApplicationStateTracker.mm:
+        (WebKit::ApplicationStateTracker::ApplicationStateTracker):
+
 2016-07-27  Carlos Garcia Campos  <[email protected]>
 
         [Coordinated Graphics] Improve scheduling of tasks between threads in CoordinatedGraphicsScene

Modified: trunk/Source/WebKit2/UIProcess/ApplicationStateTracker.mm (203779 => 203780)


--- trunk/Source/WebKit2/UIProcess/ApplicationStateTracker.mm	2016-07-27 16:18:29 UTC (rev 203779)
+++ trunk/Source/WebKit2/UIProcess/ApplicationStateTracker.mm	2016-07-27 17:03:19 UTC (rev 203780)
@@ -144,7 +144,8 @@
         ASSERT(applicationPID);
 
         auto applicationStateMonitor = adoptNS([[BKSApplicationStateMonitor alloc] init]);
-        m_isInBackground = isBackgroundState([m_applicationStateMonitor mostElevatedApplicationStateForPID:applicationPID]);
+        m_isInBackground = isBackgroundState([applicationStateMonitor mostElevatedApplicationStateForPID:applicationPID]);
+        [applicationStateMonitor invalidate];
 
         m_didEnterBackgroundObserver = [notificationCenter addObserverForName:@"_UIViewServiceHostDidEnterBackgroundNotification" object:serviceViewController queue:nil usingBlock:[this](NSNotification *) {
             applicationDidEnterBackground();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to