Title: [203796] trunk
Revision
203796
Author
[email protected]
Date
2016-07-27 14:36:11 -0700 (Wed, 27 Jul 2016)

Log Message

First parameter to Range.createContextualFragment() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160266

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

* web-platform-tests/domparsing/createContextualFragment-expected.txt:

Source/WebCore:

First parameter to Range.createContextualFragment() should be mandatory:
- https://w3c.github.io/DOM-Parsing/#extensions-to-the-range-interface

Firefox and Chrome agree with the specification.

No new tests, rebaselined existing test.

* dom/Range.idl:

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203795 => 203796)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-07-27 21:33:57 UTC (rev 203795)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-07-27 21:36:11 UTC (rev 203796)
@@ -1,5 +1,16 @@
 2016-07-27  Chris Dumez  <[email protected]>
 
+        First parameter to Range.createContextualFragment() should be mandatory
+        https://bugs.webkit.org/show_bug.cgi?id=160266
+
+        Reviewed by Ryosuke Niwa.
+
+        Rebaseline W3C test now that one more check is passing.
+
+        * web-platform-tests/domparsing/createContextualFragment-expected.txt:
+
+2016-07-27  Chris Dumez  <[email protected]>
+
         First parameter to indexed property getters should be mandatory
         https://bugs.webkit.org/show_bug.cgi?id=160259
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/domparsing/createContextualFragment-expected.txt (203795 => 203796)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/domparsing/createContextualFragment-expected.txt	2016-07-27 21:33:57 UTC (rev 203795)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/domparsing/createContextualFragment-expected.txt	2016-07-27 21:36:11 UTC (rev 203796)
@@ -1,7 +1,6 @@
 
 PASS Must not throw INVALID_STATE_ERR for a detached node. 
-FAIL Must throw TypeError when calling without arguments assert_throws: function "function () {
-                range.createContextualFragm..." did not throw
+PASS Must throw TypeError when calling without arguments 
 PASS Simple test with paragraphs 
 PASS Don't auto-create <body> when applied to <html> 
 PASS <script>s should be run when appended to the document (but not before) 

Modified: trunk/Source/WebCore/ChangeLog (203795 => 203796)


--- trunk/Source/WebCore/ChangeLog	2016-07-27 21:33:57 UTC (rev 203795)
+++ trunk/Source/WebCore/ChangeLog	2016-07-27 21:36:11 UTC (rev 203796)
@@ -1,5 +1,21 @@
 2016-07-27  Chris Dumez  <[email protected]>
 
+        First parameter to Range.createContextualFragment() should be mandatory
+        https://bugs.webkit.org/show_bug.cgi?id=160266
+
+        Reviewed by Ryosuke Niwa.
+
+        First parameter to Range.createContextualFragment() should be mandatory:
+        - https://w3c.github.io/DOM-Parsing/#extensions-to-the-range-interface
+
+        Firefox and Chrome agree with the specification.
+
+        No new tests, rebaselined existing test.
+
+        * dom/Range.idl:
+
+2016-07-27  Chris Dumez  <[email protected]>
+
         Align MediaList with the CSSOM specification
         https://bugs.webkit.org/show_bug.cgi?id=160257
 

Modified: trunk/Source/WebCore/dom/Range.idl (203795 => 203796)


--- trunk/Source/WebCore/dom/Range.idl	2016-07-27 21:33:57 UTC (rev 203795)
+++ trunk/Source/WebCore/dom/Range.idl	2016-07-27 21:36:11 UTC (rev 203796)
@@ -76,8 +76,7 @@
 
     // extensions
 
-    // FIXME: Using "undefined" as default parameter value is wrong.
-    [RaisesException] DocumentFragment createContextualFragment(optional DOMString html = "undefined");
+    [RaisesException, NewObject] DocumentFragment createContextualFragment(DOMString html);
 
     // WebKit extensions
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to