Title: [203814] trunk/Source/WebCore
Revision
203814
Author
[email protected]
Date
2016-07-27 23:37:45 -0700 (Wed, 27 Jul 2016)

Log Message

[Streams API] Use makeThisTypeError in ReadableStreamDefaultReader.js
https://bugs.webkit.org/show_bug.cgi?id=160254

Patch by Romain Bellessort <[email protected]> on 2016-07-27
Reviewed by Darin Adler.

Use makeThisTypeError and makeGetterTypeError in ReadableStreamDefaultReader.js

No change in functionality.

* Modules/streams/ReadableStreamDefaultReader.js:
(cancel):
(read):
(releaseLock):
(closed):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (203813 => 203814)


--- trunk/Source/WebCore/ChangeLog	2016-07-28 06:28:11 UTC (rev 203813)
+++ trunk/Source/WebCore/ChangeLog	2016-07-28 06:37:45 UTC (rev 203814)
@@ -1,3 +1,20 @@
+2016-07-27  Romain Bellessort  <[email protected]>
+
+        [Streams API] Use makeThisTypeError in ReadableStreamDefaultReader.js
+        https://bugs.webkit.org/show_bug.cgi?id=160254
+
+        Reviewed by Darin Adler.
+
+        Use makeThisTypeError and makeGetterTypeError in ReadableStreamDefaultReader.js
+
+        No change in functionality.
+
+        * Modules/streams/ReadableStreamDefaultReader.js:
+        (cancel):
+        (read):
+        (releaseLock):
+        (closed):
+
 2016-07-27  Fujii Hironori  <[email protected]>
 
         [soup] Incorrect usage of relaxAdoptionRequirement in the constructor of SocketStreamHandle

Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js (203813 => 203814)


--- trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js	2016-07-28 06:28:11 UTC (rev 203813)
+++ trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js	2016-07-28 06:37:45 UTC (rev 203814)
@@ -30,7 +30,7 @@
     "use strict";
 
     if (!@isReadableStreamDefaultReader(this))
-        return @Promise.@reject(new @TypeError("Can only call ReadableStreamDefaultReader.cancel on instances of ReadableStreamDefaultReader"));
+        return @Promise.@reject(@makeThisTypeError("ReadableStreamDefaultReader", "cancel"));
 
     if (!this.@ownerReadableStream)
         return @Promise.@reject(new @TypeError("cancel() called on a reader owned by no readable stream"));
@@ -43,7 +43,7 @@
     "use strict";
 
     if (!@isReadableStreamDefaultReader(this))
-        return @Promise.@reject(new @TypeError("Can only call ReadableStreamDefaultReader.read on instances of ReadableStreamDefaultReader"));
+        return @Promise.@reject(@makeThisTypeError("ReadableStreamDefaultReader", "read"));
     if (!this.@ownerReadableStream)
         return @Promise.@reject(new @TypeError("read() called on a reader owned by no readable stream"));
 
@@ -55,7 +55,7 @@
     "use strict";
 
     if (!@isReadableStreamDefaultReader(this))
-        throw new @TypeError("Can only call ReadableStreamDefaultReader.releaseLock on instances of ReadableStreamDefaultReader");
+        throw @makeThisTypeError("ReadableStreamDefaultReader", "releaseLock");
 
     const stream = this.@ownerReadableStream;
     if (!stream)
@@ -78,7 +78,7 @@
     "use strict";
 
     if (!@isReadableStreamDefaultReader(this))
-        return @Promise.@reject(new @TypeError("The ReadableStreamDefaultReader.closed getter can only be used on instances of ReadableStreamDefaultReader"));
+        return @Promise.@reject(@makeGetterTypeError("ReadableStreamDefaultReader", "closed"));
 
     return this.@closedPromiseCapability.@promise;
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to