Title: [203844] trunk/Source/WebInspectorUI
- Revision
- 203844
- Author
- [email protected]
- Date
- 2016-07-28 14:51:50 -0700 (Thu, 28 Jul 2016)
Log Message
Web Inspector: Hiding a column which contains a TimelineRuler as the headerview, doesn't hide the headerView
https://bugs.webkit.org/show_bug.cgi?id=160093
<rdar://problem/27499300>
Reviewed by Joseph Pecoraro.
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype._positionHeaderViews):
Remove early return so that a header view in a hidden column will have
its width resized to zero, matching the column.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (203843 => 203844)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-07-28 21:38:50 UTC (rev 203843)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-07-28 21:51:50 UTC (rev 203844)
@@ -1,3 +1,16 @@
+2016-07-28 Matt Baker <[email protected]>
+
+ Web Inspector: Hiding a column which contains a TimelineRuler as the headerview, doesn't hide the headerView
+ https://bugs.webkit.org/show_bug.cgi?id=160093
+ <rdar://problem/27499300>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGrid.prototype._positionHeaderViews):
+ Remove early return so that a header view in a hidden column will have
+ its width resized to zero, matching the column.
+
2016-07-28 Johan K. Jensen <[email protected]>
Web Inspector: Waterfall view should be visible in Network tab and Network Timeline
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (203843 => 203844)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-07-28 21:38:50 UTC (rev 203843)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-07-28 21:51:50 UTC (rev 203844)
@@ -984,17 +984,6 @@
_positionHeaderViews()
{
- let visibleHeaderViews = false;
- for (let column of this.columns.values()) {
- if (column["headerView"] && !column["hidden"]) {
- visibleHeaderViews = true;
- break;
- }
- }
-
- if (!visibleHeaderViews)
- return;
-
let left = 0;
let headerViews = [];
let lefts = [];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
