Title: [203910] trunk/Source/WebCore
- Revision
- 203910
- Author
- [email protected]
- Date
- 2016-07-29 11:47:52 -0700 (Fri, 29 Jul 2016)
Log Message
Remove an unused line of code.
https://bugs.webkit.org/show_bug.cgi?id=160350
Reviewed by Simon Fraser.
No new tests because there's no behavior change. Just removing dead code.
SVGInlineTextBox::paintText() instantiates a local variable selectionTextRun.
Thanks to analysis by Said Abou-Hallawa, we know that selectionTextRun
was introduced in https://trac.webkit.org/changeset/61393, but was later
rendered unused in https://trac.webkit.org/changeset/62099 because we
switched to using paintTextWithShadows() with the selectionStyle. Hence,
selectionTextRun can be removed.
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintText):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (203909 => 203910)
--- trunk/Source/WebCore/ChangeLog 2016-07-29 18:45:15 UTC (rev 203909)
+++ trunk/Source/WebCore/ChangeLog 2016-07-29 18:47:52 UTC (rev 203910)
@@ -1,3 +1,22 @@
+2016-07-29 Mark Lam <[email protected]>
+
+ Remove an unused line of code.
+ https://bugs.webkit.org/show_bug.cgi?id=160350
+
+ Reviewed by Simon Fraser.
+
+ No new tests because there's no behavior change. Just removing dead code.
+
+ SVGInlineTextBox::paintText() instantiates a local variable selectionTextRun.
+ Thanks to analysis by Said Abou-Hallawa, we know that selectionTextRun
+ was introduced in https://trac.webkit.org/changeset/61393, but was later
+ rendered unused in https://trac.webkit.org/changeset/62099 because we
+ switched to using paintTextWithShadows() with the selectionStyle. Hence,
+ selectionTextRun can be removed.
+
+ * rendering/svg/SVGInlineTextBox.cpp:
+ (WebCore::SVGInlineTextBox::paintText):
+
2016-07-29 Eric Carlson <[email protected]>
Change internal AVCaptureDeviceType typedef name
Modified: trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp (203909 => 203910)
--- trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp 2016-07-29 18:45:15 UTC (rev 203909)
+++ trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp 2016-07-29 18:47:52 UTC (rev 203910)
@@ -612,7 +612,6 @@
if (style != selectionStyle)
SVGResourcesCache::clientStyleChanged(parent()->renderer(), StyleDifferenceRepaint, *selectionStyle);
- TextRun selectionTextRun = constructTextRun(selectionStyle, fragment);
paintTextWithShadows(context, selectionStyle, textRun, fragment, startPosition, endPosition);
if (style != selectionStyle)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
