[webkit-changes] [98262] trunk/Source/WebCore

Mon, 24 Oct 2011 11:40:41 -0700

Title: [98262] trunk/Source/WebCore
Revision
98262
Author
[email protected]
Date
2011-10-24 11:41:35 -0700 (Mon, 24 Oct 2011)

Log Message

Node::registeredMutationObserversOfType should be prefixed by "get"
https://bugs.webkit.org/show_bug.cgi?id=70359

Patch by Rafael Weinstein <[email protected]> on 2011-10-24
Reviewed by Ojan Vafai.

This change renames Node::registeredMutationObserversOfType to
Node::getRegisteredMutationObserversOfType per the WebKit style guide.

No tests needed as the change is only method renaming.

* dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):
* dom/ChildListMutationScope.cpp:
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):
* dom/Element.cpp:
(WebCore::enqueueAttributesMutationRecord):
* dom/Node.cpp:
(WebCore::Node::getRegisteredMutationObserversOfType):
* dom/Node.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (98261 => 98262)


--- trunk/Source/WebCore/ChangeLog	2011-10-24 18:37:37 UTC (rev 98261)
+++ trunk/Source/WebCore/ChangeLog	2011-10-24 18:41:35 UTC (rev 98262)
@@ -1,3 +1,25 @@
+2011-10-24  Rafael Weinstein  <[email protected]>
+
+        Node::registeredMutationObserversOfType should be prefixed by "get"
+        https://bugs.webkit.org/show_bug.cgi?id=70359
+
+        Reviewed by Ojan Vafai.
+
+        This change renames Node::registeredMutationObserversOfType to
+        Node::getRegisteredMutationObserversOfType per the WebKit style guide.
+
+        No tests needed as the change is only method renaming.
+
+        * dom/CharacterData.cpp:
+        (WebCore::CharacterData::dispatchModifiedEvent):
+        * dom/ChildListMutationScope.cpp:
+        (WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):
+        * dom/Element.cpp:
+        (WebCore::enqueueAttributesMutationRecord):
+        * dom/Node.cpp:
+        (WebCore::Node::getRegisteredMutationObserversOfType):
+        * dom/Node.h:
+
 2011-10-24  Mark Hahnenberg  <[email protected]>
 
         Rename static getOwnPropertySlot to getOwnPropertySlotByIndex

Modified: trunk/Source/WebCore/dom/CharacterData.cpp (98261 => 98262)


--- trunk/Source/WebCore/dom/CharacterData.cpp	2011-10-24 18:37:37 UTC (rev 98261)
+++ trunk/Source/WebCore/dom/CharacterData.cpp	2011-10-24 18:41:35 UTC (rev 98262)
@@ -194,7 +194,7 @@
 {
 #if ENABLE(MUTATION_OBSERVERS)
     Vector<WebKitMutationObserver*> observers;
-    registeredMutationObserversOfType(observers, WebKitMutationObserver::CharacterData);
+    getRegisteredMutationObserversOfType(observers, WebKitMutationObserver::CharacterData);
     if (!observers.isEmpty()) {
         RefPtr<MutationRecord> mutation = MutationRecord::createCharacterData(this);
         for (size_t i = 0; i < observers.size(); ++i)

Modified: trunk/Source/WebCore/dom/ChildListMutationScope.cpp (98261 => 98262)


--- trunk/Source/WebCore/dom/ChildListMutationScope.cpp	2011-10-24 18:37:37 UTC (rev 98261)
+++ trunk/Source/WebCore/dom/ChildListMutationScope.cpp	2011-10-24 18:41:35 UTC (rev 98262)
@@ -245,7 +245,7 @@
     }
 
     Vector<WebKitMutationObserver*> observers;
-    target->registeredMutationObserversOfType(observers, WebKitMutationObserver::ChildList);
+    target->getRegisteredMutationObserversOfType(observers, WebKitMutationObserver::ChildList);
     if (observers.isEmpty())
         m_accumulations.set(target, 0);
     else

Modified: trunk/Source/WebCore/dom/Element.cpp (98261 => 98262)


--- trunk/Source/WebCore/dom/Element.cpp	2011-10-24 18:37:37 UTC (rev 98261)
+++ trunk/Source/WebCore/dom/Element.cpp	2011-10-24 18:41:35 UTC (rev 98262)
@@ -620,7 +620,7 @@
 static void enqueueAttributesMutationRecord(Element* element, const QualifiedName& name)
 {
     Vector<WebKitMutationObserver*> observers;
-    element->registeredMutationObserversOfType(observers, WebKitMutationObserver::Attributes);
+    element->getRegisteredMutationObserversOfType(observers, WebKitMutationObserver::Attributes);
     if (observers.isEmpty())
         return;

Modified: trunk/Source/WebCore/dom/Node.cpp (98261 => 98262)


--- trunk/Source/WebCore/dom/Node.cpp	2011-10-24 18:37:37 UTC (rev 98261)
+++ trunk/Source/WebCore/dom/Node.cpp	2011-10-24 18:41:35 UTC (rev 98262)
@@ -2711,7 +2711,7 @@
     }
 }
 
-void Node::registeredMutationObserversOfType(Vector<WebKitMutationObserver*>& observers, WebKitMutationObserver::MutationType type)
+void Node::getRegisteredMutationObserversOfType(Vector<WebKitMutationObserver*>& observers, WebKitMutationObserver::MutationType type)
 {
     HashSet<WebKitMutationObserver*> observerSet;
     addMatchingObservers(observerSet, mutationObserverEntries(), type);

Modified: trunk/Source/WebCore/dom/Node.h (98261 => 98262)


--- trunk/Source/WebCore/dom/Node.h	2011-10-24 18:37:37 UTC (rev 98261)
+++ trunk/Source/WebCore/dom/Node.h	2011-10-24 18:41:35 UTC (rev 98262)
@@ -589,7 +589,7 @@
 #endif
 
 #if ENABLE(MUTATION_OBSERVERS)
-    void registeredMutationObserversOfType(Vector<WebKitMutationObserver*>&, WebKitMutationObserver::MutationType);
+    void getRegisteredMutationObserversOfType(Vector<WebKitMutationObserver*>&, WebKitMutationObserver::MutationType);
 
     enum MutationRegistrationResult {
         MutationObserverRegistered,

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to