Title: [203991] trunk/Source/WebInspectorUI
- Revision
- 203991
- Author
- [email protected]
- Date
- 2016-08-01 15:31:02 -0700 (Mon, 01 Aug 2016)
Log Message
Web Inspector: Grid column resizer elements positioned incorrectly
https://bugs.webkit.org/show_bug.cgi?id=160311
<rdar://problem/27595586>
Reviewed by Brian Burg.
Perform a resize layout on a newly shown tab content view if the tab
browser was resized before showing the tab.
* UserInterface/Views/TabBrowser.js:
(WebInspector.TabBrowser):
(WebInspector.TabBrowser.prototype.layout):
Mark all recent tab content views (except for the current view)
as needing a resize layout.
(WebInspector.TabBrowser.prototype._tabBarItemSelected):
If the tab browser was resized while the view was hidden, update the
view's layout for the new content view container size.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (203990 => 203991)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-08-01 22:20:49 UTC (rev 203990)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-08-01 22:31:02 UTC (rev 203991)
@@ -1,5 +1,26 @@
2016-08-01 Matt Baker <[email protected]>
+ Web Inspector: Grid column resizer elements positioned incorrectly
+ https://bugs.webkit.org/show_bug.cgi?id=160311
+ <rdar://problem/27595586>
+
+ Reviewed by Brian Burg.
+
+ Perform a resize layout on a newly shown tab content view if the tab
+ browser was resized before showing the tab.
+
+ * UserInterface/Views/TabBrowser.js:
+ (WebInspector.TabBrowser):
+ (WebInspector.TabBrowser.prototype.layout):
+ Mark all recent tab content views (except for the current view)
+ as needing a resize layout.
+
+ (WebInspector.TabBrowser.prototype._tabBarItemSelected):
+ If the tab browser was resized while the view was hidden, update the
+ view's layout for the new content view container size.
+
+2016-08-01 Matt Baker <[email protected]>
+
Web Inspector: Waterfall graph in Network tab shows too much whitespace/dead time
https://bugs.webkit.org/show_bug.cgi?id=160373
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js (203990 => 203991)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js 2016-08-01 22:20:49 UTC (rev 203990)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js 2016-08-01 22:31:02 UTC (rev 203991)
@@ -199,6 +199,17 @@
return true;
}
+ // Protected
+
+ layout()
+ {
+ if (this.layoutReason !== WebInspector.View.LayoutReason.Resize)
+ return;
+
+ for (let tabContentView of this._recentTabContentViews)
+ tabContentView[WebInspector.TabBrowser.NeedsResizeLayoutSymbol] = tabContentView !== this.selectedTabContentView;
+ }
+
// Private
_tabBarItemSelected(event)
@@ -223,6 +234,12 @@
this._showNavigationSidebarPanelForTabContentView(tabContentView);
this._showDetailsSidebarPanelsForTabContentView(tabContentView);
+ // If the tab browser was resized prior to showing the tab, the new tab needs to perform a resize layout.
+ if (tabContentView && tabContentView[WebInspector.TabBrowser.NeedsResizeLayoutSymbol]) {
+ tabContentView[WebInspector.TabBrowser.NeedsResizeLayoutSymbol] = false;
+ tabContentView.updateLayout(WebInspector.View.LayoutReason.Resize);
+ }
+
this.dispatchEventToListeners(WebInspector.TabBrowser.Event.SelectedTabContentViewDidChange);
}
@@ -394,6 +411,8 @@
}
};
+WebInspector.TabBrowser.NeedsResizeLayoutSymbol = Symbol("needs-resize-layout");
+
WebInspector.TabBrowser.Event = {
SelectedTabContentViewDidChange: "tab-browser-selected-tab-content-view-did-change"
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
