Title: [204007] trunk/Tools
- Revision
- 204007
- Author
- [email protected]
- Date
- 2016-08-01 18:50:16 -0700 (Mon, 01 Aug 2016)
Log Message
[Tools] The GDB backtrace report tool don't checks the gdb return code.
https://bugs.webkit.org/show_bug.cgi?id=160414
Reviewed by Michael Catanzaro.
* Scripts/webkitpy/port/linux_get_crash_log.py:
(GDBCrashLogGenerator._wait_for_corefile):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (204006 => 204007)
--- trunk/Tools/ChangeLog 2016-08-02 01:44:43 UTC (rev 204006)
+++ trunk/Tools/ChangeLog 2016-08-02 01:50:16 UTC (rev 204007)
@@ -1,3 +1,13 @@
+2016-08-01 Carlos Alberto Lopez Perez <[email protected]>
+
+ [Tools] The GDB backtrace report tool don't checks the gdb return code.
+ https://bugs.webkit.org/show_bug.cgi?id=160414
+
+ Reviewed by Michael Catanzaro.
+
+ * Scripts/webkitpy/port/linux_get_crash_log.py:
+ (GDBCrashLogGenerator._wait_for_corefile):
+
2016-08-01 Youenn Fablet <[email protected]>
Make wpt server generate its certificates in layout test results folder
Modified: trunk/Tools/Scripts/webkitpy/port/linux_get_crash_log.py (204006 => 204007)
--- trunk/Tools/Scripts/webkitpy/port/linux_get_crash_log.py 2016-08-02 01:44:43 UTC (rev 204006)
+++ trunk/Tools/Scripts/webkitpy/port/linux_get_crash_log.py 2016-08-02 01:50:16 UTC (rev 204007)
@@ -45,6 +45,8 @@
proc = subprocess.Popen(cmd, stdin=None, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
stdout, stderr = proc.communicate()
errors = [stderr_line.strip().decode('utf8', 'ignore') for stderr_line in stderr.splitlines()]
+ if proc.returncode != 0:
+ stdout = ('ERROR: The gdb process exited with non-zero return code %s\n\n' % proc.returncode) + stdout
return (stdout.decode('utf8', 'ignore'), errors)
def generate_crash_log(self, stdout, stderr):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
