Title: [204087] trunk/Tools
Revision
204087
Author
clo...@igalia.com
Date
2016-08-03 11:05:50 -0700 (Wed, 03 Aug 2016)

Log Message

Benchmark test content-animation timeouts always
https://bugs.webkit.org/show_bug.cgi?id=160057

Reviewed by Simon Fraser.

* Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
* Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(start):

Modified Paths

Added Paths

Diff

Modified: trunk/Tools/ChangeLog (204086 => 204087)


--- trunk/Tools/ChangeLog	2016-08-03 17:22:36 UTC (rev 204086)
+++ trunk/Tools/ChangeLog	2016-08-03 18:05:50 UTC (rev 204087)
@@ -1,3 +1,14 @@
+2016-08-03  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        Benchmark test content-animation timeouts always
+        https://bugs.webkit.org/show_bug.cgi?id=160057
+
+        Reviewed by Simon Fraser.
+
+        * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
+        * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
+        (start):
+
 2016-08-02  Nan Wang  <n_w...@apple.com>
 
         AX: Simulated touch events are not working on iOS

Added: trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/Skipped (0 => 204087)


--- trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/Skipped	                        (rev 0)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/Skipped	2016-08-03 18:05:50 UTC (rev 204087)
@@ -0,0 +1,2 @@
+# This file contains the plans that should not be run automatically with the --allplans command line switch.
+content-animation

Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py (204086 => 204087)


--- trunk/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py	2016-08-03 17:22:36 UTC (rev 204086)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py	2016-08-03 18:05:50 UTC (rev 204087)
@@ -48,11 +48,18 @@
         return
     if args.allplans:
         failed = []
+        skipped = []
         plandir = os.path.join(os.path.dirname(__file__), 'data/plans')
         planlist = [os.path.splitext(f)[0] for f in os.listdir(plandir) if f.endswith('.plan')]
+        skippedfile = os.path.join(plandir, 'Skipped')
         if not planlist:
             raise Exception('Cant find any .plan file in directory %s' % plandir)
+        if os.path.isfile(skippedfile):
+            skipped = [line.strip() for line in open(skippedfile) if not line.startswith('#') and len(line) > 1]
         for plan in sorted(planlist):
+            if plan in skipped:
+                _log.info('Skipping benchmark plan: %s because is listed on the Skipped file' % plan)
+                continue
             _log.info('Starting benchmark plan: %s' % plan)
             try:
                 runner = BenchmarkRunner(plan, args.localCopy, args.countOverride, args.buildDir, args.output, args.platform, args.browser, args.scale_unit, args.device_id)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to