Title: [204099] trunk/Source/WebInspectorUI
Revision
204099
Author
[email protected]
Date
2016-08-03 13:49:15 -0700 (Wed, 03 Aug 2016)

Log Message

Web Inspector: Cmd-L shortcut for Jump to Line conflicts with selecting URL of inspected page
https://bugs.webkit.org/show_bug.cgi?id=158028
<rdar://problem/26516663>

Reviewed by Timothy Hatcher.

Remove Command-L shortcut for opening the Line Number dialog, since
we already support Control-G.

* UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (204098 => 204099)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-08-03 20:23:02 UTC (rev 204098)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-08-03 20:49:15 UTC (rev 204099)
@@ -1,3 +1,17 @@
+2016-08-03  Matt Baker  <[email protected]>
+
+        Web Inspector: Cmd-L shortcut for Jump to Line conflicts with selecting URL of inspected page
+        https://bugs.webkit.org/show_bug.cgi?id=158028
+        <rdar://problem/26516663>
+
+        Reviewed by Timothy Hatcher.
+
+        Remove Command-L shortcut for opening the Line Number dialog, since
+        we already support Control-G.
+
+        * UserInterface/Views/SourceCodeTextEditor.js:
+        (WebInspector.SourceCodeTextEditor): Deleted.
+
 2016-08-01  Nikita Vasilyev  <[email protected]>
 
         Web Inspector: Don't set `width:calc(100% - 0px); left:0px` on console messages

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (204098 => 204099)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js	2016-08-03 20:23:02 UTC (rev 204098)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js	2016-08-03 20:49:15 UTC (rev 204099)
@@ -82,8 +82,6 @@
 
         sourceCode.requestContent().then(this._contentAvailable.bind(this));
 
-        // FIXME: Cmd+L shortcut doesn't actually work.
-        new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Command, "L", this.showGoToLineDialog.bind(this), this.element);
         new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Control, "G", this.showGoToLineDialog.bind(this), this.element);
 
         WebInspector.logManager.addEventListener(WebInspector.LogManager.Event.Cleared, this._logCleared, this);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to