Modified: trunk/Tools/ChangeLog (204155 => 204156)
--- trunk/Tools/ChangeLog 2016-08-05 00:23:12 UTC (rev 204155)
+++ trunk/Tools/ChangeLog 2016-08-05 00:46:05 UTC (rev 204156)
@@ -1,3 +1,20 @@
+2016-08-04 Dean Johnson <dean_john...@apple.com>
+
+ UI improvements to Flakiness Dashboard.
+ https://bugs.webkit.org/show_bug.cgi?id=153295
+
+ Reviewed by Alexey Proskuryakov.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard.css:
+ (td.options-container): Center text in most fields.
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+ (createBugHTML): Text/Grammar updates.
+ (tableHeaders): Ditto.
+ (htmlForSingleTestRow): Ditto.
+ (headerForTestTableHtml): Ditto.
+ * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
+ (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
+
2016-08-04 Carlos Alberto Lopez Perez <clo...@igalia.com>
[GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.css (204155 => 204156)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.css 2016-08-05 00:23:12 UTC (rev 204155)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.css 2016-08-05 00:46:05 UTC (rev 204156)
@@ -47,6 +47,9 @@
padding-left: 2em;
white-space: nowrap;
}
+td.options-container {
+ text-align: center;
+}
.forms {
display: -webkit-box;
-webkit-box-align: baseline;
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (204155 => 204156)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2016-08-05 00:23:12 UTC (rev 204155)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2016-08-05 00:46:05 UTC (rev 204156)
@@ -1328,7 +1328,7 @@
var component = encodeURIComponent('Tools / Tests');
url = '' + component + '&short_desc=' + title + '&comment=' + description;
- return '<a href="" + url + '" class="file-bug">FILE BUG</a>';
+ return '<a href="" + url + '" class="file-bug">File</a>';
}
function isCrossBuilderView()
@@ -1340,15 +1340,15 @@
{
var headers = [];
if (isCrossBuilderView() || opt_getAll)
- headers.push('builder');
+ headers.push('Builder');
if (!isCrossBuilderView() || opt_getAll)
- headers.push('test');
+ headers.push('Test');
if (g_history.isLayoutTestResults() || opt_getAll)
- headers.push('bugs', 'modifiers', 'expectations');
+ headers.push('Bug(s)', 'Modifiers', 'Expectation(s)');
- headers.push('slowest run', 'flakiness (numbers are runtimes in seconds)');
+ headers.push('Slowest Run', 'Flakiness (Numbers are runtimes in seconds)');
return headers;
}
@@ -1366,7 +1366,7 @@
var html = '';
for (var i = 0; i < headers.length; i++) {
var header = headers[i];
- if (string.startsWith(header, 'test') || string.startsWith(header, 'builder')) {
+ if (string.startsWith(header, 'Test') || string.startsWith(header, 'Builder')) {
// If isCrossBuilderView() is true, we're just viewing a single test
// with results for many builders, so the first column is builder names
// instead of test paths.
@@ -1374,15 +1374,15 @@
var testCellHTML = isCrossBuilderView() ? test.builder : '<span class="link" _onclick_="g_history.setQueryParameter(\'tests\',\'' + test.test +'\');">' + test.test + '</span>';
html += '<tr><td class="' + testCellClassName + '">' + testCellHTML;
- } else if (string.startsWith(header, 'bugs'))
- html += '<td class=options-container>' + (test.bugs ? htmlForBugs(test.bugs) : createBugHTML(test));
- else if (string.startsWith(header, 'modifiers'))
+ } else if (string.startsWith(header, 'Bug(s)'))
+ html += '<td class=options-container bugs>' + (test.bugs ? htmlForBugs(test.bugs) : createBugHTML(test));
+ else if (string.startsWith(header, 'Modifiers'))
html += '<td class=options-container>' + test.modifiers;
- else if (string.startsWith(header, 'expectations'))
- html += '<td class=options-container>' + test.expectations;
- else if (string.startsWith(header, 'slowest'))
- html += '<td>' + (test.slowestTime ? test.slowestTime + 's' : '');
- else if (string.startsWith(header, 'flakiness'))
+ else if (string.startsWith(header, 'Expectation(s)'))
+ html += '<td class=options-container>' + test.expectations.split(' ').join(' | ');
+ else if (string.startsWith(header, 'Slowest'))
+ html += '<td class=options-container>' + (test.slowestTime ? test.slowestTime + 's' : '');
+ else if (string.startsWith(header, 'Flakiness'))
html += htmlForTestResults(test);
}
return html;
@@ -2177,12 +2177,12 @@
function headerForTestTableHtml()
{
- return '<h2 style="display:inline-block">Failing tests</h2>' +
- checkBoxToToggleState('showWontFixSkip', 'WONTFIX/SKIP') +
- checkBoxToToggleState('showCorrectExpectations', 'tests with correct expectations') +
- checkBoxToToggleState('showWrongExpectations', 'tests with wrong expectations') +
- checkBoxToToggleState('showFlaky', 'flaky') +
- checkBoxToToggleState('showSlow', 'slow');
+ return '<h2 style="display:inline-block">Show Tests Flagged As/With: </h2>' +
+ checkBoxToToggleState('showWontFixSkip', "Won't Fix/Skip") +
+ checkBoxToToggleState('showCorrectExpectations', 'Correct Expectations') +
+ checkBoxToToggleState('showWrongExpectations', 'Incorrect Expectations') +
+ checkBoxToToggleState('showFlaky', 'Flaky') +
+ checkBoxToToggleState('showSlow', 'Slow');
}
function generatePageForBuilder(builderName)
Modified: trunk/Tools/TestResultServer/static-dashboards/ui.js (204155 => 204156)
--- trunk/Tools/TestResultServer/static-dashboards/ui.js 2016-08-05 00:23:12 UTC (rev 204155)
+++ trunk/Tools/TestResultServer/static-dashboards/ui.js 2016-08-05 00:46:05 UTC (rev 204156)
@@ -110,8 +110,6 @@
ui.html._dashboardLink('Results', 'flakiness_dashboard.html') +
ui.html._dashboardLink('Treemap', 'treemap.html');
- html += ui.html.select('Test type', 'testType', TEST_TYPES);
-
if (!opt_noBuilderMenu) {
var buildersForMenu = Object.keys(currentBuilders());
if (opt_includeNoneBuilder)
@@ -119,9 +117,6 @@
html += ui.html.select('Builder', 'builder', buildersForMenu);
}
- html += ui.html.select('Group', 'group',
- Object.keys(currentBuilderGroupCategory()));
-
if (!history.isTreeMap())
html += ui.html.checkbox('showAllRuns', 'Show all runs', g_history.crossDashboardState.showAllRuns);
@@ -212,4 +207,4 @@
}
}
-})();
\ No newline at end of file
+})();
