Title: [204159] trunk/Source/WebCore
Revision
204159
Author
mmaxfi...@apple.com
Date
2016-08-04 19:35:28 -0700 (Thu, 04 Aug 2016)

Log Message

[iOS] Some videos in iBooks erroneously go fullscreen
https://bugs.webkit.org/show_bug.cgi?id=160582
<rdar://problem/27669831>

Reviewed by Jon Lee.

No new tests because we can't currently mock the iBooks application bundle ID.

* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (204158 => 204159)


--- trunk/Source/WebCore/ChangeLog	2016-08-05 02:09:14 UTC (rev 204158)
+++ trunk/Source/WebCore/ChangeLog	2016-08-05 02:35:28 UTC (rev 204159)
@@ -1,3 +1,16 @@
+2016-08-04  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+        [iOS] Some videos in iBooks erroneously go fullscreen
+        https://bugs.webkit.org/show_bug.cgi?id=160582
+        <rdar://problem/27669831>
+
+        Reviewed by Jon Lee.
+
+        No new tests because we can't currently mock the iBooks application bundle ID.
+
+        * html/MediaElementSession.cpp:
+        (WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):
+
 2016-08-04  Michael Catanzaro  <mcatanz...@igalia.com>
 
         [Fontconfig] Segmentation fault in WebCore::FontCache::lastResortFallbackFont

Modified: trunk/Source/WebCore/html/MediaElementSession.cpp (204158 => 204159)


--- trunk/Source/WebCore/html/MediaElementSession.cpp	2016-08-05 02:09:14 UTC (rev 204158)
+++ trunk/Source/WebCore/html/MediaElementSession.cpp	2016-08-05 02:35:28 UTC (rev 204159)
@@ -470,6 +470,8 @@
         return false;
 
 #if PLATFORM(IOS)
+    if (IOSApplication::isIBooks())
+        return !element.hasAttributeWithoutSynchronization(HTMLNames::webkit_playsinlineAttr) && !element.hasAttributeWithoutSynchronization(HTMLNames::playsinlineAttr);
     if (dyld_get_program_sdk_version() < DYLD_IOS_VERSION_10_0)
         return !element.hasAttributeWithoutSynchronization(HTMLNames::webkit_playsinlineAttr);
 #endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to