Title: [204191] trunk/LayoutTests
- Revision
- 204191
- Author
- [email protected]
- Date
- 2016-08-05 13:27:33 -0700 (Fri, 05 Aug 2016)
Log Message
Remove testRunner.handleErrorPages()
https://bugs.webkit.org/show_bug.cgi?id=160552
Patch by Jonathan Bedard <[email protected]> on 2016-08-05
Reviewed by Daniel Bates.
handleErrorPages() was implemented by the Qt WebKit port, per
https://bugs.webkit.org/show_bug.cgi?id=31509#c0, but never implemented
on other ports. Per https://bugs.webkit.org/show_bug.cgi?id=31555, this
feature was never implemented on Mac.
* fast/history/back-forward-reset-after-error-handling-expected.txt: Removed test expectations.
* fast/history/back-forward-reset-after-error-handling.html: Removed test.
* platform/efl/TestExpectations: Remove reference to back-forward-reset-after-error-handling.
* platform/gtk/TestExpectations: Ditto.
* platform/ios-simulator/TestExpectations: Ditto.
* platform/mac/TestExpectations: Ditto.
* platform/win/TestExpectations: Ditto.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (204190 => 204191)
--- trunk/LayoutTests/ChangeLog 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/ChangeLog 2016-08-05 20:27:33 UTC (rev 204191)
@@ -1,3 +1,23 @@
+2016-08-05 Jonathan Bedard <[email protected]>
+
+ Remove testRunner.handleErrorPages()
+ https://bugs.webkit.org/show_bug.cgi?id=160552
+
+ Reviewed by Daniel Bates.
+
+ handleErrorPages() was implemented by the Qt WebKit port, per
+ https://bugs.webkit.org/show_bug.cgi?id=31509#c0, but never implemented
+ on other ports. Per https://bugs.webkit.org/show_bug.cgi?id=31555, this
+ feature was never implemented on Mac.
+
+ * fast/history/back-forward-reset-after-error-handling-expected.txt: Removed test expectations.
+ * fast/history/back-forward-reset-after-error-handling.html: Removed test.
+ * platform/efl/TestExpectations: Remove reference to back-forward-reset-after-error-handling.
+ * platform/gtk/TestExpectations: Ditto.
+ * platform/ios-simulator/TestExpectations: Ditto.
+ * platform/mac/TestExpectations: Ditto.
+ * platform/win/TestExpectations: Ditto.
+
2016-08-05 Brent Fulgham <[email protected]>
validity assertion fails after removing a child of an <optgroup> element
Deleted: trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling-expected.txt (204190 => 204191)
--- trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling-expected.txt 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling-expected.txt 2016-08-05 20:27:33 UTC (rev 204191)
@@ -1,6 +0,0 @@
-SUCCESS
-
-============== Back Forward List ==============
-curr-> (file test):fast/history/back-forward-reset-after-error-handling.html **nav target**
- (file test):fast/history/non-existent.html **nav target**
-===============================================
Deleted: trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling.html (204190 => 204191)
--- trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling.html 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling.html 2016-08-05 20:27:33 UTC (rev 204191)
@@ -1,48 +0,0 @@
-<html>
- <script>
- // Pre-conditions
- // - Error page handling is supported on DRT.
-
- // Navigation steps:
- // 1- loads this page.
- // 2- loads a non-existent page (an error page is loaded).
- // 4- executes a back, forward and back navigations.
-
- // Expected results:
- // - forward-list should comprise the non-existent loaded page(2).
-
- var isOkToContinue = " "+
- "{ "+
- " var console = document.getElementById('console'); "+
- " if (console != null) "+
- " console.innerHTML = 'SUCCESS'; "+
- " else "+
- " console.innerHTML = 'FAIL'; "+
- "}";
-
- if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
- testRunner.handleErrorPages();
- testRunner.dumpBackForwardList();
- }
-
- function onPageShow(evt)
- {
- if (!evt.persisted) {
- // this is the first time the page has been loaded, then setup the
- // to-be-tested scenario.
- testRunner.queueLoad("./non-existent.html");
- testRunner.queueBackNavigation(1);
- testRunner.queueForwardNavigation(1);
- testRunner.queueBackNavigation(1);
- testRunner.queueNonLoadingScript("eval(\"" + isOkToContinue + "\")");
- }
- }
-
- window._onpageshow_ = onPageShow;
- </script>
- <body>
- <h1 id='console'/>
- </body>
-</html>
Modified: trunk/LayoutTests/platform/efl/TestExpectations (204190 => 204191)
--- trunk/LayoutTests/platform/efl/TestExpectations 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2016-08-05 20:27:33 UTC (rev 204191)
@@ -49,9 +49,6 @@
# EFL's LayoutTestController does not implement shadowPseudoId
media/video-volume-slider.html
-# Need to add functionality to DumpRenderTree to handle error pages
-fast/history/back-forward-reset-after-error-handling.html
-
# BUG: Captions support needed in the media engine (via GTK+)
media/media-captions.html
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (204190 => 204191)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-08-05 20:27:33 UTC (rev 204191)
@@ -1959,9 +1959,6 @@
webkit.org/b/53986 svg/text/caret-in-svg-text.xhtml [ Failure ]
-# Need to add functionality to DumpRenderTree to handle error pages
-Bug(GTK) fast/history/back-forward-reset-after-error-handling.html [ Failure ]
-
# Paged continuousMouseScrollBy() events are not supported in GTK.
Bug(GTK) fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html [ Failure Timeout ]
Bug(GTK) fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html [ Failure ]
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (204190 => 204191)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-08-05 20:27:33 UTC (rev 204191)
@@ -1856,7 +1856,6 @@
fast/frames/valid.html [ Failure ]
fast/gradients/background-clipped.html [ Failure ]
fast/hidpi/image-srcset-data-srcset.html [ Failure ]
-fast/history/back-forward-reset-after-error-handling.html [ Failure ]
fast/images/gif-large-checkerboard.html [ Failure ]
fast/images/gray-scale-jpeg-with-color-profile.html [ Failure ]
fast/images/icon-decoding.html [ Failure ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (204190 => 204191)
--- trunk/LayoutTests/platform/mac/TestExpectations 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2016-08-05 20:27:33 UTC (rev 204191)
@@ -53,9 +53,6 @@
accessibility/menu-list-sends-change-notification.html
accessibility/multiselect-list-reports-active-option.html
-# Need to add functionality to DumpRenderTree to handle error pages
-fast/history/back-forward-reset-after-error-handling.html
-
# Need to implement this in plugins code in WebKit
plugins/reloadplugins-and-pages.html
Modified: trunk/LayoutTests/platform/win/TestExpectations (204190 => 204191)
--- trunk/LayoutTests/platform/win/TestExpectations 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/platform/win/TestExpectations 2016-08-05 20:27:33 UTC (rev 204191)
@@ -200,9 +200,6 @@
fast/dom/Window/slow-unload-handler.html [ Skip ]
fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html [ Skip ]
-# Need to add functionality to DumpRenderTree to handle error pages (mac as well)
-fast/history/back-forward-reset-after-error-handling.html [ Skip ]
-
# These tests require touch support
fast/events/touch/ [ Skip ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
