Title: [204202] trunk/LayoutTests
- Revision
- 204202
- Author
- [email protected]
- Date
- 2016-08-05 16:57:52 -0700 (Fri, 05 Aug 2016)
Log Message
Disk cache tests produce many undefined value warnings
https://bugs.webkit.org/show_bug.cgi?id=160601
Reviewed by Daniel Bates.
* http/tests/cache/disk-cache/resources/generate-response.cgi: Cleaned up header
and parameter handling. Removed a couple unnecessary checks for $cgi->http.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (204201 => 204202)
--- trunk/LayoutTests/ChangeLog 2016-08-05 23:54:09 UTC (rev 204201)
+++ trunk/LayoutTests/ChangeLog 2016-08-05 23:57:52 UTC (rev 204202)
@@ -1,5 +1,15 @@
2016-08-05 Alexey Proskuryakov <[email protected]>
+ Disk cache tests produce many undefined value warnings
+ https://bugs.webkit.org/show_bug.cgi?id=160601
+
+ Reviewed by Daniel Bates.
+
+ * http/tests/cache/disk-cache/resources/generate-response.cgi: Cleaned up header
+ and parameter handling. Removed a couple unnecessary checks for $cgi->http.
+
+2016-08-05 Alexey Proskuryakov <[email protected]>
+
Work around broken <Files> directive in some Apache versions
https://bugs.webkit.org/show_bug.cgi?id=160610
Modified: trunk/LayoutTests/http/tests/cache/disk-cache/resources/generate-response.cgi (204201 => 204202)
--- trunk/LayoutTests/http/tests/cache/disk-cache/resources/generate-response.cgi 2016-08-05 23:54:09 UTC (rev 204201)
+++ trunk/LayoutTests/http/tests/cache/disk-cache/resources/generate-response.cgi 2016-08-05 23:57:52 UTC (rev 204202)
@@ -9,6 +9,8 @@
my $delay = $query->param('delay') || 0;
my $body = $query->param('body') || 0;
my $status = $query->param('Status') || 0;
+my $range = $query->param('Range') || '';
+my $location = $query->param('Location') || '';
if ($body eq "unique") {
$body = sprintf "%08X\n", rand(0xffffffff)
@@ -17,10 +19,11 @@
my $hasStatusCode = 0;
my $hasLocation = 0;
if ($status == 301 || $status == 302 || $status == 303 || $status == 307) {
- if ($query->param('Location') eq "unique-cacheable") {
+ if ($location eq "unique-cacheable") {
my $redirectBody = sprintf "%08X", rand(0xffffffff);
print "Status: ". $status . "\n";
- print "Location: generate-response.cgi?body=" . $redirectBody . "&Cache-control=max-age%3D1000&uniqueId=" . $query->param('uniqueId') . "\n";
+ my $uniqueId = $query->param('uniqueId');
+ print "Location: generate-response.cgi?body=" . $redirectBody . "&Cache-control=max-age%3D1000&uniqueId=" . $uniqueId . "\n";
$hasLocation = 1;
$hasStatusCode = 1;
}
@@ -27,7 +30,8 @@
}
my $hasExpiresHeader = 0;
-if ($query->http && $query->http("If-None-Match") eq "match") {
+my $ifNoneMatchHeader = $query->http("If-None-Match");
+if (defined $ifNoneMatchHeader and $ifNoneMatchHeader eq "match") {
print "Status: 304\n";
$hasStatusCode = 1;
if ($expiresInFutureIn304) {
@@ -36,7 +40,7 @@
}
}
-if ($query->http && $query->param("Range") =~ /bytes=(\d+)-(\d+)/) {
+if ($range =~ /bytes=(\d+)-(\d+)/) {
if ($1 < 6 && $2 < 6) {
print "Status: 206\n";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
