- Revision
- 204377
- Author
- [email protected]
- Date
- 2016-08-11 10:48:57 -0700 (Thu, 11 Aug 2016)
Log Message
Move dataset attribute from Element to HTMLElement / SVGElement
https://bugs.webkit.org/show_bug.cgi?id=160766
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Move dataset attribute from Element to HTMLElement / SVGElement as per
the specifications:
- https://html.spec.whatwg.org/multipage/dom.html#htmlelement
- https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement
Firefox and Chrome seem to have dataset on HTMLElement but not on
SVGElement (yet).
No new tests, rebaselined existing test.
* dom/Element.idl:
* html/HTMLElement.idl:
* svg/SVGElement.idl:
LayoutTests:
Rebaseline existing tests now that properties are in different order
when iterating.
* js/dom/dom-static-property-for-in-iteration-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (204376 => 204377)
--- trunk/LayoutTests/ChangeLog 2016-08-11 17:42:27 UTC (rev 204376)
+++ trunk/LayoutTests/ChangeLog 2016-08-11 17:48:57 UTC (rev 204377)
@@ -1,3 +1,15 @@
+2016-08-11 Chris Dumez <[email protected]>
+
+ Move dataset attribute from Element to HTMLElement / SVGElement
+ https://bugs.webkit.org/show_bug.cgi?id=160766
+
+ Reviewed by Alex Christensen.
+
+ Rebaseline existing tests now that properties are in different order
+ when iterating.
+
+ * js/dom/dom-static-property-for-in-iteration-expected.txt:
+
2016-08-11 Antoine Quint <[email protected]>
Unskip 2d.gradient.interpolate.colouralpha on macOS Sierra
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (204376 => 204377)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-11 17:42:27 UTC (rev 204376)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-11 17:48:57 UTC (rev 204377)
@@ -1,3 +1,14 @@
+2016-08-11 Chris Dumez <[email protected]>
+
+ Move dataset attribute from Element to HTMLElement / SVGElement
+ https://bugs.webkit.org/show_bug.cgi?id=160766
+
+ Reviewed by Alex Christensen.
+
+ Rebaseline W3C test now that one more check is passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
2016-08-11 Antoine Quint <[email protected]>
Test 2d.gradient.interpolate.colouralpha.html is broken on macOS Sierra
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (204376 => 204377)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-08-11 17:42:27 UTC (rev 204376)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-08-11 17:48:57 UTC (rev 204377)
@@ -966,7 +966,7 @@
PASS HTMLElement interface: attribute lang
PASS HTMLElement interface: attribute translate
PASS HTMLElement interface: attribute dir
-FAIL HTMLElement interface: attribute dataset assert_own_property: expected property "dataset" missing
+PASS HTMLElement interface: attribute dataset
PASS HTMLElement interface: attribute hidden
PASS HTMLElement interface: operation click()
PASS HTMLElement interface: attribute tabIndex
Modified: trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt (204376 => 204377)
--- trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt 2016-08-11 17:42:27 UTC (rev 204376)
+++ trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt 2016-08-11 17:48:57 UTC (rev 204377)
@@ -45,6 +45,7 @@
PASS a["contentEditable"] is inherit
PASS a["isContentEditable"] is false
PASS a["spellcheck"] is true
+PASS a["dataset"] is [object DOMStringMap]
PASS a["onabort"] is null
PASS a["onblur"] is null
PASS a["oncanplay"] is null
@@ -104,7 +105,7 @@
PASS a["style"] is [object CSSStyleDeclaration]
PASS a["id"] is foo
PASS a["offsetLeft"] is 8
-PASS a["offsetTop"] is 1599
+PASS a["offsetTop"] is 1614
PASS a["offsetWidth"] is 40
PASS a["offsetHeight"] is 18
PASS a["clientLeft"] is 0
@@ -120,7 +121,6 @@
PASS a["outerHTML"] is <a id="foo" href=""
PASS a["className"] is
PASS a["classList"] is
-PASS a["dataset"] is [object DOMStringMap]
PASS a["uiactions"] is
PASS a["webkitRegionOverset"] is undefined
PASS a["shadowRoot"] is null
Modified: trunk/Source/WebCore/ChangeLog (204376 => 204377)
--- trunk/Source/WebCore/ChangeLog 2016-08-11 17:42:27 UTC (rev 204376)
+++ trunk/Source/WebCore/ChangeLog 2016-08-11 17:48:57 UTC (rev 204377)
@@ -1,3 +1,24 @@
+2016-08-11 Chris Dumez <[email protected]>
+
+ Move dataset attribute from Element to HTMLElement / SVGElement
+ https://bugs.webkit.org/show_bug.cgi?id=160766
+
+ Reviewed by Alex Christensen.
+
+ Move dataset attribute from Element to HTMLElement / SVGElement as per
+ the specifications:
+ - https://html.spec.whatwg.org/multipage/dom.html#htmlelement
+ - https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement
+
+ Firefox and Chrome seem to have dataset on HTMLElement but not on
+ SVGElement (yet).
+
+ No new tests, rebaselined existing test.
+
+ * dom/Element.idl:
+ * html/HTMLElement.idl:
+ * svg/SVGElement.idl:
+
2016-08-11 Eric Carlson <[email protected]>
Unreviewed, update MediaRemoteSPI.h after r204082.
Modified: trunk/Source/WebCore/dom/Element.idl (204376 => 204377)
--- trunk/Source/WebCore/dom/Element.idl 2016-08-11 17:42:27 UTC (rev 204376)
+++ trunk/Source/WebCore/dom/Element.idl 2016-08-11 17:48:57 UTC (rev 204377)
@@ -111,10 +111,6 @@
[Reflect=class] attribute DOMString className;
[PutForwards=value] readonly attribute DOMTokenList classList;
-#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
- readonly attribute DOMStringMap dataset;
-#endif
-
[RaisesException] boolean matches(DOMString selectors);
[RaisesException] Element closest(DOMString selectors);
[ImplementedAs=matches, RaisesException] boolean webkitMatchesSelector(DOMString selectors);
Modified: trunk/Source/WebCore/html/HTMLElement.idl (204376 => 204377)
--- trunk/Source/WebCore/html/HTMLElement.idl 2016-08-11 17:42:27 UTC (rev 204376)
+++ trunk/Source/WebCore/html/HTMLElement.idl 2016-08-11 17:48:57 UTC (rev 204377)
@@ -54,6 +54,8 @@
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
void focus();
void blur();
+
+ readonly attribute DOMStringMap dataset;
#endif
};
Modified: trunk/Source/WebCore/svg/SVGElement.idl (204376 => 204377)
--- trunk/Source/WebCore/svg/SVGElement.idl 2016-08-11 17:42:27 UTC (rev 204376)
+++ trunk/Source/WebCore/svg/SVGElement.idl 2016-08-11 17:48:57 UTC (rev 204377)
@@ -40,6 +40,8 @@
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
void focus();
void blur();
+
+ readonly attribute DOMStringMap dataset;
#endif
};
