Title: [204398] trunk/Source/_javascript_Core
- Revision
- 204398
- Author
- [email protected]
- Date
- 2016-08-11 18:02:06 -0700 (Thu, 11 Aug 2016)
Log Message
Gardening: fix gcc builds after r204387.
Not reviewed.
Apparently, gcc is not sophisticated enough to realize that the end of the
function is unreachable, and is wrongly complaining about "control reaches end of
non-void function". I'm restoring the RELEASE_ASSERT_NOT_REACHED() and return
statement at the end of MarkedBlock::sweepHelper() to appease gcc.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweepHelper):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (204397 => 204398)
--- trunk/Source/_javascript_Core/ChangeLog 2016-08-12 00:35:21 UTC (rev 204397)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-08-12 01:02:06 UTC (rev 204398)
@@ -1,3 +1,17 @@
+2016-08-11 Mark Lam <[email protected]>
+
+ Gardening: fix gcc builds after r204387.
+
+ Not reviewed.
+
+ Apparently, gcc is not sophisticated enough to realize that the end of the
+ function is unreachable, and is wrongly complaining about "control reaches end of
+ non-void function". I'm restoring the RELEASE_ASSERT_NOT_REACHED() and return
+ statement at the end of MarkedBlock::sweepHelper() to appease gcc.
+
+ * heap/MarkedBlock.cpp:
+ (JSC::MarkedBlock::sweepHelper):
+
2016-08-11 Alex Christensen <[email protected]>
Use StringBuilder::appendLiteral when possible don't append result of makeString
Modified: trunk/Source/_javascript_Core/heap/MarkedBlock.cpp (204397 => 204398)
--- trunk/Source/_javascript_Core/heap/MarkedBlock.cpp 2016-08-12 00:35:21 UTC (rev 204397)
+++ trunk/Source/_javascript_Core/heap/MarkedBlock.cpp 2016-08-12 01:02:06 UTC (rev 204398)
@@ -163,6 +163,8 @@
? specializedSweep<Marked, SweepToFreeList, callDestructors>()
: specializedSweep<Marked, SweepOnly, callDestructors>();
}
+ RELEASE_ASSERT_NOT_REACHED();
+ return FreeList();
}
class SetNewlyAllocatedFunctor : public MarkedBlock::VoidFunctor {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
