Title: [204410] trunk/Source/WebCore
- Revision
- 204410
- Author
- [email protected]
- Date
- 2016-08-12 03:38:29 -0700 (Fri, 12 Aug 2016)
Log Message
[GStreamer] Performance problems with bigger video resolution in the webrtc media player
https://bugs.webkit.org/show_bug.cgi?id=153826
Reviewed by Alejandro G. Castro.
Keep the OpenWebRTC video renderer size synchronized with the Media element size.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
(WebCore::MediaPlayerPrivateGStreamerOwr::setSize):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (204409 => 204410)
--- trunk/Source/WebCore/ChangeLog 2016-08-12 10:35:28 UTC (rev 204409)
+++ trunk/Source/WebCore/ChangeLog 2016-08-12 10:38:29 UTC (rev 204410)
@@ -1,5 +1,18 @@
2016-08-12 Philippe Normand <[email protected]>
+ [GStreamer] Performance problems with bigger video resolution in the webrtc media player
+ https://bugs.webkit.org/show_bug.cgi?id=153826
+
+ Reviewed by Alejandro G. Castro.
+
+ Keep the OpenWebRTC video renderer size synchronized with the Media element size.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
+ (WebCore::MediaPlayerPrivateGStreamerOwr::setSize):
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h:
+
+2016-08-12 Philippe Normand <[email protected]>
+
[GStreamer][OWR] Video rendering fixes
https://bugs.webkit.org/show_bug.cgi?id=160764
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp (204409 => 204410)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp 2016-08-12 10:35:28 UTC (rev 204409)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp 2016-08-12 10:38:29 UTC (rev 204410)
@@ -347,13 +347,18 @@
#endif
m_videoRenderer = adoptGRef(owr_gst_video_renderer_new(sink));
- // FIXME: Remove hardcoded video dimensions when the rendering performance:
- // https://webkit.org/b/153826.
- g_object_set(m_videoRenderer.get(), "width", 640, "height", 480, nullptr);
-
return sink;
}
+void MediaPlayerPrivateGStreamerOwr::setSize(const IntSize& size)
+{
+ if (size == m_size)
+ return;
+
+ MediaPlayerPrivateGStreamerBase::setSize(size);
+ g_object_set(m_videoRenderer.get(), "width", size.width(), "height", size.height(), nullptr);
+}
+
} // namespace WebCore
#endif // ENABLE(VIDEO) && ENABLE(MEDIA_STREAM) && USE(GSTREAMER) && USE(OPENWEBRTC)
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h (204409 => 204410)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h 2016-08-12 10:35:28 UTC (rev 204409)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h 2016-08-12 10:38:29 UTC (rev 204410)
@@ -40,6 +40,8 @@
static void registerMediaEngine(MediaEngineRegistrar);
+ void setSize(const IntSize&) override;
+
private:
GstElement* createVideoSink() override;
GstElement* audioSink() const override { return m_audioSink.get(); }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
