[webkit-changes] [204470] trunk/Source/JavaScriptCore

Mon, 15 Aug 2016 11:48:34 -0700

Title: [204470] trunk/Source/_javascript_Core
Revision
204470
Author
[email protected]
Date
2016-08-15 11:48:31 -0700 (Mon, 15 Aug 2016)

Log Message

Reduce includes of Debugger.h
https://bugs.webkit.org/show_bug.cgi?id=160827

Reviewed by Mark Lam.

* API/JSTypedArray.cpp:
* bytecode/UnlinkedCodeBlock.h:
* bytecode/UnlinkedFunctionExecutable.cpp:
* bytecode/UnlinkedFunctionExecutable.h:
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
* dfg/DFGPlan.cpp:
* dfg/DFGSpeculativeJIT32_64.cpp:
* dfg/DFGSpeculativeJIT64.cpp:
* ftl/FTLJITCode.h:
* inspector/ScriptCallStackFactory.cpp:
* inspector/agents/InspectorDebuggerAgent.h:
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* jit/JITOperations.cpp:
* llint/LLIntOffsetsExtractor.cpp:
* parser/Nodes.cpp:
* parser/Parser.cpp:
* parser/Parser.h:
* runtime/Completion.cpp:
* runtime/Executable.cpp:
* runtime/Executable.h:
* runtime/FunctionConstructor.cpp:
* runtime/SamplingProfiler.cpp:
* runtime/SamplingProfiler.h:
* runtime/VMEntryScope.cpp:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/JSTypedArray.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/API/JSTypedArray.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/API/JSTypedArray.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -36,7 +36,6 @@
 #include "JSDataView.h"
 #include "JSGenericTypedArrayViewInlines.h"
 #include "JSTypedArrays.h"
-
 #include <wtf/RefPtr.h>
 
 using namespace JSC;

Modified: trunk/Source/_javascript_Core/ChangeLog (204469 => 204470)


--- trunk/Source/_javascript_Core/ChangeLog	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-08-15 18:48:31 UTC (rev 204470)
@@ -1,5 +1,39 @@
 2016-08-15  Joseph Pecoraro  <[email protected]>
 
+        Reduce includes of Debugger.h
+        https://bugs.webkit.org/show_bug.cgi?id=160827
+
+        Reviewed by Mark Lam.
+
+        * API/JSTypedArray.cpp:
+        * bytecode/UnlinkedCodeBlock.h:
+        * bytecode/UnlinkedFunctionExecutable.cpp:
+        * bytecode/UnlinkedFunctionExecutable.h:
+        * bytecompiler/BytecodeGenerator.h:
+        * bytecompiler/NodesCodegen.cpp:
+        * dfg/DFGPlan.cpp:
+        * dfg/DFGSpeculativeJIT32_64.cpp:
+        * dfg/DFGSpeculativeJIT64.cpp:
+        * ftl/FTLJITCode.h:
+        * inspector/ScriptCallStackFactory.cpp:
+        * inspector/agents/InspectorDebuggerAgent.h:
+        * jit/JITOpcodes.cpp:
+        * jit/JITOpcodes32_64.cpp:
+        * jit/JITOperations.cpp:
+        * llint/LLIntOffsetsExtractor.cpp:
+        * parser/Nodes.cpp:
+        * parser/Parser.cpp:
+        * parser/Parser.h:
+        * runtime/Completion.cpp:
+        * runtime/Executable.cpp:
+        * runtime/Executable.h:
+        * runtime/FunctionConstructor.cpp:
+        * runtime/SamplingProfiler.cpp:
+        * runtime/SamplingProfiler.h:
+        * runtime/VMEntryScope.cpp:
+
+2016-08-15  Joseph Pecoraro  <[email protected]>
+
         Remove unused includes of wtf headers
         https://bugs.webkit.org/show_bug.cgi?id=160839

Modified: trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h (204469 => 204470)


--- trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h	2016-08-15 18:48:31 UTC (rev 204470)
@@ -40,13 +40,11 @@
 #include "UnlinkedFunctionExecutable.h"
 #include "VariableEnvironment.h"
 #include "VirtualRegister.h"
-#include <wtf/RefCountedArray.h>
 #include <wtf/TriState.h>
 #include <wtf/Vector.h>
 
 namespace JSC {
 
-class Debugger;
 class FunctionMetadataNode;
 class FunctionExecutable;
 class JSScope;

Modified: trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -29,17 +29,14 @@
 #include "BytecodeGenerator.h"
 #include "ClassInfo.h"
 #include "CodeCache.h"
+#include "Debugger.h"
 #include "Executable.h"
 #include "ExecutableInfo.h"
 #include "FunctionOverrides.h"
 #include "JSCInlines.h"
-#include "JSString.h"
 #include "Parser.h"
 #include "SourceProvider.h"
 #include "Structure.h"
-#include "SymbolTable.h"
-#include "UnlinkedInstructionStream.h"
-#include <wtf/DataLog.h>
 
 namespace JSC {

Modified: trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.h (204469 => 204470)


--- trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.h	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.h	2016-08-15 18:48:31 UTC (rev 204470)
@@ -41,7 +41,6 @@
 #include "SpecialPointer.h"
 #include "VariableEnvironment.h"
 #include "VirtualRegister.h"
-#include <wtf/RefCountedArray.h>
 
 namespace JSC {

Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h (204469 => 204470)


--- trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h	2016-08-15 18:48:31 UTC (rev 204470)
@@ -32,28 +32,24 @@
 #define BytecodeGenerator_h
 
 #include "CodeBlock.h"
-#include <wtf/HashTraits.h>
 #include "Instruction.h"
+#include "Interpreter.h"
 #include "Label.h"
 #include "LabelScope.h"
-#include "Interpreter.h"
+#include "Nodes.h"
 #include "ParserError.h"
 #include "RegisterID.h"
 #include "SetForScope.h"
+#include "StaticPropertyAnalyzer.h"
 #include "SymbolTable.h"
-#include "Debugger.h"
-#include "Nodes.h"
-#include "StaticPropertyAnalyzer.h"
 #include "TemplateRegistryKey.h"
 #include "UnlinkedCodeBlock.h"
-
 #include <functional>
-
+#include <wtf/HashTraits.h>
 #include <wtf/PassRefPtr.h>
 #include <wtf/SegmentedVector.h>
 #include <wtf/Vector.h>
 
-
 namespace JSC {
 
     class Identifier;

Modified: trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -31,12 +31,10 @@
 #include "BuiltinNames.h"
 #include "BytecodeGenerator.h"
 #include "CallFrame.h"
-#include "Debugger.h"
 #include "JIT.h"
 #include "JSFunction.h"
 #include "JSGeneratorFunction.h"
 #include "JSGlobalObject.h"
-#include "JSONObject.h"
 #include "LabelScope.h"
 #include "Lexer.h"
 #include "JSCInlines.h"
@@ -48,7 +46,6 @@
 #include "StackAlignment.h"
 #include "TemplateRegistryKey.h"
 #include <wtf/Assertions.h>
-#include <wtf/RefCountedLeakCounter.h>
 #include <wtf/Threading.h>
 
 using namespace WTF;

Modified: trunk/Source/_javascript_Core/dfg/DFGPlan.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/dfg/DFGPlan.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/dfg/DFGPlan.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -74,7 +74,6 @@
 #include "DFGVarargsForwardingPhase.h"
 #include "DFGVirtualRegisterAllocationPhase.h"
 #include "DFGWatchpointCollectionPhase.h"
-#include "Debugger.h"
 #include "JSCInlines.h"
 #include "OperandsInlines.h"
 #include "ProfilerDatabase.h"

Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -35,7 +35,6 @@
 #include "DFGCallArrayAllocatorSlowPathGenerator.h"
 #include "DFGOperations.h"
 #include "DFGSlowPathGenerator.h"
-#include "Debugger.h"
 #include "DirectArguments.h"
 #include "GetterSetter.h"
 #include "JSEnvironmentRecord.h"

Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -34,7 +34,6 @@
 #include "DFGCallArrayAllocatorSlowPathGenerator.h"
 #include "DFGOperations.h"
 #include "DFGSlowPathGenerator.h"
-#include "Debugger.h"
 #include "DirectArguments.h"
 #include "GetterSetter.h"
 #include "JSCInlines.h"

Modified: trunk/Source/_javascript_Core/ftl/FTLJITCode.h (204469 => 204470)


--- trunk/Source/_javascript_Core/ftl/FTLJITCode.h	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/ftl/FTLJITCode.h	2016-08-15 18:48:31 UTC (rev 204470)
@@ -33,7 +33,6 @@
 #include "FTLLazySlowPath.h"
 #include "FTLOSRExit.h"
 #include "JITCode.h"
-#include <wtf/RefCountedArray.h>
 
 namespace JSC {

Modified: trunk/Source/_javascript_Core/inspector/ScriptCallStackFactory.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/inspector/ScriptCallStackFactory.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/inspector/ScriptCallStackFactory.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -43,7 +43,6 @@
 #include "ScriptCallStack.h"
 #include "ScriptValue.h"
 #include "StackVisitor.h"
-#include <wtf/RefCountedArray.h>
 #include <wtf/text/WTFString.h>
 
 using namespace JSC;

Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.h (204469 => 204470)


--- trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.h	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.h	2016-08-15 18:48:31 UTC (rev 204470)
@@ -41,7 +41,6 @@
 #include <wtf/HashMap.h>
 #include <wtf/Noncopyable.h>
 #include <wtf/Vector.h>
-#include <wtf/text/StringHash.h>
 
 namespace Inspector {

Modified: trunk/Source/_javascript_Core/jit/JITOpcodes.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/jit/JITOpcodes.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/jit/JITOpcodes.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -30,7 +30,6 @@
 
 #include "BasicBlockLocation.h"
 #include "CopiedSpaceInlines.h"
-#include "Debugger.h"
 #include "Exception.h"
 #include "Heap.h"
 #include "JITInlines.h"

Modified: trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -31,12 +31,10 @@
 #include "JIT.h"
 
 #include "CCallHelpers.h"
-#include "Debugger.h"
 #include "Exception.h"
 #include "JITInlines.h"
 #include "JSArray.h"
 #include "JSCell.h"
-#include "JSEnvironmentRecord.h"
 #include "JSFunction.h"
 #include "JSPropertyNameEnumerator.h"
 #include "LinkBuffer.h"

Modified: trunk/Source/_javascript_Core/jit/JITOperations.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/jit/JITOperations.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/jit/JITOperations.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -52,7 +52,6 @@
 #include "JSGlobalObjectFunctions.h"
 #include "JSLexicalEnvironment.h"
 #include "JSPropertyNameEnumerator.h"
-#include "JSWithScope.h"
 #include "ObjectConstructor.h"
 #include "PolymorphicAccess.h"
 #include "PropertyName.h"

Modified: trunk/Source/_javascript_Core/llint/LLIntOffsetsExtractor.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/llint/LLIntOffsetsExtractor.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/llint/LLIntOffsetsExtractor.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -28,7 +28,6 @@
 #include "ArrayProfile.h"
 #include "CodeBlock.h"
 #include "CommonSlowPaths.h"
-#include "Debugger.h"
 #include "DirectArguments.h"
 #include "Exception.h"
 #include "Executable.h"

Modified: trunk/Source/_javascript_Core/parser/Nodes.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/parser/Nodes.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/parser/Nodes.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -27,25 +27,13 @@
 #include "Nodes.h"
 #include "NodeConstructors.h"
 
-#include "CallFrame.h"
-#include "Debugger.h"
-#include "JIT.h"
-#include "JSFunction.h"
-#include "JSGlobalObject.h"
-#include "LabelScope.h"
-#include "Lexer.h"
 #include "JSCInlines.h"
-#include "Parser.h"
-#include "PropertyNameArray.h"
-#include "RegExpObject.h"
 #include <wtf/Assertions.h>
-#include <wtf/Threading.h>
 
 using namespace WTF;
 
 namespace JSC {
 
-
 // ------------------------------ StatementNode --------------------------------
 
 void StatementNode::setLoc(unsigned firstLine, unsigned lastLine, int startOffset, int lineStartOffset)

Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/parser/Parser.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -24,18 +24,12 @@
 #include "Parser.h"
 
 #include "ASTBuilder.h"
-#include "CodeBlock.h"
-#include "Debugger.h"
-#include "JSCJSValueInlines.h"
-#include "Lexer.h"
 #include "JSCInlines.h"
 #include "SetForScope.h"
 #include "SourceProvider.h"
 #include "VM.h"
 #include <utility>
-#include <wtf/HashFunctions.h>
 #include <wtf/StringPrintStream.h>
-#include <wtf/WTFThreadData.h>
 
 
 #define updateErrorMessage(shouldPrintToken, ...) do {\

Modified: trunk/Source/_javascript_Core/parser/Parser.h (204469 => 204470)


--- trunk/Source/_javascript_Core/parser/Parser.h	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/parser/Parser.h	2016-08-15 18:48:31 UTC (rev 204470)
@@ -23,10 +23,8 @@
 #ifndef Parser_h
 #define Parser_h
 
-#include "Debugger.h"
 #include "ExceptionHelpers.h"
 #include "Executable.h"
-#include "JSGlobalObject.h"
 #include "Lexer.h"
 #include "ModuleScopeData.h"
 #include "Nodes.h"

Modified: trunk/Source/_javascript_Core/runtime/Completion.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/runtime/Completion.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/runtime/Completion.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -25,7 +25,6 @@
 
 #include "CallFrame.h"
 #include "CodeProfiling.h"
-#include "Debugger.h"
 #include "Exception.h"
 #include "IdentifierInlines.h"
 #include "Interpreter.h"

Modified: trunk/Source/_javascript_Core/runtime/Executable.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/runtime/Executable.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/runtime/Executable.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -28,18 +28,15 @@
 
 #include "BatchedTransitionOptimizer.h"
 #include "CodeBlock.h"
-#include "DFGDriver.h"
+#include "Debugger.h"
 #include "JIT.h"
 #include "JSCInlines.h"
 #include "JSWASMModule.h"
 #include "LLIntEntrypoint.h"
 #include "Parser.h"
-#include "ProfilerDatabase.h"
 #include "TypeProfiler.h"
 #include "VMInlines.h"
 #include <wtf/CommaPrinter.h>
-#include <wtf/Vector.h>
-#include <wtf/text/StringBuilder.h>
 
 namespace JSC {

Modified: trunk/Source/_javascript_Core/runtime/Executable.h (204469 => 204470)


--- trunk/Source/_javascript_Core/runtime/Executable.h	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/runtime/Executable.h	2016-08-15 18:48:31 UTC (rev 204470)
@@ -44,7 +44,6 @@
 namespace JSC {
 
 class CodeBlock;
-class Debugger;
 class EvalCodeBlock;
 class FunctionCodeBlock;
 class JSScope;

Modified: trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -21,16 +21,11 @@
 #include "config.h"
 #include "FunctionConstructor.h"
 
-#include "Debugger.h"
 #include "ExceptionHelpers.h"
 #include "FunctionPrototype.h"
 #include "JSFunction.h"
 #include "JSGlobalObject.h"
-#include "JSString.h"
-#include "Lexer.h"
-#include "Nodes.h"
 #include "JSCInlines.h"
-#include "Parser.h"
 #include <wtf/text/StringBuilder.h>
 
 namespace JSC {

Modified: trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -30,7 +30,6 @@
 
 #include "CallFrame.h"
 #include "CodeBlock.h"
-#include "Debugger.h"
 #include "Executable.h"
 #include "HeapInlines.h"
 #include "HeapIterationScope.h"
@@ -46,7 +45,6 @@
 #include "SlotVisitorInlines.h"
 #include "StructureInlines.h"
 #include "VM.h"
-#include "VMEntryScope.h"
 #include <wtf/HashSet.h>
 #include <wtf/RandomNumber.h>
 #include <wtf/RefPtr.h>

Modified: trunk/Source/_javascript_Core/runtime/SamplingProfiler.h (204469 => 204470)


--- trunk/Source/_javascript_Core/runtime/SamplingProfiler.h	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/runtime/SamplingProfiler.h	2016-08-15 18:48:31 UTC (rev 204470)
@@ -36,7 +36,6 @@
 #include <wtf/Lock.h>
 #include <wtf/Stopwatch.h>
 #include <wtf/Vector.h>
-#include <wtf/WorkQueue.h>
 
 namespace JSC {

Modified: trunk/Source/_javascript_Core/runtime/VMEntryScope.cpp (204469 => 204470)


--- trunk/Source/_javascript_Core/runtime/VMEntryScope.cpp	2016-08-15 18:16:36 UTC (rev 204469)
+++ trunk/Source/_javascript_Core/runtime/VMEntryScope.cpp	2016-08-15 18:48:31 UTC (rev 204470)
@@ -26,7 +26,6 @@
 #include "config.h"
 #include "VMEntryScope.h"
 
-#include "Debugger.h"
 #include "Options.h"
 #include "SamplingProfiler.h"
 #include "VM.h"

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to