Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (204506 => 204507)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-08-16 16:52:45 UTC (rev 204507)
@@ -1,3 +1,44 @@
+2016-08-16 Joseph Pecoraro <[email protected]>
+
+ Modernize model objects simple getters
+ https://bugs.webkit.org/show_bug.cgi?id=160863
+
+ Reviewed by Timothy Hatcher.
+
+ Simplify the style of many Model objects with basic accessors.
+ We reduce them to a single line and group them together so
+ that they can be more easily read at a glance.
+
+ * UserInterface/Models/AnalyzerMessage.js:
+ * UserInterface/Models/ApplicationCacheFrame.js:
+ * UserInterface/Models/ApplicationCacheManifest.js:
+ * UserInterface/Models/BreakpointAction.js:
+ * UserInterface/Models/CSSMedia.js:
+ * UserInterface/Models/CSSSelector.js:
+ * UserInterface/Models/CollectionEntry.js:
+ * UserInterface/Models/CollectionEntryPreview.js:
+ * UserInterface/Models/DOMStorageObject.js:
+ * UserInterface/Models/DatabaseObject.js:
+ * UserInterface/Models/DatabaseTableObject.js:
+ * UserInterface/Models/ExecutionContext.js:
+ * UserInterface/Models/GarbageCollection.js:
+ * UserInterface/Models/IndexedDatabase.js:
+ * UserInterface/Models/IndexedDatabaseObjectStore.js:
+ * UserInterface/Models/IndexedDatabaseObjectStoreIndex.js:
+ * UserInterface/Models/ObjectPreview.js:
+ * UserInterface/Models/ProbeSet.js:
+ * UserInterface/Models/PropertyDescriptor.js:
+ * UserInterface/Models/PropertyPath.js:
+ * UserInterface/Models/PropertyPreview.js:
+ * UserInterface/Models/SourceCodePosition.js:
+ * UserInterface/Models/SourceCodeSearchMatchObject.js:
+ * UserInterface/Models/SourceCodeTimeline.js:
+ * UserInterface/Models/StructureDescription.js:
+ * UserInterface/Models/TextRange.js:
+ * UserInterface/Models/Timeline.js:
+ * UserInterface/Models/TimelineRecording.js:
+ * UserInterface/Models/TypeDescription.js:
+
2016-08-15 Devin Rousso <[email protected]>
Web Inspector: Large class lists are not easily discoverable with "Classes" quick-toggle
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/AnalyzerMessage.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/AnalyzerMessage.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/AnalyzerMessage.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -39,23 +39,8 @@
// Public
- get sourceCodeLocation()
- {
- return this._sourceCodeLocation;
- }
-
- get sourceCode()
- {
- return this._sourceCodeLocation.sourceCode;
- }
-
- get text()
- {
- return this._text;
- }
-
- get ruleIdentifier()
- {
- return this._ruleIdentifier;
- }
+ get sourceCodeLocation() { return this._sourceCodeLocation; }
+ get sourceCode() { return this._sourceCodeLocation.sourceCode; }
+ get text() { return this._text; }
+ get ruleIdentifier() { return this._ruleIdentifier; }
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ApplicationCacheFrame.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/ApplicationCacheFrame.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ApplicationCacheFrame.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -39,26 +39,11 @@
// Public
- get frame()
- {
- return this._frame;
- }
+ get frame() { return this._frame; }
+ get manifest() { return this._manifest; }
+ get status() { return this._status; }
+ set status(status) { this._status = status; }
- get manifest()
- {
- return this._manifest;
- }
-
- get status()
- {
- return this._status;
- }
-
- set status(status)
- {
- this._status = status;
- }
-
saveIdentityToCookie(cookie)
{
cookie[WebInspector.ApplicationCacheFrame.FrameURLCookieKey] = this.frame.url;
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ApplicationCacheManifest.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/ApplicationCacheManifest.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ApplicationCacheManifest.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -32,8 +32,7 @@
this._manifestURL = manifestURL;
}
- get manifestURL()
- {
- return this._manifestURL;
- }
+ // Public
+
+ get manifestURL() { return this._manifestURL; }
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/BreakpointAction.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/BreakpointAction.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/BreakpointAction.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -49,21 +49,10 @@
// Public
- get breakpoint()
- {
- return this._breakpoint;
- }
+ get breakpoint() { return this._breakpoint; }
+ get id() { return this._id; }
+ get type() { return this._type; }
- get id()
- {
- return this._id;
- }
-
- get type()
- {
- return this._type;
- }
-
get data()
{
return this._data;
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSMedia.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSMedia.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSMedia.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -38,20 +38,9 @@
// Public
- get type()
- {
- return this._type;
- }
-
- get text()
- {
- return this._text;
- }
-
- get sourceCodeLocation()
- {
- return this._sourceCodeLocation;
- }
+ get type() { return this._type; }
+ get text() { return this._text; }
+ get sourceCodeLocation() { return this._sourceCodeLocation; }
};
WebInspector.CSSMedia.Type = {
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSSelector.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSSelector.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSSelector.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -38,21 +38,10 @@
// Public
- get text()
- {
- return this._text;
- }
+ get text() { return this._text; }
+ get specificity() { return this._specificity; }
+ get dynamic() { return this._dynamic; }
- get specificity()
- {
- return this._specificity;
- }
-
- get dynamic()
- {
- return this._dynamic;
- }
-
isGreaterThan(selector)
{
if (!selector || !selector.specificity)
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CollectionEntry.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/CollectionEntry.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CollectionEntry.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -51,13 +51,6 @@
// Public
- get key()
- {
- return this._key;
- }
-
- get value()
- {
- return this._value;
- }
+ get key() { return this._key; }
+ get value() { return this._value; }
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CollectionEntryPreview.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/CollectionEntryPreview.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CollectionEntryPreview.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -51,13 +51,6 @@
// Public
- get keyPreview()
- {
- return this._key;
- }
-
- get valuePreview()
- {
- return this._value;
- }
+ get keyPreview() { return this._key; }
+ get valuePreview() { return this._value; }
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DOMStorageObject.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/DOMStorageObject.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DOMStorageObject.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -37,21 +37,10 @@
// Public
- get id()
- {
- return this._id;
- }
+ get id() { return this._id; }
+ get host() { return this._host; }
+ get entries() { return this._entries; }
- get host()
- {
- return this._host;
- }
-
- get entries()
- {
- return this._entries;
- }
-
saveIdentityToCookie(cookie)
{
cookie[WebInspector.DOMStorageObject.HostCookieKey] = this.host;
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DatabaseObject.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/DatabaseObject.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DatabaseObject.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -37,26 +37,11 @@
// Public
- get id()
- {
- return this._id;
- }
+ get id() { return this._id; }
+ get host() { return this._host; }
+ get name() { return this._name; }
+ get version() { return this._version; }
- get host()
- {
- return this._host;
- }
-
- get name()
- {
- return this._name;
- }
-
- get version()
- {
- return this._version;
- }
-
saveIdentityToCookie(cookie)
{
cookie[WebInspector.DatabaseObject.HostCookieKey] = this.host;
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DatabaseTableObject.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/DatabaseTableObject.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DatabaseTableObject.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -37,16 +37,9 @@
// Public
- get name()
- {
- return this._name;
- }
+ get name() { return this._name; }
+ get database() { return this._database; }
- get database()
- {
- return this._database;
- }
-
saveIdentityToCookie(cookie)
{
cookie[WebInspector.DatabaseTableObject.NameCookieKey] = this.name;
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ExecutionContext.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/ExecutionContext.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ExecutionContext.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -40,23 +40,8 @@
// Public
- get id()
- {
- return this._id;
- }
-
- get name()
- {
- return this._name;
- }
-
- get isPageContext()
- {
- return this._isPageContext;
- }
-
- get frame()
- {
- return this._frame;
- }
+ get id() { return this._id; }
+ get name() { return this._name; }
+ get isPageContext() { return this._isPageContext; }
+ get frame() { return this._frame; }
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/GarbageCollection.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/GarbageCollection.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/GarbageCollection.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -49,21 +49,10 @@
// Public
- get type()
- {
- return this._type;
- }
+ get type() { return this._type; }
+ get startTime() { return this._startTime; }
+ get endTime() { return this._endTime; }
- get startTime()
- {
- return this._startTime;
- }
-
- get endTime()
- {
- return this._endTime;
- }
-
get duration()
{
return this._endTime - this._startTime;
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/IndexedDatabase.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/IndexedDatabase.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/IndexedDatabase.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -41,31 +41,12 @@
// Public
- get name()
- {
- return this._name;
- }
+ get name() { return this._name; }
+ get securityOrigin() { return this._securityOrigin; }
+ get host() { return this._host; }
+ get version() { return this._version; }
+ get objectStores() { return this._objectStores; }
- get securityOrigin()
- {
- return this._securityOrigin;
- }
-
- get host()
- {
- return this._host;
- }
-
- get version()
- {
- return this._version;
- }
-
- get objectStores()
- {
- return this._objectStores;
- }
-
saveIdentityToCookie(cookie)
{
cookie[WebInspector.IndexedDatabase.NameCookieKey] = this._name;
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/IndexedDatabaseObjectStore.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/IndexedDatabaseObjectStore.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/IndexedDatabaseObjectStore.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -41,31 +41,12 @@
// Public
- get name()
- {
- return this._name;
- }
+ get name() { return this._name; }
+ get keyPath() { return this._keyPath; }
+ get autoIncrement() { return this._autoIncrement; }
+ get parentDatabase() { return this._parentDatabase; }
+ get indexes() { return this._indexes; }
- get keyPath()
- {
- return this._keyPath;
- }
-
- get autoIncrement()
- {
- return this._autoIncrement;
- }
-
- get parentDatabase()
- {
- return this._parentDatabase;
- }
-
- get indexes()
- {
- return this._indexes;
- }
-
saveIdentityToCookie(cookie)
{
cookie[WebInspector.IndexedDatabaseObjectStore.NameCookieKey] = this._name;
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/IndexedDatabaseObjectStoreIndex.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/IndexedDatabaseObjectStoreIndex.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/IndexedDatabaseObjectStoreIndex.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -38,31 +38,12 @@
// Public
- get name()
- {
- return this._name;
- }
+ get name() { return this._name; }
+ get keyPath() { return this._keyPath; }
+ get unique() { return this._unique; }
+ get multiEntry() { return this._multiEntry; }
+ get parentObjectStore() { return this._parentObjectStore; }
- get keyPath()
- {
- return this._keyPath;
- }
-
- get unique()
- {
- return this._unique;
- }
-
- get multiEntry()
- {
- return this._multiEntry;
- }
-
- get parentObjectStore()
- {
- return this._parentObjectStore;
- }
-
saveIdentityToCookie(cookie)
{
cookie[WebInspector.IndexedDatabaseObjectStoreIndex.NameCookieKey] = this._name;
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ObjectPreview.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/ObjectPreview.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ObjectPreview.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -70,46 +70,15 @@
// Public
- get type()
- {
- return this._type;
- }
+ get type() { return this._type; }
+ get subtype() { return this._subtype; }
+ get description() { return this._description; }
+ get lossless() { return this._lossless; }
+ get overflow() { return this._overflow; }
+ get propertyPreviews() { return this._properties; }
+ get collectionEntryPreviews() { return this._entries; }
+ get size() { return this._size; }
- get subtype()
- {
- return this._subtype;
- }
-
- get description()
- {
- return this._description;
- }
-
- get lossless()
- {
- return this._lossless;
- }
-
- get overflow()
- {
- return this._overflow;
- }
-
- get propertyPreviews()
- {
- return this._properties;
- }
-
- get collectionEntryPreviews()
- {
- return this._entries;
- }
-
- get size()
- {
- return this._size;
- }
-
hasSize()
{
return this._size !== undefined && (this._subtype === "array" || this._subtype === "set" || this._subtype === "map" || this._subtype === "weakmap" || this._subtype === "weakset");
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ProbeSet.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/ProbeSet.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ProbeSet.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -47,21 +47,10 @@
// Public
- get breakpoint()
- {
- return this._breakpoint;
- }
+ get breakpoint() { return this._breakpoint; }
+ get probes() { return this._probes.slice(); }
+ get dataTable() { return this._dataTable; }
- get probes()
- {
- return this._probes.slice();
- }
-
- get dataTable()
- {
- return this._dataTable;
- }
-
clear()
{
this._breakpoint.clearActions(WebInspector.BreakpointAction.Type.Probe);
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/PropertyDescriptor.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/PropertyDescriptor.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/PropertyDescriptor.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -79,66 +79,19 @@
// Public
- get name()
- {
- return this._name;
- }
+ get name() { return this._name; }
+ get value() { return this._value; }
+ get get() { return this._get; }
+ get set() { return this._set; }
+ get writable() { return this._writable; }
+ get configurable() { return this._configurable; }
+ get enumerable() { return this._enumerable; }
+ get symbol() { return this._symbol; }
+ get isOwnProperty() { return this._own; }
+ get wasThrown() { return this._wasThrown; }
+ get nativeGetter() { return this._nativeGetterValue; }
+ get isInternalProperty() { return this._internal; }
- get value()
- {
- return this._value;
- }
-
- get get()
- {
- return this._get;
- }
-
- get set()
- {
- return this._set;
- }
-
- get writable()
- {
- return this._writable;
- }
-
- get configurable()
- {
- return this._configurable;
- }
-
- get enumerable()
- {
- return this._enumerable;
- }
-
- get symbol()
- {
- return this._symbol;
- }
-
- get isOwnProperty()
- {
- return this._own;
- }
-
- get wasThrown()
- {
- return this._wasThrown;
- }
-
- get nativeGetter()
- {
- return this._nativeGetterValue;
- }
-
- get isInternalProperty()
- {
- return this._internal;
- }
-
hasValue()
{
return this._hasValue;
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/PropertyPath.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/PropertyPath.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/PropertyPath.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -54,21 +54,11 @@
// Public
- get object()
- {
- return this._object;
- }
+ get object() { return this._object; }
+ get parent() { return this._parent; }
+ get isPrototype() { return this._isPrototype; }
+ get pathComponent() { return this._pathComponent; }
- get parent()
- {
- return this._parent;
- }
-
- get isPrototype()
- {
- return this._isPrototype;
- }
-
get rootObject()
{
return this._parent ? this._parent.rootObject : this._object;
@@ -91,11 +81,6 @@
return p.object;
}
- get pathComponent()
- {
- return this._pathComponent;
- }
-
get fullPath()
{
var components = [];
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/PropertyPreview.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/PropertyPreview.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/PropertyPreview.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -55,33 +55,10 @@
// Public
- get name()
- {
- return this._name;
- }
-
- get type()
- {
- return this._type;
- }
-
- get subtype()
- {
- return this._subtype;
- }
-
- get value()
- {
- return this._value;
- }
-
- get valuePreview()
- {
- return this._valuePreview;
- }
-
- get internal()
- {
- return this._internal;
- }
+ get name() { return this._name; }
+ get type() { return this._type; }
+ get subtype() { return this._subtype; }
+ get value() { return this._value; }
+ get valuePreview() { return this._valuePreview; }
+ get internal() { return this._internal; }
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodePosition.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodePosition.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodePosition.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -35,13 +35,6 @@
// Public
- get lineNumber()
- {
- return this._lineNumber;
- }
-
- get columnNumber()
- {
- return this._columnNumber;
- }
+ get lineNumber() { return this._lineNumber; }
+ get columnNumber() { return this._columnNumber; }
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeSearchMatchObject.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeSearchMatchObject.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeSearchMatchObject.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -39,31 +39,16 @@
// Public
- get sourceCode()
- {
- return this._sourceCode;
- }
+ get sourceCode() { return this._sourceCode; }
+ get title() { return this._lineText; }
+ get searchTerm() { return this._searchTerm; }
+ get sourceCodeTextRange() { return this._sourceCodeTextRange; }
- get title()
- {
- return this._lineText;
- }
-
get className()
{
return WebInspector.SourceCodeSearchMatchObject.SourceCodeMatchIconStyleClassName;
}
- get searchTerm()
- {
- return this._searchTerm;
- }
-
- get sourceCodeTextRange()
- {
- return this._sourceCodeTextRange;
- }
-
saveIdentityToCookie(cookie)
{
if (this._sourceCode.url)
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeTimeline.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeTimeline.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeTimeline.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -41,26 +41,11 @@
// Public
- get sourceCode()
- {
- return this._sourceCode;
- }
+ get sourceCode() { return this._sourceCode; }
+ get sourceCodeLocation() { return this._sourceCodeLocation; }
+ get recordType() { return this._recordType; }
+ get recordEventType() { return this._recordEventType; }
- get sourceCodeLocation()
- {
- return this._sourceCodeLocation;
- }
-
- get recordType()
- {
- return this._recordType;
- }
-
- get recordEventType()
- {
- return this._recordEventType;
- }
-
saveIdentityToCookie(cookie)
{
cookie[WebInspector.SourceCodeTimeline.SourceCodeURLCookieKey] = this._sourceCode.url ? this._sourceCode.url.hash : null;
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/StructureDescription.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/StructureDescription.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/StructureDescription.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -54,28 +54,9 @@
// Public
- get fields()
- {
- return this._fields;
- }
-
- get optionalFields()
- {
- return this._optionalFields;
- }
-
- get constructorName()
- {
- return this._constructorName;
- }
-
- get prototypeStructure()
- {
- return this._prototypeStructure;
- }
-
- get imprecise()
- {
- return this._imprecise;
- }
+ get fields() { return this._fields; }
+ get optionalFields() { return this._optionalFields; }
+ get constructorName() { return this._constructorName; }
+ get prototypeStructure() { return this._prototypeStructure; }
+ get imprecise() { return this._imprecise; }
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/TextRange.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/TextRange.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/TextRange.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -55,36 +55,13 @@
// Public
- get startLine()
- {
- return this._startLine;
- }
+ get startLine() { return this._startLine; }
+ get startColumn() { return this._startColumn; }
+ get endLine() { return this._endLine; }
+ get endColumn() { return this._endColumn; }
+ get startOffset() { return this._startOffset; }
+ get endOffset() { return this._endOffset; }
- get startColumn()
- {
- return this._startColumn;
- }
-
- get endLine()
- {
- return this._endLine;
- }
-
- get endColumn()
- {
- return this._endColumn;
- }
-
- get startOffset()
- {
- return this._startOffset;
- }
-
- get endOffset()
- {
- return this._endOffset;
- }
-
startPosition()
{
return new WebInspector.SourceCodePosition(this._startLine, this._startColumn);
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Timeline.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/Timeline.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Timeline.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -49,26 +49,11 @@
// Public
- get type()
- {
- return this._type;
- }
+ get type() { return this._type; }
+ get startTime() { return this._startTime; }
+ get endTime() { return this._endTime; }
+ get records() { return this._records; }
- get startTime()
- {
- return this._startTime;
- }
-
- get endTime()
- {
- return this._endTime;
- }
-
- get records()
- {
- return this._records;
- }
-
reset(suppressEvents)
{
this._records = [];
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -61,61 +61,19 @@
// Public
- get displayName()
- {
- return this._displayName;
- }
+ get displayName() { return this._displayName; }
+ get identifier() { return this._identifier; }
+ get timelines() { return this._timelines; }
+ get instruments() { return this._instruments; }
+ get readonly() { return this._readonly; }
+ get startTime() { return this._startTime; }
+ get endTime() { return this._endTime; }
- get identifier()
- {
- return this._identifier;
- }
+ get topDownCallingContextTree() { return this._topDownCallingContextTree; }
+ get bottomUpCallingContextTree() { return this._bottomUpCallingContextTree; }
+ get topFunctionsTopDownCallingContextTree() { return this._topFunctionsTopDownCallingContextTree; }
+ get topFunctionsBottomUpCallingContextTree() { return this._topFunctionsBottomUpCallingContextTree; }
- get timelines()
- {
- return this._timelines;
- }
-
- get instruments()
- {
- return this._instruments;
- }
-
- get readonly()
- {
- return this._readonly;
- }
-
- get startTime()
- {
- return this._startTime;
- }
-
- get endTime()
- {
- return this._endTime;
- }
-
- get topDownCallingContextTree()
- {
- return this._topDownCallingContextTree;
- }
-
- get bottomUpCallingContextTree()
- {
- return this._bottomUpCallingContextTree;
- }
-
- get topFunctionsTopDownCallingContextTree()
- {
- return this._topFunctionsTopDownCallingContextTree;
- }
-
- get topFunctionsBottomUpCallingContextTree()
- {
- return this._topFunctionsBottomUpCallingContextTree;
- }
-
start(initiatedByBackend)
{
console.assert(!this._capturing, "Attempted to start an already started session.");
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/TypeDescription.js (204506 => 204507)
--- trunk/Source/WebInspectorUI/UserInterface/Models/TypeDescription.js 2016-08-16 16:27:48 UTC (rev 204506)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/TypeDescription.js 2016-08-16 16:52:45 UTC (rev 204507)
@@ -58,28 +58,9 @@
// Public
- get leastCommonAncestor()
- {
- return this._leastCommonAncestor;
- }
-
- get typeSet()
- {
- return this._typeSet;
- }
-
- get structures()
- {
- return this._structures;
- }
-
- get valid()
- {
- return this._valid;
- }
-
- get truncated()
- {
- return this._truncated;
- }
+ get leastCommonAncestor() { return this._leastCommonAncestor; }
+ get typeSet() { return this._typeSet; }
+ get structures() { return this._structures; }
+ get valid() { return this._valid; }
+ get truncated() { return this._truncated; }
};
