Title: [204518] trunk/Source/WebInspectorUI
- Revision
- 204518
- Author
- [email protected]
- Date
- 2016-08-16 12:25:57 -0700 (Tue, 16 Aug 2016)
Log Message
Web Inspector: Data grid has a double left border when the first column is hidden
https://bugs.webkit.org/show_bug.cgi?id=160723
<rdar://problem/27778081>
Reviewed by Timothy Hatcher.
This patch exploits the fact hiding columns that aren't first in DataGrid don't create double
borders.
* UserInterface/Views/DataGrid.css:
(.data-grid table.header,):
(.data-grid :matches(th, td):first-child):
(@media (-webkit-min-device-pixel-ratio: 2)):
* UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (204517 => 204518)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-08-16 19:08:58 UTC (rev 204517)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-08-16 19:25:57 UTC (rev 204518)
@@ -1,3 +1,21 @@
+2016-08-16 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: Data grid has a double left border when the first column is hidden
+ https://bugs.webkit.org/show_bug.cgi?id=160723
+ <rdar://problem/27778081>
+
+ Reviewed by Timothy Hatcher.
+
+ This patch exploits the fact hiding columns that aren't first in DataGrid don't create double
+ borders.
+
+ * UserInterface/Views/DataGrid.css:
+ (.data-grid table.header,):
+ (.data-grid :matches(th, td):first-child):
+ (@media (-webkit-min-device-pixel-ratio: 2)):
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ (WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):
+
2016-08-16 Joseph Pecoraro <[email protected]>
Web Inspector: Do not request Scope Chain lists if section is collapsed (mainly Global Variables)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css (204517 => 204518)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css 2016-08-16 19:08:58 UTC (rev 204517)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css 2016-08-16 19:25:57 UTC (rev 204518)
@@ -331,3 +331,26 @@
z-index: var(--z-index-resizer);
transform: translateX(-2.5px);
}
+
+.data-grid table.header,
+.data-grid table.data {
+ /* Hide right border from first hidden columns. */
+ width: calc(100% + 1px);
+ margin-left: -1px;
+}
+
+.data-grid :matches(th, td):first-child {
+ border-left: 1px solid transparent;
+}
+
+@media (-webkit-min-device-pixel-ratio: 2) {
+ .data-grid table.header,
+ .data-grid table.data {
+ width: calc(100% + 0.5px);
+ margin-left: -0.5px;
+ }
+
+ .data-grid :matches(th, td):first-child {
+ border-width: 0.5px;
+ }
+}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
