Title: [204562] trunk/Source/WebInspectorUI
- Revision
- 204562
- Author
- [email protected]
- Date
- 2016-08-17 10:48:59 -0700 (Wed, 17 Aug 2016)
Log Message
Web Inspector: rapid updates to status icons in Visual Styles sidebar causes flicker
https://bugs.webkit.org/show_bug.cgi?id=160887
Patch by Devin Rousso <[email protected]> on 2016-08-17
Reviewed by Timothy Hatcher.
* UserInterface/Views/VisualStyleBasicInput.js:
(WebInspector.VisualStyleBasicInput):
* UserInterface/Views/VisualStyleColorPicker.js:
(WebInspector.VisualStyleColorPicker):
* UserInterface/Views/VisualStyleNumberInputBox.js:
(WebInspector.VisualStyleNumberInputBox):
(WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown):
* UserInterface/Views/VisualStylePropertyNameInput.js:
(WebInspector.VisualStylePropertyNameInput):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (204561 => 204562)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-08-17 17:12:42 UTC (rev 204561)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-08-17 17:48:59 UTC (rev 204562)
@@ -1,3 +1,23 @@
+2016-08-17 Devin Rousso <[email protected]>
+
+ Web Inspector: rapid updates to status icons in Visual Styles sidebar causes flicker
+ https://bugs.webkit.org/show_bug.cgi?id=160887
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/VisualStyleBasicInput.js:
+ (WebInspector.VisualStyleBasicInput):
+
+ * UserInterface/Views/VisualStyleColorPicker.js:
+ (WebInspector.VisualStyleColorPicker):
+
+ * UserInterface/Views/VisualStyleNumberInputBox.js:
+ (WebInspector.VisualStyleNumberInputBox):
+ (WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown):
+
+ * UserInterface/Views/VisualStylePropertyNameInput.js:
+ (WebInspector.VisualStylePropertyNameInput):
+
2016-08-16 Nikita Vasilyev <[email protected]>
Web Inspector: DOM nodes shift when hovering over them in Console
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleBasicInput.js (204561 => 204562)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleBasicInput.js 2016-08-17 17:12:42 UTC (rev 204561)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleBasicInput.js 2016-08-17 17:48:59 UTC (rev 204562)
@@ -32,7 +32,7 @@
this._inputElement = this.contentElement.createChild("input");
this._inputElement.spellcheck = false;
this._inputElement.setAttribute("placeholder", placeholder || "");
- this._inputElement.addEventListener("input", this.debounce(500)._handleInputElementInput);
+ this._inputElement.addEventListener("input", this.debounce(250)._handleInputElementInput);
}
// Public
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleColorPicker.js (204561 => 204562)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleColorPicker.js 2016-08-17 17:12:42 UTC (rev 204561)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleColorPicker.js 2016-08-17 17:48:59 UTC (rev 204562)
@@ -36,7 +36,7 @@
this._textInputElement = document.createElement("input");
this._textInputElement.spellcheck = false;
this._textInputElement.addEventListener("keydown", this._textInputKeyDown.bind(this));
- this._textInputElement.addEventListener("keyup", this._textInputKeyUp.bind(this));
+ this._textInputElement.addEventListener("keyup", this.debounce(250)._textInputKeyUp);
this._textInputElement.addEventListener("blur", this._hideCompletions.bind(this));
this.contentElement.appendChild(this._textInputElement);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleNumberInputBox.js (204561 => 204562)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleNumberInputBox.js 2016-08-17 17:12:42 UTC (rev 204561)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleNumberInputBox.js 2016-08-17 17:48:59 UTC (rev 204562)
@@ -79,9 +79,9 @@
this._valueNumberInputElement.spellcheck = false;
this._valueNumberInputElement.addEventListener("focus", this._focusContentElement.bind(this));
this._valueNumberInputElement.addEventListener("keydown", this._valueNumberInputKeyDown.bind(this));
- this._valueNumberInputElement.addEventListener("keyup", this._valueNumberInputKeyUp.bind(this));
+ this._valueNumberInputElement.addEventListener("keyup", this.debounce(250)._valueNumberInputKeyUp);
this._valueNumberInputElement.addEventListener("blur", this._blurContentElement.bind(this));
- this._valueNumberInputElement.addEventListener("change", this._valueNumberInputChanged.bind(this));
+ this._valueNumberInputElement.addEventListener("change", this.debounce(250)._valueNumberInputChanged);
this._numberUnitsContainer.appendChild(this._valueNumberInputElement);
this._unitsElement = document.createElement("span");
@@ -309,7 +309,7 @@
}
this._markUnitsContainerIfInputHasValue();
- this._valueDidChange();
+ this.debounce(250)._valueDidChange();
}
_valueNumberInputKeyUp(event)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyNameInput.js (204561 => 204562)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyNameInput.js 2016-08-17 17:12:42 UTC (rev 204561)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyNameInput.js 2016-08-17 17:48:59 UTC (rev 204562)
@@ -32,7 +32,7 @@
this._propertyNameInputElement = document.createElement("input");
this._propertyNameInputElement.placeholder = WebInspector.UIString("Enter a name.");
this._propertyNameInputElement.addEventListener("keydown", this._inputKeyDown.bind(this));
- this._propertyNameInputElement.addEventListener("keyup", this._inputKeyUp.bind(this));
+ this._propertyNameInputElement.addEventListener("keyup", this.debounce(250)._inputKeyUp);
this._propertyNameInputElement.addEventListener("blur", this._hideCompletions.bind(this));
this.contentElement.appendChild(this._propertyNameInputElement);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
