Title: [204610] trunk/Source/WebCore
Revision
204610
Author
[email protected]
Date
2016-08-18 14:19:26 -0700 (Thu, 18 Aug 2016)

Log Message

Update the accessibility titles for list insertion
https://bugs.webkit.org/show_bug.cgi?id=160972
-and corresponding-
rdar://problem/27750446

Reviewed by Chris Fleizach.

Update accessibility titles based on feedback.
* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
(WebCore::insertListTypeNone):
(WebCore::insertListTypeBulleted):
(WebCore::insertListTypeBulletedAccessibilityTitle):
(WebCore::insertListTypeNumbered):
(WebCore::insertListTypeNumberedAccessibilityTitle):
(WebCore::insertListTypeNoneAccessibilityTitle): Deleted.
* platform/LocalizedStrings.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (204609 => 204610)


--- trunk/Source/WebCore/ChangeLog	2016-08-18 21:11:38 UTC (rev 204609)
+++ trunk/Source/WebCore/ChangeLog	2016-08-18 21:19:26 UTC (rev 204610)
@@ -1,3 +1,23 @@
+2016-08-18  Beth Dakin  <[email protected]>
+
+        Update the accessibility titles for list insertion
+        https://bugs.webkit.org/show_bug.cgi?id=160972
+        -and corresponding-
+        rdar://problem/27750446
+
+        Reviewed by Chris Fleizach.
+
+        Update accessibility titles based on feedback.
+        * English.lproj/Localizable.strings:
+        * platform/LocalizedStrings.cpp:
+        (WebCore::insertListTypeNone):
+        (WebCore::insertListTypeBulleted):
+        (WebCore::insertListTypeBulletedAccessibilityTitle):
+        (WebCore::insertListTypeNumbered):
+        (WebCore::insertListTypeNumberedAccessibilityTitle):
+        (WebCore::insertListTypeNoneAccessibilityTitle): Deleted.
+        * platform/LocalizedStrings.h:
+
 2016-08-18  Chris Dumez  <[email protected]>
 
         Align our encoding labels with the encoding specification

Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (204609 => 204610)


--- trunk/Source/WebCore/English.lproj/Localizable.strings	2016-08-18 21:11:38 UTC (rev 204609)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings	2016-08-18 21:19:26 UTC (rev 204610)
@@ -31,12 +31,12 @@
 /* Text track display name format that includes the country and language of the subtitle, in the form of 'Title (Language-Country)' */
 "%@ (%@-%@)" = "%@ (%@-%@)";
 
+/* Text track contains Audio Descriptions */
+"%@ AD" = "%@ AD";
+
 /* Text track contains closed captions */
 "%@ CC" = "%@ CC";
 
-/* Text track contains Audio Descriptions */
-"%@ AD" = "%@ AD";
-
 /* visible name of the database process. The argument is the application name. */
 "%@ Database Storage" = "%@ Database Storage";
 
@@ -130,6 +130,9 @@
 /* Undo action name */
 "Bold (Undo action name)" = "Bold";
 
+/* Option in segmented control for inserting a bulleted list in text editing */
+"Bulleted list" = "Bulleted list";
+
 /* menu item title for phone number */
 "Call Using iPhone:" = "Call Using iPhone:";
 
@@ -295,12 +298,6 @@
 /* Undo action name */
 "Insert List (Undo action name)" = "Insert List";
 
-/* Option in segmented control for inserting a bulleted list in text editing */
-"Insert a bulleted list" = "Insert a bulleted list";
-
-/* Option in segmented control for inserting a numbered list in text editing */
-"Insert a numbered list" = "Insert a numbered list";
-
 /* Inspect Element context menu item */
 "Inspect Element" = "Inspect Element";
 
@@ -376,9 +373,6 @@
 /* Empty select list */
 "No Options Select Popover" = "No Options";
 
-/* Accessibility label for not inserting a list in text editing */
-"No list" = "No list";
-
 /* Label for only item in menu that appears when clicking on the search field image, when no searches have been performed */
 "No recent searches" = "No recent searches";
 
@@ -388,6 +382,9 @@
 /* WebKitErrorCannotUseRestrictedPort description */
 "Not allowed to use restricted network port" = "Not allowed to use restricted network port";
 
+/* Option in segmented control for inserting a numbered list in text editing */
+"Numbered list" = "Numbered list";
+
 /* OK button label in PDF password failure alert */
 "OK (PDF password failure alert)" = "OK";
 

Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (204609 => 204610)


--- trunk/Source/WebCore/platform/LocalizedStrings.cpp	2016-08-18 21:11:38 UTC (rev 204609)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp	2016-08-18 21:19:26 UTC (rev 204610)
@@ -1187,11 +1187,6 @@
     return WEB_UI_STRING("None", "Option in segmented control for choosing list type in text editing");
 }
 
-String insertListTypeNoneAccessibilityTitle()
-{
-    return WEB_UI_STRING("No list", "Accessibility label for not inserting a list in text editing");
-}
-
 String insertListTypeBulleted()
 {
     return WEB_UI_STRING("•", "Option in segmented control for choosing list type in text editing");
@@ -1199,7 +1194,7 @@
 
 String insertListTypeBulletedAccessibilityTitle()
 {
-    return WEB_UI_STRING("Insert a bulleted list", "Option in segmented control for inserting a bulleted list in text editing");
+    return WEB_UI_STRING("Bulleted list", "Option in segmented control for inserting a bulleted list in text editing");
 }
 
 String insertListTypeNumbered()
@@ -1209,7 +1204,7 @@
 
 String insertListTypeNumberedAccessibilityTitle()
 {
-    return WEB_UI_STRING("Insert a numbered list", "Option in segmented control for inserting a numbered list in text editing");
+    return WEB_UI_STRING("Numbered list", "Option in segmented control for inserting a numbered list in text editing");
 }
 #endif // PLATFORM(MAC)
 

Modified: trunk/Source/WebCore/platform/LocalizedStrings.h (204609 => 204610)


--- trunk/Source/WebCore/platform/LocalizedStrings.h	2016-08-18 21:11:38 UTC (rev 204609)
+++ trunk/Source/WebCore/platform/LocalizedStrings.h	2016-08-18 21:19:26 UTC (rev 204610)
@@ -282,7 +282,6 @@
 
 #if PLATFORM(MAC)
     WEBCORE_EXPORT String insertListTypeNone();
-    WEBCORE_EXPORT String insertListTypeNoneAccessibilityTitle();
     WEBCORE_EXPORT String insertListTypeBulleted();
     WEBCORE_EXPORT String insertListTypeBulletedAccessibilityTitle();
     WEBCORE_EXPORT String insertListTypeNumbered();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to