Diff
Modified: trunk/LayoutTests/ChangeLog (204728 => 204729)
--- trunk/LayoutTests/ChangeLog 2016-08-22 18:02:03 UTC (rev 204728)
+++ trunk/LayoutTests/ChangeLog 2016-08-22 19:00:08 UTC (rev 204729)
@@ -1,3 +1,16 @@
+2016-08-22 Chris Dumez <[email protected]>
+
+ Add support for GlobalEventHandlers.oncuechange attribute
+ https://bugs.webkit.org/show_bug.cgi?id=161046
+
+ Reviewed by Alex Christensen.
+
+ Add layout test coverage.
+
+ * fast/media/window-oncuechange-expected.txt: Added.
+ * fast/media/window-oncuechange.html: Added.
+ * js/dom/dom-static-property-for-in-iteration-expected.txt:
+
2016-08-22 Simon Fraser <[email protected]>
<select> menu on iPad causes shifting of hit-testing areas
Added: trunk/LayoutTests/fast/media/window-oncuechange-expected.txt (0 => 204729)
--- trunk/LayoutTests/fast/media/window-oncuechange-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/media/window-oncuechange-expected.txt 2016-08-22 19:00:08 UTC (rev 204729)
@@ -0,0 +1,16 @@
+Test window.oncuechange EventHandler attribute
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS window.oncuechange is null
+window._oncuechange_ = function() { ran = true; };
+window.dispatchEvent(testEvent)
+PASS ran is true
+window._oncuechange_ = null
+track.dispatchEvent(testEvent)
+PASS ran is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/media/window-oncuechange.html (0 => 204729)
--- trunk/LayoutTests/fast/media/window-oncuechange.html (rev 0)
+++ trunk/LayoutTests/fast/media/window-oncuechange.html 2016-08-22 19:00:08 UTC (rev 204729)
@@ -0,0 +1,26 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+description("Test window.oncuechange EventHandler attribute");
+
+shouldBeNull("window.oncuechange");
+
+var video = document.createElement('video');
+var track = video.addTextTrack('subtitles');
+var testEvent = new Event('cuechange');
+var ran = false;
+evalAndLog("window._oncuechange_ = function() { ran = true; };");
+
+evalAndLog("window.dispatchEvent(testEvent)");
+shouldBeTrue("ran");
+
+evalAndLog("window._oncuechange_ = null");
+ran = false;
+evalAndLog("track.dispatchEvent(testEvent)");
+shouldBeFalse("ran");
+</script>
+<script src=""
+</body>
+</html>
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (204728 => 204729)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-22 18:02:03 UTC (rev 204728)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-22 19:00:08 UTC (rev 204729)
@@ -1,3 +1,14 @@
+2016-08-22 Chris Dumez <[email protected]>
+
+ Add support for GlobalEventHandlers.oncuechange attribute
+ https://bugs.webkit.org/show_bug.cgi?id=161046
+
+ Reviewed by Alex Christensen.
+
+ Rebaseline W3C test now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
2016-08-19 Chris Dumez <[email protected]>
Unreviewed, roll out part of r204662 to see if it addresses flakiness.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (204728 => 204729)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-08-22 18:02:03 UTC (rev 204728)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-08-22 19:00:08 UTC (rev 204729)
@@ -70,7 +70,7 @@
PASS Document interface: attribute onclick
FAIL Document interface: attribute onclose assert_true: The prototype object must have a property "onclose" expected true got false
PASS Document interface: attribute oncontextmenu
-FAIL Document interface: attribute oncuechange assert_true: The prototype object must have a property "oncuechange" expected true got false
+PASS Document interface: attribute oncuechange
PASS Document interface: attribute ondblclick
PASS Document interface: attribute ondrag
PASS Document interface: attribute ondragend
@@ -255,7 +255,7 @@
PASS Document interface: iframe.contentDocument must inherit property "onclick" with the proper type (99)
FAIL Document interface: iframe.contentDocument must inherit property "onclose" with the proper type (100) assert_inherits: property "onclose" not found in prototype chain
PASS Document interface: iframe.contentDocument must inherit property "oncontextmenu" with the proper type (101)
-FAIL Document interface: iframe.contentDocument must inherit property "oncuechange" with the proper type (102) assert_inherits: property "oncuechange" not found in prototype chain
+PASS Document interface: iframe.contentDocument must inherit property "oncuechange" with the proper type (102)
PASS Document interface: iframe.contentDocument must inherit property "ondblclick" with the proper type (103)
PASS Document interface: iframe.contentDocument must inherit property "ondrag" with the proper type (104)
PASS Document interface: iframe.contentDocument must inherit property "ondragend" with the proper type (105)
@@ -502,7 +502,7 @@
PASS Document interface: new Document() must inherit property "onclick" with the proper type (99)
FAIL Document interface: new Document() must inherit property "onclose" with the proper type (100) assert_inherits: property "onclose" not found in prototype chain
PASS Document interface: new Document() must inherit property "oncontextmenu" with the proper type (101)
-FAIL Document interface: new Document() must inherit property "oncuechange" with the proper type (102) assert_inherits: property "oncuechange" not found in prototype chain
+PASS Document interface: new Document() must inherit property "oncuechange" with the proper type (102)
PASS Document interface: new Document() must inherit property "ondblclick" with the proper type (103)
PASS Document interface: new Document() must inherit property "ondrag" with the proper type (104)
PASS Document interface: new Document() must inherit property "ondragend" with the proper type (105)
@@ -749,7 +749,7 @@
PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "onclick" with the proper type (99)
FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "onclose" with the proper type (100) assert_inherits: property "onclose" not found in prototype chain
PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "oncontextmenu" with the proper type (101)
-FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "oncuechange" with the proper type (102) assert_inherits: property "oncuechange" not found in prototype chain
+PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "oncuechange" with the proper type (102)
PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "ondblclick" with the proper type (103)
PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "ondrag" with the proper type (104)
PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "ondragend" with the proper type (105)
@@ -980,7 +980,7 @@
PASS HTMLElement interface: attribute onclick
FAIL HTMLElement interface: attribute onclose assert_true: The prototype object must have a property "onclose" expected true got false
PASS HTMLElement interface: attribute oncontextmenu
-FAIL HTMLElement interface: attribute oncuechange assert_true: The prototype object must have a property "oncuechange" expected true got false
+PASS HTMLElement interface: attribute oncuechange
PASS HTMLElement interface: attribute ondblclick
PASS HTMLElement interface: attribute ondrag
PASS HTMLElement interface: attribute ondragend
@@ -1070,7 +1070,7 @@
PASS HTMLElement interface: document.createElement("noscript") must inherit property "onclick" with the proper type (34)
FAIL HTMLElement interface: document.createElement("noscript") must inherit property "onclose" with the proper type (35) assert_inherits: property "onclose" not found in prototype chain
PASS HTMLElement interface: document.createElement("noscript") must inherit property "oncontextmenu" with the proper type (36)
-FAIL HTMLElement interface: document.createElement("noscript") must inherit property "oncuechange" with the proper type (37) assert_inherits: property "oncuechange" not found in prototype chain
+PASS HTMLElement interface: document.createElement("noscript") must inherit property "oncuechange" with the proper type (37)
PASS HTMLElement interface: document.createElement("noscript") must inherit property "ondblclick" with the proper type (38)
PASS HTMLElement interface: document.createElement("noscript") must inherit property "ondrag" with the proper type (39)
PASS HTMLElement interface: document.createElement("noscript") must inherit property "ondragend" with the proper type (40)
@@ -5139,7 +5139,7 @@
PASS Window interface: attribute onclick
FAIL Window interface: attribute onclose assert_own_property: The global object must have a property "onclose" expected property "onclose" missing
PASS Window interface: attribute oncontextmenu
-FAIL Window interface: attribute oncuechange assert_own_property: The global object must have a property "oncuechange" expected property "oncuechange" missing
+PASS Window interface: attribute oncuechange
PASS Window interface: attribute ondblclick
PASS Window interface: attribute ondrag
PASS Window interface: attribute ondragend
@@ -5268,7 +5268,7 @@
PASS Window interface: window must inherit property "onclick" with the proper type (46)
FAIL Window interface: window must inherit property "onclose" with the proper type (47) assert_own_property: expected property "onclose" missing
PASS Window interface: window must inherit property "oncontextmenu" with the proper type (48)
-FAIL Window interface: window must inherit property "oncuechange" with the proper type (49) assert_own_property: expected property "oncuechange" missing
+PASS Window interface: window must inherit property "oncuechange" with the proper type (49)
PASS Window interface: window must inherit property "ondblclick" with the proper type (50)
PASS Window interface: window must inherit property "ondrag" with the proper type (51)
PASS Window interface: window must inherit property "ondragend" with the proper type (52)
Modified: trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt (204728 => 204729)
--- trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt 2016-08-22 18:02:03 UTC (rev 204728)
+++ trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt 2016-08-22 19:00:08 UTC (rev 204729)
@@ -53,6 +53,7 @@
PASS a["onchange"] is null
PASS a["onclick"] is null
PASS a["oncontextmenu"] is null
+PASS a["oncuechange"] is null
PASS a["ondblclick"] is null
PASS a["ondrag"] is null
PASS a["ondragend"] is null
@@ -108,7 +109,7 @@
PASS a["prefix"] is null
PASS a["localName"] is a
PASS a["offsetLeft"] is 8
-PASS a["offsetTop"] is 1659
+PASS a["offsetTop"] is 1674
PASS a["offsetWidth"] is 40
PASS a["offsetHeight"] is 18
PASS a["clientLeft"] is 0
Modified: trunk/Source/WebCore/ChangeLog (204728 => 204729)
--- trunk/Source/WebCore/ChangeLog 2016-08-22 18:02:03 UTC (rev 204728)
+++ trunk/Source/WebCore/ChangeLog 2016-08-22 19:00:08 UTC (rev 204729)
@@ -1,3 +1,17 @@
+2016-08-22 Chris Dumez <[email protected]>
+
+ Add support for GlobalEventHandlers.oncuechange attribute
+ https://bugs.webkit.org/show_bug.cgi?id=161046
+
+ Reviewed by Alex Christensen.
+
+ Add support for GlobalEventHandlers.oncuechange attribute:
+ - https://html.spec.whatwg.org/#handler-oncuechange
+
+ Test: fast/media/window-oncuechange.html
+
+ * dom/GlobalEventHandlers.idl:
+
2016-08-22 Alex Christensen <[email protected]>
Fix bindings tests after r204717.
Modified: trunk/Source/WebCore/dom/GlobalEventHandlers.idl (204728 => 204729)
--- trunk/Source/WebCore/dom/GlobalEventHandlers.idl 2016-08-22 18:02:03 UTC (rev 204728)
+++ trunk/Source/WebCore/dom/GlobalEventHandlers.idl 2016-08-22 19:00:08 UTC (rev 204729)
@@ -42,7 +42,7 @@
attribute EventHandler onclick;
// attribute EventHandler onclose;
attribute EventHandler oncontextmenu;
- // attribute EventHandler oncuechange;
+ attribute EventHandler oncuechange;
attribute EventHandler ondblclick;
attribute EventHandler ondrag;
attribute EventHandler ondragend;
