Diff
Modified: trunk/LayoutTests/ChangeLog (204764 => 204765)
--- trunk/LayoutTests/ChangeLog 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/ChangeLog 2016-08-23 06:44:02 UTC (rev 204765)
@@ -1,3 +1,52 @@
+2016-08-22 Chris Dumez <[email protected]>
+
+ Drop TextTrackCue's constructor as per the latest specification
+ https://bugs.webkit.org/show_bug.cgi?id=161061
+
+ Reviewed by Alex Christensen.
+
+ Update existing tests to use VTTCue's constructor instead of
+ TextTrackCue's.
+
+ * js/dom/constructor-length.html:
+ * media/track/getCueAsHTMLCrash.html:
+ * media/track/opera/interfaces/TextTrack/activeCues.html:
+ * media/track/opera/interfaces/TextTrackCue/getCueAsHTML.html:
+ * media/track/opera/interfaces/TextTrackCue/line.html:
+ * media/track/opera/interfaces/TextTrackCue/onenter.html:
+ * media/track/opera/interfaces/TextTrackCue/onexit.html:
+ * media/track/opera/interfaces/TextTrackCue/snapToLines.html:
+ * media/track/opera/interfaces/TextTrackCue/text.html:
+ * media/track/opera/interfaces/TextTrackCue/vertical.html:
+ * media/track/opera/interfaces/TextTrackCueList/getter.html:
+ * media/track/opera/track/track-element/src-clear-cues.html:
+ * media/track/opera/track/webvtt/rendering/reftest/repaint.html:
+ * media/track/regions-webvtt/text-track-cue-region-attribute.html:
+ * media/track/track-add-remove-cue-expected.txt:
+ * media/track/track-add-remove-cue.html:
+ * media/track/track-cue-empty-cue-text.html:
+ * media/track/track-cue-empty-text-crash.html:
+ * media/track/track-cue-inline-assertion-crash.html:
+ * media/track/track-cue-negative-timestamp-expected.txt:
+ * media/track/track-cue-negative-timestamp.html:
+ * media/track/track-cue-rendering-empty-cue-crash.html:
+ * media/track/track-cue-rendering-mode-changed.html:
+ * media/track/track-disabled-addcue.html:
+ * media/track/track-remove-active-cue-crash.html:
+ * media/track/w3c/interfaces/TextTrack/addCue.html:
+ * media/track/w3c/interfaces/TextTrack/cues.html:
+ * media/track/w3c/interfaces/TextTrack/removeCue.html:
+ * media/track/w3c/interfaces/TextTrackCue/align.html:
+ * media/track/w3c/interfaces/TextTrackCue/endTime.html:
+ * media/track/w3c/interfaces/TextTrackCue/id.html:
+ * media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html:
+ * media/track/w3c/interfaces/TextTrackCue/startTime.html:
+ * media/track/w3c/interfaces/TextTrackCue/track.html:
+ * media/track/w3c/interfaces/TextTrackCueList/getCueById.html:
+ * media/track/w3c/interfaces/TextTrackCueList/length.html:
+ * media/video-controls-captions.html:
+ * platform/mac/js/dom/constructor-length-expected.txt:
+
2016-08-22 Jiewen Tan <[email protected]>
Unreviewed, update failure list of iOS simulator WK1 compositing test.
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (204764 => 204765)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-23 06:44:02 UTC (rev 204765)
@@ -1,5 +1,17 @@
2016-08-22 Chris Dumez <[email protected]>
+ Drop TextTrackCue's constructor as per the latest specification
+ https://bugs.webkit.org/show_bug.cgi?id=161061
+
+ Reviewed by Alex Christensen.
+
+ Rebaseline several W3C tests now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+ * web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt:
+
+2016-08-22 Chris Dumez <[email protected]>
+
Unreviewed, rolling out r204745.
Broke the Windows build
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (204764 => 204765)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-08-23 06:44:02 UTC (rev 204765)
@@ -2293,7 +2293,7 @@
PASS TextTrackCueList interface: document.createElement("video").addTextTrack("subtitles").cues must inherit property "getCueById" with the proper type (2)
PASS TextTrackCueList interface: calling getCueById(DOMString) on document.createElement("video").addTextTrack("subtitles").cues with too few arguments must throw TypeError
PASS TextTrackCue interface: existence and properties of interface object
-FAIL TextTrackCue interface object length assert_equals: wrong value for TextTrackCue.length expected 0 but got 3
+PASS TextTrackCue interface object length
PASS TextTrackCue interface object name
PASS TextTrackCue interface: existence and properties of interface prototype object
PASS TextTrackCue interface: existence and properties of interface prototype object's "constructor" property
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt (204764 => 204765)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt 2016-08-23 06:44:02 UTC (rev 204765)
@@ -41,7 +41,5 @@
PASS video.audio should not be supported
PASS audio.startDate should not be supported
PASS video.startDate should not be supported
-FAIL TextTrackCue constructor should not be supported assert_throws: function "function () {
- new TextTrackCue(0, 0, '');
- }" did not throw
+PASS TextTrackCue constructor should not be supported
Modified: trunk/LayoutTests/js/dom/constructor-length.html (204764 => 204765)
--- trunk/LayoutTests/js/dom/constructor-length.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/js/dom/constructor-length.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -41,7 +41,7 @@
shouldBe('ProgressEvent.length', '1');
shouldBe('ShadowRoot.length', '1');
shouldBe('StorageEvent.length', '1');
-shouldBe('TextTrackCue.length', '3');
+shouldBe('TextTrackCue.length', '0');
shouldBe('TrackEvent.length', '1');
shouldBe('Uint16Array.length', '0');
shouldBe('Uint32Array.length', '0');
Modified: trunk/LayoutTests/media/track/getCueAsHTMLCrash.html (204764 => 204765)
--- trunk/LayoutTests/media/track/getCueAsHTMLCrash.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/getCueAsHTMLCrash.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -5,7 +5,7 @@
<script src=""
<script>
test(function() {
- var cue = new TextTrackCue(0, 1, '<c>x\0');
+ var cue = new VTTCue(0, 1, '<c>x\0');
window.fragment = cue.getCueAsHTML();
}, document.title + ', creating the cue');
Modified: trunk/LayoutTests/media/track/opera/interfaces/TextTrack/activeCues.html (204764 => 204765)
--- trunk/LayoutTests/media/track/opera/interfaces/TextTrack/activeCues.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/opera/interfaces/TextTrack/activeCues.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -34,11 +34,11 @@
}, document.title+', empty list');
test(function(){
smoke_test();
- var c = new TextTrackCue(0, 1, "text");
+ var c = new VTTCue(0, 1, "text");
t1.addCue(c);
assert_equals(t1.activeCues, t1_cues, "t1.activeCues should return same object");
assert_equals(t1.activeCues.length, 0, "t1.activeCues.length");
- var c2 = new TextTrackCue(1, 2, "text2");
+ var c2 = new VTTCue(1, 2, "text2");
t1.addCue(c2);
assert_equals(t1.activeCues, t1_cues, "t1.activeCues should return the same object after adding a second cue");
assert_equals(t1.activeCues.length, 0, "t1.activeCues.length after adding a second cue");
@@ -74,7 +74,7 @@
return;
}
test3.step(function(){
- var c3 = new TextTrackCue(0, 2, "text3");
+ var c3 = new VTTCue(0, 2, "text3");
t1.addCue(c3);
assert_equals(t1.activeCues.length, 1, "t1.activeCues.length after adding a cue in the same script");
setTimeout(test3.step_func(function(){
Modified: trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/getCueAsHTML.html (204764 => 204765)
--- trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/getCueAsHTML.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/getCueAsHTML.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -8,7 +8,7 @@
var video = document.createElement('video');
var t1 = video.addTextTrack('subtitles');
document.body.appendChild(video);
- var c1 = new TextTrackCue(0, 1, '<c></c><c.a.b></c><i></i><b></b><u></u><ruby><rt></rt></ruby><v></v><v a b></v><00:00:00.500>x\0');
+ var c1 = new VTTCue(0, 1, '<c></c><c.a.b></c><i></i><b></b><u></u><ruby><rt></rt></ruby><v></v><v a b></v><00:00:00.500>x\0');
t1.addCue(c1);
window.frag = c1.getCueAsHTML();
assert_equals(frag.childNodes.length, 10, 'childNodes.length');
Modified: trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/line.html (204764 => 204765)
--- trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/line.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/line.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -7,7 +7,7 @@
test(function(){
var video = document.createElement('video');
document.body.appendChild(video);
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
assert_equals(c1.line, -1);
var track = document.createElement('track');
var t = track.track;
@@ -17,7 +17,7 @@
assert_equals(c1.line, -1);
t.mode = 'showing';
assert_equals(c1.line, -1);
- var c2 = new TextTrackCue(0, 1, 'text2');
+ var c2 = new VTTCue(0, 1, 'text2');
var track2 = document.createElement('track');
var t2 = track2.track;
t2.addCue(c2);
Modified: trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/onenter.html (204764 => 204765)
--- trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/onenter.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/onenter.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -5,7 +5,7 @@
<div id=log></div>
<script>
setup(function(){
- window.c1 = new TextTrackCue(0, 1, 'text1');
+ window.c1 = new VTTCue(0, 1, 'text1');
window.ev = new Event('enter');
window.ran = false;
window.cb = function() { ran = true; };
Modified: trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/onexit.html (204764 => 204765)
--- trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/onexit.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/onexit.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -5,7 +5,7 @@
<div id=log></div>
<script>
setup(function(){
- window.c1 = new TextTrackCue(0, 1, 'text1');
+ window.c1 = new VTTCue(0, 1, 'text1');
window.ev = new Event('exit');
window.ran = false;
window.cb = function() { ran = true; };
Modified: trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/snapToLines.html (204764 => 204765)
--- trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/snapToLines.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/snapToLines.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -10,7 +10,7 @@
document.body.appendChild(video);
});
test(function(){
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
assert_true(c1.snapToLines);
c1.line = 101;
c1.snapToLines = false;
Modified: trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/text.html (204764 => 204765)
--- trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/text.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/text.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -10,7 +10,7 @@
document.body.appendChild(video);
});
test(function(){
- var c1 = new TextTrackCue(0, 1, 'text1\r\n\n\u0000');
+ var c1 = new VTTCue(0, 1, 'text1\r\n\n\u0000');
assert_equals(c1.text, 'text1\r\n\n\u0000');
c1.text = c1.text;
assert_equals(c1.text, 'text1\r\n\n\u0000');
Modified: trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/vertical.html (204764 => 204765)
--- trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/vertical.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/vertical.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -12,7 +12,7 @@
test(function(){
var video = document.createElement('video');
document.body.appendChild(video);
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
assert_equals(c1.vertical, '');
var track = document.createElement('track');
var t = track.track;
Modified: trunk/LayoutTests/media/track/opera/interfaces/TextTrackCueList/getter.html (204764 => 204765)
--- trunk/LayoutTests/media/track/opera/interfaces/TextTrackCueList/getter.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/opera/interfaces/TextTrackCueList/getter.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -12,7 +12,7 @@
test(function(){
var cues = t1.cues;
assert_equals(cues[0], undefined, 'cues[0] before');
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
t1.addCue(c1);
assert_equals(cues[0], c1, 'cues[0]');
assert_equals(cues[1], undefined, 'cues[1]');
@@ -25,7 +25,7 @@
assert_equals(cues[0], undefined);
cues[0] = 'foo';
assert_equals(cues[0], undefined);
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
t1.addCue(c1);
assert_equals(cues[0], c1);
cues[0] = 'foo';
@@ -38,7 +38,7 @@
assert_equals(cues[0], undefined);
assert_throws(new TypeError(), function() { cues[0] = 'foo'; });
assert_equals(cues[0], undefined);
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
t1.addCue(c1);
assert_equals(cues[0], c1);
assert_throws(new TypeError(), function() { cues[0] = 'foo'; });
Modified: trunk/LayoutTests/media/track/opera/track/track-element/src-clear-cues.html (204764 => 204765)
--- trunk/LayoutTests/media/track/opera/track/track-element/src-clear-cues.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/opera/track/track-element/src-clear-cues.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -6,7 +6,7 @@
<script>
(async_test(document.title+', set mode, add cue, set src')).step(function(){
var track = document.createElement('track');
- var c = new TextTrackCue(0, 1, 'foo');
+ var c = new VTTCue(0, 1, 'foo');
c.id = 'id';
track.track.addCue(c);
assert_equals(track.track.cues, null, 'cues before setting src or mode');
@@ -24,7 +24,7 @@
var track = document.createElement('track');
track.track.mode = 'showing';
track.src = '';
- var c = new TextTrackCue(0, 1, 'foo');
+ var c = new VTTCue(0, 1, 'foo');
c.id = 'id';
track.track.addCue(c);
assert_equals(track.track.cues.length, 1, 'cues.length before changing src');
@@ -39,7 +39,7 @@
(async_test(document.title+', set mode, add cue, change mode to disabled, set src')).step(function(){
var track = document.createElement('track');
track.track.mode = 'showing';
- var c = new TextTrackCue(0, 1, 'foo');
+ var c = new VTTCue(0, 1, 'foo');
c.id = 'id';
track.track.addCue(c);
var cues = track.track.cues;
Modified: trunk/LayoutTests/media/track/opera/track/webvtt/rendering/reftest/repaint.html (204764 => 204765)
--- trunk/LayoutTests/media/track/opera/track/webvtt/rendering/reftest/repaint.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/opera/track/webvtt/rendering/reftest/repaint.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -35,7 +35,7 @@
var c = document.getElementById('cover');
var t = v.addTextTrack('subtitles');
t.mode = "showing";
-t.addCue(new TextTrackCue(0, 100, 'PASS'));
+t.addCue(new VTTCue(0, 100, 'PASS'));
v._onplaying_ = function() {
setTimeout(function() {
v.pause();
Modified: trunk/LayoutTests/media/track/regions-webvtt/text-track-cue-region-attribute.html (204764 => 204765)
--- trunk/LayoutTests/media/track/regions-webvtt/text-track-cue-region-attribute.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/regions-webvtt/text-track-cue-region-attribute.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -16,7 +16,7 @@
}
consoleWrite("<br>** Test the setter and getter through the JS API **");
- cue = new TextTrackCue(0.0, 1.0, "sample");
+ cue = new VTTCue(0.0, 1.0, "sample");
testExpected("cue.regionId", "");
cue.regionId = "someId";
Modified: trunk/LayoutTests/media/track/track-add-remove-cue-expected.txt (204764 => 204765)
--- trunk/LayoutTests/media/track/track-add-remove-cue-expected.txt 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/track-add-remove-cue-expected.txt 2016-08-23 06:44:02 UTC (rev 204765)
@@ -11,7 +11,7 @@
EXPECTED (cues.getCueById('junk') == 'undefined') OK
*** Create a new cue, check values
-RUN(textCue = new TextTrackCue(33, 3.4, 'Sausage?'))
+RUN(textCue = new VTTCue(33, 3.4, 'Sausage?'))
EXPECTED (textCue.track == 'null') OK
EXPECTED (textCue.id == '') OK
EXPECTED (textCue.startTime == '33') OK
@@ -33,7 +33,7 @@
*** create a new cue and add it to a track created with video.addTextTrack, make sure it is inserted correctly.
RUN(newTrack = video.addTextTrack("subtitles", "French subtitles", "fr"))
-RUN(newTrack.addCue(new TextTrackCue(0.0, 1.0, "Test!")))
+RUN(newTrack.addCue(new VTTCue(0.0, 1.0, "Test!")))
RUN(newCue = newTrack.cues[0])
EXPECTED (newCue.track == '[object TextTrack]') OK
EXPECTED (newCue.id == '') OK
@@ -48,7 +48,7 @@
EXPECTED (newCue.align == 'middle') OK
*** Create an old-style cue with an id.
-RUN(oldStyleCue = new TextTrackCue('sausage-cue', 33, 3.4, 'Sausage?'))
+RUN(oldStyleCue = new VTTCue('sausage-cue', 33, 3.4, 'Sausage?'))
EXPECTED (oldStyleCue.id == '') OK
EXPECTED (oldStyleCue.startTime.toString() == 'NaN') OK
EXPECTED (oldStyleCue.endTime == '33') OK
@@ -74,7 +74,7 @@
TEST(testTrack.track.removeCue(textCue)) THROWS(DOMException.NOT_FOUND_ERR) OK
*** Add a cue before all the existing cues.
-RUN(testTrack.track.addCue(new TextTrackCue(0, 31, 'I am first')))
+RUN(testTrack.track.addCue(new VTTCue(0, 31, 'I am first')))
EXPECTED (cues[0].startTime == '0') OK
EXPECTED (cues[0].endTime == '31') OK
EXPECTED (cues[1].startTime == '0') OK
Modified: trunk/LayoutTests/media/track/track-add-remove-cue.html (204764 => 204765)
--- trunk/LayoutTests/media/track/track-add-remove-cue.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/track-add-remove-cue.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -23,7 +23,7 @@
testExpected("cues.getCueById('junk')", undefined);
consoleWrite("<br>*** Create a new cue, check values");
- run("textCue = new TextTrackCue(33, 3.4, 'Sausage?')");
+ run("textCue = new VTTCue(33, 3.4, 'Sausage?')");
testExpected("textCue.track", null);
testExpected("textCue.id", '');
testExpected("textCue.startTime", 33);
@@ -47,7 +47,7 @@
findMediaElement();
run('newTrack = video.addTextTrack("subtitles", "French subtitles", "fr")');
newTrack.mode = 2;
- run('newTrack.addCue(new TextTrackCue(0.0, 1.0, "Test!"))');
+ run('newTrack.addCue(new VTTCue(0.0, 1.0, "Test!"))');
run('newCue = newTrack.cues[0]');
testExpected("newCue.track", newTrack);
testExpected("newCue.id", "");
@@ -62,7 +62,7 @@
testExpected("newCue.align", "middle");
consoleWrite("<br>*** Create an old-style cue with an id.");
- run("oldStyleCue = new TextTrackCue('sausage-cue', 33, 3.4, 'Sausage?')");
+ run("oldStyleCue = new VTTCue('sausage-cue', 33, 3.4, 'Sausage?')");
testExpected("oldStyleCue.id", "");
testExpected("oldStyleCue.startTime.toString()", "NaN");
testExpected("oldStyleCue.endTime", 33);
@@ -88,7 +88,7 @@
testDOMException("testTrack.track.removeCue(textCue)", "DOMException.NOT_FOUND_ERR");
consoleWrite("<br>*** Add a cue before all the existing cues.");
- run("testTrack.track.addCue(new TextTrackCue(0, 31, 'I am first'))");
+ run("testTrack.track.addCue(new VTTCue(0, 31, 'I am first'))");
testExpected("cues[0].startTime", 0);
testExpected("cues[0].endTime", 31);
testExpected("cues[1].startTime", 0);
Modified: trunk/LayoutTests/media/track/track-cue-empty-cue-text.html (204764 => 204765)
--- trunk/LayoutTests/media/track/track-cue-empty-cue-text.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/track-cue-empty-cue-text.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -7,7 +7,7 @@
var fragment;
function startTest()
{
- var emptyCue = new TextTrackCue(0, 0, "");
+ var emptyCue = new VTTCue(0, 0, "");
fragment = emptyCue.getCueAsHTML();
consoleWrite("** The getCueAsHTML() method should return a document fragment **");
Modified: trunk/LayoutTests/media/track/track-cue-empty-text-crash.html (204764 => 204765)
--- trunk/LayoutTests/media/track/track-cue-empty-text-crash.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/track-cue-empty-text-crash.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -21,7 +21,7 @@
video.addTextTrack("captions", "regular captions track", "en");
consoleWrite("** Add an empty cue to the track...");
- video.textTracks[0].addCue(new TextTrackCue(0.00, 4.00, ""));
+ video.textTracks[0].addCue(new VTTCue(0.00, 4.00, ""));
video.textTracks[0].mode = "showing";
consoleWrite("** Play the video so the cue is scheduled to render...<br>");
Modified: trunk/LayoutTests/media/track/track-cue-inline-assertion-crash.html (204764 => 204765)
--- trunk/LayoutTests/media/track/track-cue-inline-assertion-crash.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/track-cue-inline-assertion-crash.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -15,7 +15,7 @@
var t = video.addTextTrack('captions', 'English', 'en');
consoleWrite("** Add cue to the text track **");
- t.addCue(new TextTrackCue(0.0, 10.0, 'wow wow'));
+ t.addCue(new VTTCue(0.0, 10.0, 'wow wow'));
consoleWrite("** Set the track mode to showing **");
t.mode = "showing";
Modified: trunk/LayoutTests/media/track/track-cue-negative-timestamp-expected.txt (204764 => 204765)
--- trunk/LayoutTests/media/track/track-cue-negative-timestamp-expected.txt 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/track-cue-negative-timestamp-expected.txt 2016-08-23 06:44:02 UTC (rev 204765)
@@ -3,13 +3,13 @@
Test that cues with negative startTime are not added:
EXPECTED (testTrack.track.cues.length == '4') OK
-RUN(textCue = new TextTrackCue('sausage-cue', -3439332606, 3.4, 'Sausage?'))
+RUN(textCue = new VTTCue('sausage-cue', -3439332606, 3.4, 'Sausage?'))
RUN(testTrack.track.addCue(textCue))
EXPECTED (testTrack.track.cues.length == '4') OK
Test that cues with negative startTime and negative endTime are not added:
EXPECTED (testTrack.track.cues.length == '4') OK
-RUN(textCue = new TextTrackCue('pepperoni-cue', -110, -3.4, 'Pepperoni?'))
+RUN(textCue = new VTTCue('pepperoni-cue', -110, -3.4, 'Pepperoni?'))
RUN(testTrack.track.addCue(textCue))
EXPECTED (testTrack.track.cues.length == '4') OK
Modified: trunk/LayoutTests/media/track/track-cue-negative-timestamp.html (204764 => 204765)
--- trunk/LayoutTests/media/track/track-cue-negative-timestamp.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/track-cue-negative-timestamp.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -10,13 +10,13 @@
{
consoleWrite("Test that cues with negative startTime are not added:");
testExpected("testTrack.track.cues.length", 4);
- run("textCue = new TextTrackCue('sausage-cue', -3439332606, 3.4, 'Sausage?')");
+ run("textCue = new VTTCue('sausage-cue', -3439332606, 3.4, 'Sausage?')");
run("testTrack.track.addCue(textCue)");
testExpected("testTrack.track.cues.length", 4);
consoleWrite("<br>Test that cues with negative startTime and negative endTime are not added:");
testExpected("testTrack.track.cues.length", 4);
- run("textCue = new TextTrackCue('pepperoni-cue', -110, -3.4, 'Pepperoni?')");
+ run("textCue = new VTTCue('pepperoni-cue', -110, -3.4, 'Pepperoni?')");
run("testTrack.track.addCue(textCue)");
testExpected("testTrack.track.cues.length", 4);
Modified: trunk/LayoutTests/media/track/track-cue-rendering-empty-cue-crash.html (204764 => 204765)
--- trunk/LayoutTests/media/track/track-cue-rendering-empty-cue-crash.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/track-cue-rendering-empty-cue-crash.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -15,7 +15,7 @@
video.addTextTrack("captions", "regular captions track", "en");
consoleWrite("** Add an empty cue to the track **");
- video.textTracks[0].addCue(new TextTrackCue(0.00, 4.00, ""));
+ video.textTracks[0].addCue(new VTTCue(0.00, 4.00, ""));
consoleWrite("** Play the video and render the cue **");
video.play();
Modified: trunk/LayoutTests/media/track/track-cue-rendering-mode-changed.html (204764 => 204765)
--- trunk/LayoutTests/media/track/track-cue-rendering-mode-changed.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/track-cue-rendering-mode-changed.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -44,11 +44,11 @@
consoleWrite("Add 'Arabic' text track with one cue");
testTrackArabic = video.addTextTrack('captions', 'Arabic', 'ar');
- testTrackArabic.addCue(new TextTrackCue(0.0, 10.0, 'Arabic'));
+ testTrackArabic.addCue(new VTTCue(0.0, 10.0, 'Arabic'));
consoleWrite("Add 'English' text track with one cue");
testTrackEnglish = video.addTextTrack('captions', 'English', 'en');
- testTrackEnglish.addCue(new TextTrackCue(0.0, 10.0, 'English'));
+ testTrackEnglish.addCue(new VTTCue(0.0, 10.0, 'English'));
consoleWrite("");
consoleWrite("Set the mode of the 'Arabic' track to showing");
Modified: trunk/LayoutTests/media/track/track-disabled-addcue.html (204764 => 204765)
--- trunk/LayoutTests/media/track/track-disabled-addcue.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/track-disabled-addcue.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -16,7 +16,7 @@
for (var i = 0; i < 10; ++i) {
var start = i * cueDuration;
var end = start + cueDuration;
- track.addCue(new TextTrackCue(start, end, "Test Cue " + i));
+ track.addCue(new VTTCue(start, end, "Test Cue " + i));
}
consoleWrite("Waiting for 2 cue durations to elapse.");
Modified: trunk/LayoutTests/media/track/track-remove-active-cue-crash.html (204764 => 204765)
--- trunk/LayoutTests/media/track/track-remove-active-cue-crash.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/track-remove-active-cue-crash.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -30,7 +30,7 @@
video.addTextTrack("captions", "regular captions track", "en");
consoleWrite("** Add a cue to the track with enter event listener. **");
- var cue = new TextTrackCue(0.00, 4.00, "Random");
+ var cue = new VTTCue(0.00, 4.00, "Random");
cue.addEventListener("enter", removeActiveCue);
video.textTracks[0].addCue(cue);
Modified: trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/addCue.html (204764 => 204765)
--- trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/addCue.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/addCue.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -11,7 +11,7 @@
test(function() {
var t1 = video.addTextTrack('subtitles');
var t2 = video.addTextTrack('subtitles');
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
t1.addCue(c1);
t2.addCue(c1);
assert_equals(c1.track, t2);
@@ -18,7 +18,7 @@
}, document.title+', adding a cue to two different tracks');
test(function() {
var t1 = video.addTextTrack('subtitles');
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
t1.addCue(c1);
assert_equals(c1.track, t1);
t1.addCue(c1);
@@ -27,7 +27,7 @@
test(function() {
var t1 = video.addTextTrack('subtitles');
var t2 = video.addTextTrack('subtitles');
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
t1.addCue(c1);
assert_equals(c1.track, t1);
t1.removeCue(c1);
@@ -37,7 +37,7 @@
}, document.title+', adding a removed cue to a different track');
test(function() {
var t1 = video.addTextTrack('subtitles');
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
t1.addCue(c1);
assert_equals(t1.cues.length, 1, 't1.cues.length after first addition');
t1.removeCue(c1);
Modified: trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/cues.html (204764 => 204765)
--- trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/cues.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/cues.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -20,12 +20,12 @@
assert_equals(t1.cues.length, 0, 't1.cues should have length 0');
}, document.title+', empty list');
test(function(){
- var c = new TextTrackCue(0, 1, "text");
+ var c = new VTTCue(0, 1, "text");
c.id = "id";
t1.addCue(c);
assert_equals(t1.cues, t1_cues, "t1.cues should return same object");
assert_equals(t1.cues.length, 1, "t1.cues.length");
- var c2 = new TextTrackCue(1, 2, "text2");
+ var c2 = new VTTCue(1, 2, "text2");
c2.id = "id2";
t1.addCue(c2);
assert_equals(t1.cues, t1_cues, "t1.cues should return the same object after adding a second cue");
Modified: trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/removeCue.html (204764 => 204765)
--- trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/removeCue.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/removeCue.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -11,7 +11,7 @@
test(function() {
var t1 = video.addTextTrack('subtitles');
var t2 = video.addTextTrack('subtitles');
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
assert_throws("NOT_FOUND_ERR", function() {
t1.removeCue(c1);
}, 'standalone');
Modified: trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/align.html (204764 => 204765)
--- trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/align.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/align.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -7,7 +7,7 @@
test(function(){
var video = document.createElement('video');
document.body.appendChild(video);
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
assert_equals(c1.align, 'middle');
var track = document.createElement('track');
var t = track.track;
Modified: trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/endTime.html (204764 => 204765)
--- trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/endTime.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/endTime.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -10,7 +10,7 @@
document.body.appendChild(video);
});
test(function(){
- var c1 = new TextTrackCue(-2, -1, 'text1');
+ var c1 = new VTTCue(-2, -1, 'text1');
assert_equals(c1.endTime, -1);
c1.endTime = c1.endTime;
assert_equals(c1.endTime, -1);
Modified: trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/id.html (204764 => 204765)
--- trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/id.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/id.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -10,7 +10,7 @@
document.body.appendChild(video);
});
test(function(){
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
c1.id = 'id1\r\n\u0000';
assert_equals(c1.id, 'id1\r\n\u0000');
c1.id = c1.id;
Modified: trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html (204764 => 204765)
--- trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -10,7 +10,7 @@
document.body.appendChild(video);
});
test(function(){
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
assert_equals(c1.pauseOnExit, false);
c1.pauseOnExit = null;
assert_equals(c1.pauseOnExit, false);
Modified: trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/startTime.html (204764 => 204765)
--- trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/startTime.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/startTime.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -10,7 +10,7 @@
document.body.appendChild(video);
});
test(function(){
- var c1 = new TextTrackCue(-1, 1, 'text1');
+ var c1 = new VTTCue(-1, 1, 'text1');
assert_equals(c1.startTime, -1);
c1.startTime = c1.startTime;
assert_equals(c1.startTime, -1);
Modified: trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/track.html (204764 => 204765)
--- trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/track.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCue/track.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -10,7 +10,7 @@
document.body.appendChild(video);
});
test(function(){
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
assert_equals(c1.track, null);
t1.addCue(c1);
assert_equals(c1.track, t1);
Modified: trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCueList/getCueById.html (204764 => 204765)
--- trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCueList/getCueById.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCueList/getCueById.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -9,7 +9,7 @@
var t = video.addTextTrack('subtitles');
document.body.appendChild(video);
var cues = t.cues;
- var c = new TextTrackCue(0, 1, 'text1');
+ var c = new VTTCue(0, 1, 'text1');
t.addCue(c);
assert_equals(cues.getCueById(""), null, '""');
assert_equals(cues.getCueById(null), null, 'null');
@@ -20,7 +20,7 @@
var t = video.addTextTrack('subtitles');
document.body.appendChild(video);
var cues = t.cues;
- var c = new TextTrackCue(0, 1, 'text1');
+ var c = new VTTCue(0, 1, 'text1');
c.id = 'foo';
t.addCue(c);
assert_equals(cues.getCueById(""), null, '""');
@@ -32,7 +32,7 @@
var t = video.addTextTrack('subtitles');
document.body.appendChild(video);
var cues = t.cues;
- var c = new TextTrackCue(0, 1, 'text1');
+ var c = new VTTCue(0, 1, 'text1');
c.id = '1';
t.addCue(c);
assert_equals(cues.getCueById(""), null, '""');
@@ -44,7 +44,7 @@
var t = video.addTextTrack('subtitles');
document.body.appendChild(video);
var cues = t.cues;
- var c = new TextTrackCue(0, 1, 'text1');
+ var c = new VTTCue(0, 1, 'text1');
c.id = 'a\u0000b';
t.addCue(c);
assert_equals(cues.getCueById("a\u0000b"), c, '"a\\u0000b"');
Modified: trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCueList/length.html (204764 => 204765)
--- trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCueList/length.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/track/w3c/interfaces/TextTrackCueList/length.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -12,7 +12,7 @@
test(function(){
var cues = t1.cues;
assert_equals(cues.length, 0);
- var c1 = new TextTrackCue(0, 1, 'text1');
+ var c1 = new VTTCue(0, 1, 'text1');
t1.addCue(c1);
assert_equals(cues.length, 1);
t1.removeCue(c1);
Modified: trunk/LayoutTests/media/video-controls-captions.html (204764 => 204765)
--- trunk/LayoutTests/media/video-controls-captions.html 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/media/video-controls-captions.html 2016-08-23 06:44:02 UTC (rev 204765)
@@ -16,7 +16,7 @@
consoleWrite("");
consoleWrite("** Add a text track through JS to the video element **");
var t = video.addTextTrack('captions', 'English', 'en');
- t.addCue(new TextTrackCue(0.0, 10.0, 'Some random caption text'));
+ t.addCue(new VTTCue(0.0, 10.0, 'Some random caption text'));
}
function addUnloadableHTMLTrackElement()
Modified: trunk/LayoutTests/platform/efl/js/dom/constructor-length-expected.txt (204764 => 204765)
--- trunk/LayoutTests/platform/efl/js/dom/constructor-length-expected.txt 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/platform/efl/js/dom/constructor-length-expected.txt 2016-08-23 06:44:02 UTC (rev 204765)
@@ -37,7 +37,7 @@
PASS ProgressEvent.length is 1
FAIL ShadowRoot.length should be 1. Threw exception ReferenceError: Can't find variable: ShadowRoot
PASS StorageEvent.length is 1
-PASS TextTrackCue.length is 3
+PASS TextTrackCue.length is 0
PASS TrackEvent.length is 1
PASS Uint16Array.length is 0
PASS Uint32Array.length is 0
Modified: trunk/LayoutTests/platform/gtk/js/dom/constructor-length-expected.txt (204764 => 204765)
--- trunk/LayoutTests/platform/gtk/js/dom/constructor-length-expected.txt 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/platform/gtk/js/dom/constructor-length-expected.txt 2016-08-23 06:44:02 UTC (rev 204765)
@@ -37,7 +37,7 @@
PASS ProgressEvent.length is 1
FAIL ShadowRoot.length should be 1. Threw exception ReferenceError: Can't find variable: ShadowRoot
PASS StorageEvent.length is 1
-PASS TextTrackCue.length is 3
+PASS TextTrackCue.length is 0
PASS TrackEvent.length is 1
PASS Uint16Array.length is 0
PASS Uint32Array.length is 0
Modified: trunk/LayoutTests/platform/ios-simulator/js/dom/constructor-length-expected.txt (204764 => 204765)
--- trunk/LayoutTests/platform/ios-simulator/js/dom/constructor-length-expected.txt 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/platform/ios-simulator/js/dom/constructor-length-expected.txt 2016-08-23 06:44:02 UTC (rev 204765)
@@ -37,7 +37,7 @@
PASS ProgressEvent.length is 1
FAIL ShadowRoot.length should be 1. Was 0.
PASS StorageEvent.length is 1
-PASS TextTrackCue.length is 3
+PASS TextTrackCue.length is 0
PASS TrackEvent.length is 1
PASS Uint16Array.length is 0
PASS Uint32Array.length is 0
Modified: trunk/LayoutTests/platform/mac/js/dom/constructor-length-expected.txt (204764 => 204765)
--- trunk/LayoutTests/platform/mac/js/dom/constructor-length-expected.txt 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/platform/mac/js/dom/constructor-length-expected.txt 2016-08-23 06:44:02 UTC (rev 204765)
@@ -37,7 +37,7 @@
PASS ProgressEvent.length is 1
FAIL ShadowRoot.length should be 1. Was 0.
PASS StorageEvent.length is 1
-PASS TextTrackCue.length is 3
+PASS TextTrackCue.length is 0
PASS TrackEvent.length is 1
PASS Uint16Array.length is 0
PASS Uint32Array.length is 0
Modified: trunk/LayoutTests/platform/win/js/dom/constructor-length-expected.txt (204764 => 204765)
--- trunk/LayoutTests/platform/win/js/dom/constructor-length-expected.txt 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/LayoutTests/platform/win/js/dom/constructor-length-expected.txt 2016-08-23 06:44:02 UTC (rev 204765)
@@ -37,7 +37,7 @@
PASS ProgressEvent.length is 1
FAIL ShadowRoot.length should be 1. Threw exception ReferenceError: Can't find variable: ShadowRoot
PASS StorageEvent.length is 1
-PASS TextTrackCue.length is 3
+PASS TextTrackCue.length is 0
PASS TrackEvent.length is 1
PASS Uint16Array.length is 0
PASS Uint32Array.length is 0
Modified: trunk/Source/WebCore/ChangeLog (204764 => 204765)
--- trunk/Source/WebCore/ChangeLog 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/Source/WebCore/ChangeLog 2016-08-23 06:44:02 UTC (rev 204765)
@@ -1,5 +1,26 @@
2016-08-22 Chris Dumez <[email protected]>
+ Drop TextTrackCue's constructor as per the latest specification
+ https://bugs.webkit.org/show_bug.cgi?id=161061
+
+ Reviewed by Alex Christensen.
+
+ Drop TextTrackCue's constructor as per the latest specification:
+ - https://html.spec.whatwg.org/#texttrackcue
+
+ Firefox and Chrome do not have this constructor. Web Authors
+ are supposed to use the VTTCue constructor instead.
+
+ No new tests, rebaselined existing tests.
+
+ * html/track/TextTrackCue.cpp:
+ (WebCore::TextTrackCue::TextTrackCue): Deleted.
+ * html/track/TextTrackCue.h:
+ (WebCore::TextTrackCue::cueShadowPseudoId): Deleted.
+ * html/track/TextTrackCue.idl:
+
+2016-08-22 Chris Dumez <[email protected]>
+
Unreviewed, rolling out r204745.
Broke the Windows build
Modified: trunk/Source/WebCore/html/track/TextTrackCue.cpp (204764 => 204765)
--- trunk/Source/WebCore/html/track/TextTrackCue.cpp 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/Source/WebCore/html/track/TextTrackCue.cpp 2016-08-23 06:44:02 UTC (rev 204765)
@@ -54,16 +54,6 @@
static const int invalidCueIndex = -1;
-Ref<TextTrackCue> TextTrackCue::create(ScriptExecutionContext& context, double start, double end, const String& content)
-{
- return create(context, MediaTime::createWithDouble(start), MediaTime::createWithDouble(end), content);
-}
-
-Ref<TextTrackCue> TextTrackCue::create(ScriptExecutionContext& context, const MediaTime& start, const MediaTime& end, const String& content)
-{
- return VTTCue::create(context, start, end, content);
-}
-
TextTrackCue::TextTrackCue(ScriptExecutionContext& context, const MediaTime& start, const MediaTime& end)
: m_startTime(start)
, m_endTime(end)
Modified: trunk/Source/WebCore/html/track/TextTrackCue.h (204764 => 204765)
--- trunk/Source/WebCore/html/track/TextTrackCue.h 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/Source/WebCore/html/track/TextTrackCue.h 2016-08-23 06:44:02 UTC (rev 204765)
@@ -46,9 +46,6 @@
class TextTrackCue : public RefCounted<TextTrackCue>, public EventTargetWithInlineData {
public:
- static Ref<TextTrackCue> create(ScriptExecutionContext&, double start, double end, const String& content);
- static Ref<TextTrackCue> create(ScriptExecutionContext&, const MediaTime& start, const MediaTime& end, const String& content);
-
static const AtomicString& cueShadowPseudoId()
{
static NeverDestroyed<const AtomicString> cue("cue", AtomicString::ConstructFromLiteral);
Modified: trunk/Source/WebCore/html/track/TextTrackCue.idl (204764 => 204765)
--- trunk/Source/WebCore/html/track/TextTrackCue.idl 2016-08-23 06:35:25 UTC (rev 204764)
+++ trunk/Source/WebCore/html/track/TextTrackCue.idl 2016-08-23 06:44:02 UTC (rev 204765)
@@ -25,8 +25,6 @@
[
Conditional=VIDEO_TRACK,
- Constructor(unrestricted double startTime, unrestricted double endTime, DOMString text),
- ConstructorCallWith=ScriptExecutionContext,
JSCustomMarkFunction,
CustomIsReachable,
CustomToJSObject,
