Title: [204772] trunk/Source/WebKit2
- Revision
- 204772
- Author
- [email protected]
- Date
- 2016-08-23 00:09:38 -0700 (Tue, 23 Aug 2016)
Log Message
Use Messages::XXX...::Reply explicitly
https://bugs.webkit.org/show_bug.cgi?id=161075
Reviewed by Carlos Garcia Campos.
std::tuple's constructor is annotated as `explicit`.
So we cannot use the implicit conversion here.
This causes the build failure in EFL and GTK.
Looking through code, the other places use ::Reply explicitly.
So in this patch, we follow that.
* WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer):
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:
(WebKit::InjectedBundlePageFullScreenClient::supportsFullScreen):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (204771 => 204772)
--- trunk/Source/WebKit2/ChangeLog 2016-08-23 07:09:17 UTC (rev 204771)
+++ trunk/Source/WebKit2/ChangeLog 2016-08-23 07:09:38 UTC (rev 204772)
@@ -1,3 +1,22 @@
+2016-08-22 Yusuke Suzuki <[email protected]>
+
+ Use Messages::XXX...::Reply explicitly
+ https://bugs.webkit.org/show_bug.cgi?id=161075
+
+ Reviewed by Carlos Garcia Campos.
+
+ std::tuple's constructor is annotated as `explicit`.
+ So we cannot use the implicit conversion here.
+ This causes the build failure in EFL and GTK.
+
+ Looking through code, the other places use ::Reply explicitly.
+ So in this patch, we follow that.
+
+ * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
+ (WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer):
+ * WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:
+ (WebKit::InjectedBundlePageFullScreenClient::supportsFullScreen):
+
2016-08-22 Anders Carlsson <[email protected]>
Remove Arguments.h
Modified: trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp (204771 => 204772)
--- trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp 2016-08-23 07:09:17 UTC (rev 204771)
+++ trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp 2016-08-23 07:09:38 UTC (rev 204772)
@@ -63,7 +63,7 @@
{
relaxAdoptionRequirement();
- m_isOpenInServer = sendSync(Messages::DatabaseToWebProcessConnection::EstablishIDBConnectionToServer(), m_identifier);
+ m_isOpenInServer = sendSync(Messages::DatabaseToWebProcessConnection::EstablishIDBConnectionToServer(), Messages::DatabaseToWebProcessConnection::EstablishIDBConnectionToServer::Reply(m_identifier));
m_connectionToServer = IDBClient::IDBConnectionToServer::create(*this);
}
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp (204771 => 204772)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp 2016-08-23 07:09:17 UTC (rev 204771)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp 2016-08-23 07:09:38 UTC (rev 204772)
@@ -48,7 +48,7 @@
return m_client.supportsFullScreen(toAPI(page), withKeyboard);
bool supports = true;
- page->sendSync(Messages::WebFullScreenManagerProxy::SupportsFullScreen(withKeyboard), supports);
+ page->sendSync(Messages::WebFullScreenManagerProxy::SupportsFullScreen(withKeyboard), Messages::WebFullScreenManagerProxy::SupportsFullScreen::Reply(supports));
return supports;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
