Title: [204818] releases/WebKitGTK/webkit-2.12/Source/WebKit2
Revision
204818
Author
[email protected]
Date
2016-08-23 05:16:38 -0700 (Tue, 23 Aug 2016)

Log Message

Merge r204250 - [GTK] Bad performance in accelerated compositing mode with the modesetting intel driver and DRI3 enabled
https://bugs.webkit.org/show_bug.cgi?id=160491

Reviewed by Michael Catanzaro.

This is becoming the default in several linux distributions and it makes WebKitGTK+ unusable in accelerated
compositing mode, which is now always enabled because since we switched to use the threaded compositor. The
problem seems to be an optimization of the intel driver for windows that are offscreen, and our redirected
window is always positioned at ScreenWidth + 1, 0. Using negative coordinates to position the redirected window
offscreen fixes the problem.
See also https://bugs.freedesktop.org/show_bug.cgi?id=85064.

* WebProcess/WebPage/gtk/RedirectedXCompositeWindow.cpp:
(WebKit::RedirectedXCompositeWindow::RedirectedXCompositeWindow): Position the parent window at -1, -1.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.12/Source/WebKit2/ChangeLog (204817 => 204818)


--- releases/WebKitGTK/webkit-2.12/Source/WebKit2/ChangeLog	2016-08-23 12:14:05 UTC (rev 204817)
+++ releases/WebKitGTK/webkit-2.12/Source/WebKit2/ChangeLog	2016-08-23 12:16:38 UTC (rev 204818)
@@ -1,3 +1,20 @@
+2016-08-07  Carlos Garcia Campos  <[email protected]>
+
+        [GTK] Bad performance in accelerated compositing mode with the modesetting intel driver and DRI3 enabled
+        https://bugs.webkit.org/show_bug.cgi?id=160491
+
+        Reviewed by Michael Catanzaro.
+
+        This is becoming the default in several linux distributions and it makes WebKitGTK+ unusable in accelerated
+        compositing mode, which is now always enabled because since we switched to use the threaded compositor. The
+        problem seems to be an optimization of the intel driver for windows that are offscreen, and our redirected
+        window is always positioned at ScreenWidth + 1, 0. Using negative coordinates to position the redirected window
+        offscreen fixes the problem.
+        See also https://bugs.freedesktop.org/show_bug.cgi?id=85064.
+
+        * WebProcess/WebPage/gtk/RedirectedXCompositeWindow.cpp:
+        (WebKit::RedirectedXCompositeWindow::RedirectedXCompositeWindow): Position the parent window at -1, -1.
+
 2016-08-03  Michael Catanzaro  <[email protected]>
 
         [GTK] Document how to initialize WebKitFaviconDatabase

Modified: releases/WebKitGTK/webkit-2.12/Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp (204817 => 204818)


--- releases/WebKitGTK/webkit-2.12/Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp	2016-08-23 12:14:05 UTC (rev 204817)
+++ releases/WebKitGTK/webkit-2.12/Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp	2016-08-23 12:16:38 UTC (rev 204818)
@@ -158,7 +158,7 @@
 
     m_parentWindow = XCreateWindow(m_display,
         RootWindowOfScreen(screen),
-        WidthOfScreen(screen) + 1, 0, 1, 1,
+        -1, -1, 1, 1,
         0,
         gdk_visual_get_depth(visual),
         InputOutput,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to