Title: [204861] trunk/Source/_javascript_Core
- Revision
- 204861
- Author
- [email protected]
- Date
- 2016-08-23 15:16:46 -0700 (Tue, 23 Aug 2016)
Log Message
strict mode eval should not fire the var injection watch point
https://bugs.webkit.org/show_bug.cgi?id=161104
Reviewed by Geoffrey Garen.
Strict mode eval can't do any variable injections. It was
an oversight that we fired the var injection watchpoint when
the eval is in strict mode.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (204860 => 204861)
--- trunk/Source/_javascript_Core/ChangeLog 2016-08-23 21:47:20 UTC (rev 204860)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-08-23 22:16:46 UTC (rev 204861)
@@ -1,3 +1,17 @@
+2016-08-23 Saam Barati <[email protected]>
+
+ strict mode eval should not fire the var injection watch point
+ https://bugs.webkit.org/show_bug.cgi?id=161104
+
+ Reviewed by Geoffrey Garen.
+
+ Strict mode eval can't do any variable injections. It was
+ an oversight that we fired the var injection watchpoint when
+ the eval is in strict mode.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::Interpreter::execute):
+
2016-07-24 Filip Pizlo <[email protected]>
Spilling of constant tmps should make it easier for the spill code optimizer to rematerialize the constant
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (204860 => 204861)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2016-08-23 21:47:20 UTC (rev 204860)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2016-08-23 22:16:46 UTC (rev 204861)
@@ -1130,7 +1130,7 @@
if (numVariables || numFunctions) {
BatchedTransitionOptimizer optimizer(vm, variableObject);
- if (variableObject->next())
+ if (variableObject->next() && !eval->isStrictMode())
variableObject->globalObject()->varInjectionWatchpoint()->fireAll(vm, "Executed eval, fired VarInjection watchpoint");
for (unsigned i = 0; i < numVariables; ++i) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
