Diff
Modified: trunk/Source/WebCore/ChangeLog (204893 => 204894)
--- trunk/Source/WebCore/ChangeLog 2016-08-24 09:29:24 UTC (rev 204893)
+++ trunk/Source/WebCore/ChangeLog 2016-08-24 10:42:40 UTC (rev 204894)
@@ -1,3 +1,19 @@
+2016-08-24 Carlos Garcia Campos <[email protected]>
+
+ Unreviewed. Fix GObject DOM bindings API break after r204624 and r204648.
+
+ prefix, namespaceURI and localName attributes were moved from Node to Attr/Element in r204624 and prefix was
+ also made readonly in r204648.
+
+ * bindings/gobject/WebKitDOMDeprecated.cpp:
+ (webkit_dom_node_get_namespace_uri):
+ (webkit_dom_node_get_prefix):
+ (webkit_dom_node_set_prefix):
+ (webkit_dom_node_get_local_name):
+ * bindings/gobject/WebKitDOMDeprecated.h:
+ * bindings/gobject/WebKitDOMDeprecated.symbols:
+ * bindings/gobject/webkitdom.symbols:
+
2016-08-23 Simon Fraser <[email protected]>
Add some logging for WKSelectionDrawingInfo
Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp (204893 => 204894)
--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2016-08-24 09:29:24 UTC (rev 204893)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2016-08-24 10:42:40 UTC (rev 204894)
@@ -32,6 +32,7 @@
#include "WebKitDOMHTMLInputElementPrivate.h"
#include "WebKitDOMHTMLTitleElement.h"
#include "WebKitDOMNodeListPrivate.h"
+#include "WebKitDOMNodePrivate.h"
#include "WebKitDOMPrivate.h"
#include "WebKitDOMTextPrivate.h"
#include <wtf/GetPtr.h>
@@ -227,6 +228,47 @@
return webkit_dom_document_get_scripts(WEBKIT_DOM_DOCUMENT(self));
}
+gchar* webkit_dom_node_get_namespace_uri(WebKitDOMNode* self)
+{
+ g_return_val_if_fail(WEBKIT_DOM_IS_NODE(self), nullptr);
+
+ WebCore::JSMainThreadNullState state;
+ return convertToUTF8String(WebKit::core(self)->namespaceURI());
+}
+
+gchar* webkit_dom_node_get_prefix(WebKitDOMNode* self)
+{
+ g_return_val_if_fail(WEBKIT_DOM_IS_NODE(self), nullptr);
+ WebCore::JSMainThreadNullState state;
+ return convertToUTF8String(WebKit::core(self)->prefix());
+}
+
+void webkit_dom_node_set_prefix(WebKitDOMNode* self, const gchar* value, GError** error)
+{
+ g_return_if_fail(WEBKIT_DOM_IS_NODE(self));
+ g_return_if_fail(value);
+ g_return_if_fail(!error || !*error);
+
+ g_warning("%s: prefix is now a readonly property according to the DOM spec.", __func__);
+
+ WebCore::JSMainThreadNullState state;
+ WebCore::Node* item = WebKit::core(self);
+ WTF::String convertedValue = WTF::String::fromUTF8(value);
+ WebCore::ExceptionCode ec = 0;
+ item->setPrefix(convertedValue, ec);
+ if (ec) {
+ WebCore::ExceptionCodeDescription ecdesc(ec);
+ g_set_error_literal(error, g_quark_from_string("WEBKIT_DOM"), ecdesc.code, ecdesc.name);
+ }
+}
+
+gchar* webkit_dom_node_get_local_name(WebKitDOMNode* self)
+{
+ g_return_val_if_fail(WEBKIT_DOM_IS_NODE(self), nullptr);
+ WebCore::JSMainThreadNullState state;
+ return convertToUTF8String(WebKit::core(self)->localName());
+}
+
G_DEFINE_TYPE(WebKitDOMEntityReference, webkit_dom_entity_reference, WEBKIT_DOM_TYPE_NODE)
static void webkit_dom_entity_reference_init(WebKitDOMEntityReference*)
Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h (204893 => 204894)
--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h 2016-08-24 09:29:24 UTC (rev 204893)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h 2016-08-24 10:42:40 UTC (rev 204894)
@@ -291,6 +291,50 @@
WEBKIT_DEPRECATED_FOR(webkit_dom_document_get_scripts) WebKitDOMHTMLCollection*
webkit_dom_html_document_get_scripts(WebKitDOMHTMLDocument* self);
+/**
+ * webkit_dom_node_get_namespace_uri:
+ * @self: A #WebKitDOMNode
+ *
+ * Returns: A #gchar
+ *
+ * Deprecated: 2.14: Use webkit_dom_attr_get_namespace_uri() or webkit_dom_element_get_namespace_uri() instead.
+ */
+WEBKIT_DEPRECATED gchar*
+webkit_dom_node_get_namespace_uri(WebKitDOMNode* self);
+
+/**
+ * webkit_dom_node_get_prefix:
+ * @self: A #WebKitDOMNode
+ *
+ * Returns: A #gchar
+ *
+ * Deprecated: 2.14: Use webkit_dom_attr_get_prefix() or webkit_dom_element_get_prefix() instead.
+ */
+WEBKIT_DEPRECATED gchar*
+webkit_dom_node_get_prefix(WebKitDOMNode* self);
+
+/**
+ * webkit_dom_node_set_prefix:
+ * @self: A #WebKitDOMNode
+ * @value: A #gchar
+ * @error: #GError
+ *
+ * Deprecated: 2.14
+ */
+WEBKIT_DEPRECATED void
+webkit_dom_node_set_prefix(WebKitDOMNode* self, const gchar* value, GError** error);
+
+/**
+ * webkit_dom_node_get_local_name:
+ * @self: A #WebKitDOMNode
+ *
+ * Returns: A #gchar
+ *
+ * Deprecated: 2.14: Use webkit_dom_attr_get_local_name() or webkit_dom_element_get_local_name() instead.
+ */
+WEBKIT_DEPRECATED gchar*
+webkit_dom_node_get_local_name(WebKitDOMNode* self);
+
#define WEBKIT_DOM_TYPE_ENTITY_REFERENCE (webkit_dom_entity_reference_get_type())
#define WEBKIT_DOM_ENTITY_REFERENCE(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj), WEBKIT_DOM_TYPE_ENTITY_REFERENCE, WebKitDOMEntityReference))
#define WEBKIT_DOM_ENTITY_REFERENCE_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST((klass), WEBKIT_DOM_TYPE_ENTITY_REFERENCE, WebKitDOMEntityReferenceClass)
Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols (204893 => 204894)
--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols 2016-08-24 09:29:24 UTC (rev 204893)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols 2016-08-24 10:42:40 UTC (rev 204894)
@@ -32,3 +32,7 @@
WebKitDOMHTMLCollection* webkit_dom_html_document_get_scripts(WebKitDOMHTMLDocument*)
WebKitDOMHTMLCollection* webkit_dom_html_document_get_embeds(WebKitDOMHTMLDocument*)
WebKitDOMHTMLCollection* webkit_dom_html_document_get_plugins(WebKitDOMHTMLDocument*)
+gchar* webkit_dom_node_get_namespace_uri(WebKitDOMNode*)
+gchar* webkit_dom_node_get_prefix(WebKitDOMNode*)
+void webkit_dom_node_set_prefix(WebKitDOMNode*, const gchar*, GError**)
+gchar* webkit_dom_node_get_local_name(WebKitDOMNode*)
Modified: trunk/Source/WebCore/bindings/gobject/webkitdom.symbols (204893 => 204894)
--- trunk/Source/WebCore/bindings/gobject/webkitdom.symbols 2016-08-24 09:29:24 UTC (rev 204893)
+++ trunk/Source/WebCore/bindings/gobject/webkitdom.symbols 2016-08-24 10:42:40 UTC (rev 204894)
@@ -1,5 +1,8 @@
GType webkit_dom_attr_get_type(void)
+gchar* webkit_dom_attr_get_local_name(WebKitDOMAttr*)@2.14
gchar* webkit_dom_attr_get_name(WebKitDOMAttr*)
+gchar* webkit_dom_attr_get_namespace_uri(WebKitDOMAttr*)@2.14
+gchar* webkit_dom_attr_get_prefix(WebKitDOMAttr*)@2.14
gboolean webkit_dom_attr_get_specified(WebKitDOMAttr*)
gchar* webkit_dom_attr_get_value(WebKitDOMAttr*)
void webkit_dom_attr_set_value(WebKitDOMAttr*, const gchar*, GError**)
@@ -119,6 +122,9 @@
GType webkit_dom_element_get_type(void)
gchar* webkit_dom_element_get_id(WebKitDOMElement*)
void webkit_dom_element_set_id(WebKitDOMElement*, const gchar*)
+gchar* webkit_dom_element_get_namespace_uri(WebKitDOMElement*)@2.14
+gchar* webkit_dom_element_get_local_name(WebKitDOMElement*)@2.14
+gchar* webkit_dom_element_get_prefix(WebKitDOMElement*)@2.14
WebKitDOMCSSStyleDeclaration* webkit_dom_element_get_style(WebKitDOMElement*)
gchar* webkit_dom_element_get_class_name(WebKitDOMElement*)
void webkit_dom_element_set_class_name(WebKitDOMElement*, const gchar*)