Title: [204957] trunk/Tools
- Revision
- 204957
- Author
- [email protected]
- Date
- 2016-08-24 23:51:04 -0700 (Wed, 24 Aug 2016)
Log Message
[Win] run-api-tests is failing.
https://bugs.webkit.org/show_bug.cgi?id=161140
Reviewed by Brent Fulgham.
The number of times the move constructor is called is different on Windows in this test. This seems
to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
* TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (204956 => 204957)
--- trunk/Tools/ChangeLog 2016-08-25 06:31:58 UTC (rev 204956)
+++ trunk/Tools/ChangeLog 2016-08-25 06:51:04 UTC (rev 204957)
@@ -1,3 +1,16 @@
+2016-08-24 Per Arne Vollan <[email protected]>
+
+ [Win] run-api-tests is failing.
+ https://bugs.webkit.org/show_bug.cgi?id=161140
+
+ Reviewed by Brent Fulgham.
+
+ The number of times the move constructor is called is different on Windows in this test. This seems
+ to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
+
+ * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
+ (TestWebKitAPI::TEST):
+
2016-08-24 Simon Fraser <[email protected]>
Fix iOS DRT build.
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp (204956 => 204957)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp 2016-08-25 06:31:58 UTC (rev 204956)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp 2016-08-25 06:51:04 UTC (rev 204957)
@@ -123,7 +123,13 @@
ASSERT_EQ(2u, copyConstructorSet.count("<default>-1-0"));
ASSERT_EQ(1u, copyConstructorSet.count("<default>-2-0"));
+#if !COMPILER(MSVC)
ASSERT_EQ(6u, moveConstructorSet.size());
+#else
+ // The number of times the move constructor is called is different on Windows in this test.
+ // This seems to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
+ ASSERT_EQ(9u, moveConstructorSet.size());
+#endif
ASSERT_EQ(1u, moveConstructorSet.count("logger-1-1"));
ASSERT_EQ(1u, moveConstructorSet.count("logger-1-2"));
ASSERT_EQ(1u, moveConstructorSet.count("<default>-2-1"));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
