Diff
Modified: trunk/Source/WebCore/ChangeLog (205092 => 205093)
--- trunk/Source/WebCore/ChangeLog 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/ChangeLog 2016-08-28 00:40:24 UTC (rev 205093)
@@ -1,3 +1,85 @@
+2016-08-27 Rawinder Singh <[email protected]>
+
+ Add final keyword to final classes and overriden methods in WebCore/css
+ https://bugs.webkit.org/show_bug.cgi?id=161182
+
+ Reviewed by Darin Adler.
+
+ - Mark classes in the WebCore/css directory final as appropriate.
+ - Update WebCore/css classes so that overriden methods in final classes are marked final.
+
+ * css/CSSAnimationTriggerScrollValue.h:
+ * css/CSSAspectRatioValue.h:
+ * css/CSSBasicShapes.h:
+ * css/CSSBorderImageSliceValue.h:
+ * css/CSSCalculationValue.cpp:
+ (WebCore::determineCategory):
+ * css/CSSCalculationValue.h:
+ * css/CSSCanvasValue.h:
+ * css/CSSCharsetRule.h:
+ * css/CSSComputedStyleDeclaration.h:
+ * css/CSSContentDistributionValue.h:
+ * css/CSSCrossfadeValue.h:
+ * css/CSSCursorImageValue.h:
+ * css/CSSCustomPropertyValue.h:
+ * css/CSSFilterImageValue.h:
+ * css/CSSFontFaceLoadEvent.h:
+ * css/CSSFontFaceSrcValue.h:
+ * css/CSSFontFeatureValue.h:
+ * css/CSSFontSelector.h:
+ * css/CSSFontValue.h:
+ * css/CSSFunctionValue.h:
+ * css/CSSGradientValue.h:
+ * css/CSSGridAutoRepeatValue.h:
+ * css/CSSGridLineNamesValue.h:
+ * css/CSSGridTemplateAreasValue.h:
+ * css/CSSImageSetValue.h:
+ * css/CSSImageValue.h:
+ * css/CSSInheritedValue.h:
+ * css/CSSInitialValue.h:
+ * css/CSSKeyframeRule.h:
+ * css/CSSKeyframesRule.h:
+ * css/CSSLineBoxContainValue.h:
+ * css/CSSNamedImageValue.h:
+ * css/CSSPrimitiveValue.h:
+ * css/CSSReflectValue.h:
+ * css/CSSRevertValue.h:
+ * css/CSSRuleList.h:
+ * css/CSSSegmentedFontFace.h:
+ * css/CSSShadowValue.h:
+ * css/CSSStyleSheet.cpp:
+ * css/CSSStyleSheet.h:
+ * css/CSSSupportsRule.h:
+ * css/CSSTimingFunctionValue.h:
+ * css/CSSUnicodeRangeValue.h:
+ * css/CSSUnknownRule.h:
+ * css/CSSUnsetValue.h:
+ * css/CSSValue.cpp:
+ * css/CSSVariableDependentValue.h:
+ * css/CSSVariableValue.h:
+ * css/Counter.h:
+ * css/DOMCSSNamespace.h:
+ * css/DashboardRegion.h:
+ * css/LengthRepeat.h:
+ * css/MediaList.h:
+ * css/MediaQueryList.h:
+ * css/MediaQueryMatcher.h:
+ * css/Pair.h:
+ * css/PropertySetCSSStyleDeclaration.h:
+ * css/RGBColor.h:
+ * css/Rect.h:
+ * css/StyleMedia.h:
+ * css/StyleProperties.h:
+ * css/StyleRule.h:
+ * css/StyleRuleImport.h:
+ * css/StyleSheetContents.h:
+ * css/StyleSheetList.h:
+ * css/ViewportStyleResolver.h:
+ * css/WebKitCSSFilterValue.h:
+ * css/WebKitCSSRegionRule.h:
+ * css/WebKitCSSTransformValue.h:
+ * css/WebKitCSSViewportRule.h:
+
2016-08-27 Simon Fraser <[email protected]>
Add more Editing logging
Modified: trunk/Source/WebCore/css/CSSAnimationTriggerScrollValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSAnimationTriggerScrollValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSAnimationTriggerScrollValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -31,7 +31,7 @@
namespace WebCore {
-class CSSAnimationTriggerScrollValue : public CSSValue {
+class CSSAnimationTriggerScrollValue final : public CSSValue {
public:
static Ref<CSSAnimationTriggerScrollValue> create(Ref<CSSValue>&& startValue, RefPtr<CSSValue>&& endValue = nullptr)
{
Modified: trunk/Source/WebCore/css/CSSAspectRatioValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSAspectRatioValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSAspectRatioValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -32,7 +32,7 @@
namespace WebCore {
-class CSSAspectRatioValue : public CSSValue {
+class CSSAspectRatioValue final : public CSSValue {
public:
static Ref<CSSAspectRatioValue> create(float numeratorValue, float denominatorValue)
{
Modified: trunk/Source/WebCore/css/CSSBasicShapes.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSBasicShapes.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSBasicShapes.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -112,9 +112,9 @@
private:
CSSBasicShapeInset() { }
- Type type() const override { return CSSBasicShapeInsetType; }
- String cssText() const override;
- bool equals(const CSSBasicShape&) const override;
+ Type type() const final { return CSSBasicShapeInsetType; }
+ String cssText() const final;
+ bool equals(const CSSBasicShape&) const final;
RefPtr<CSSPrimitiveValue> m_top;
RefPtr<CSSPrimitiveValue> m_right;
@@ -142,9 +142,9 @@
private:
CSSBasicShapeCircle() { }
- Type type() const override { return CSSBasicShapeCircleType; }
- String cssText() const override;
- bool equals(const CSSBasicShape&) const override;
+ Type type() const final { return CSSBasicShapeCircleType; }
+ String cssText() const final;
+ bool equals(const CSSBasicShape&) const final;
RefPtr<CSSPrimitiveValue> m_centerX;
RefPtr<CSSPrimitiveValue> m_centerY;
@@ -168,9 +168,9 @@
private:
CSSBasicShapeEllipse() { }
- Type type() const override { return CSSBasicShapeEllipseType; }
- String cssText() const override;
- bool equals(const CSSBasicShape&) const override;
+ Type type() const final { return CSSBasicShapeEllipseType; }
+ String cssText() const final;
+ bool equals(const CSSBasicShape&) const final;
RefPtr<CSSPrimitiveValue> m_centerX;
RefPtr<CSSPrimitiveValue> m_centerY;
@@ -199,9 +199,9 @@
{
}
- Type type() const override { return CSSBasicShapePolygonType; }
- String cssText() const override;
- bool equals(const CSSBasicShape&) const override;
+ Type type() const final { return CSSBasicShapePolygonType; }
+ String cssText() const final;
+ bool equals(const CSSBasicShape&) const final;
Vector<Ref<CSSPrimitiveValue>> m_values;
WindRule m_windRule;
@@ -225,9 +225,9 @@
private:
CSSBasicShapePath(std::unique_ptr<SVGPathByteStream>&&);
- Type type() const override { return CSSBasicShapePathType; }
- String cssText() const override;
- bool equals(const CSSBasicShape&) const override;
+ Type type() const final { return CSSBasicShapePathType; }
+ String cssText() const final;
+ bool equals(const CSSBasicShape&) const final;
std::unique_ptr<SVGPathByteStream> m_byteStream;
WindRule m_windRule { RULE_NONZERO };
Modified: trunk/Source/WebCore/css/CSSBorderImageSliceValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSBorderImageSliceValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSBorderImageSliceValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -32,7 +32,7 @@
class Rect;
-class CSSBorderImageSliceValue : public CSSValue {
+class CSSBorderImageSliceValue final : public CSSValue {
public:
static Ref<CSSBorderImageSliceValue> create(RefPtr<CSSPrimitiveValue>&& slices, bool fill)
{
Modified: trunk/Source/WebCore/css/CSSCalculationValue.cpp (205092 => 205093)
--- trunk/Source/WebCore/css/CSSCalculationValue.cpp 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSCalculationValue.cpp 2016-08-28 00:40:24 UTC (rev 205093)
@@ -213,17 +213,17 @@
}
private:
- bool isZero() const override
+ bool isZero() const final
{
return !m_value->getDoubleValue();
}
- String customCSSText() const override
+ String customCSSText() const final
{
return m_value->cssText();
}
- std::unique_ptr<CalcExpressionNode> createCalcExpression(const CSSToLengthConversionData& conversionData) const override
+ std::unique_ptr<CalcExpressionNode> createCalcExpression(const CSSToLengthConversionData& conversionData) const final
{
switch (category()) {
case CalcNumber:
@@ -247,7 +247,7 @@
return nullptr;
}
- double doubleValue() const override
+ double doubleValue() const final
{
if (hasDoubleValue(primitiveType()))
return m_value->getDoubleValue();
@@ -255,7 +255,7 @@
return 0;
}
- double computeLengthPx(const CSSToLengthConversionData& conversionData) const override
+ double computeLengthPx(const CSSToLengthConversionData& conversionData) const final
{
switch (category()) {
case CalcLength:
@@ -276,7 +276,7 @@
return 0;
}
- bool equals(const CSSCalcExpressionNode& other) const override
+ bool equals(const CSSCalcExpressionNode& other) const final
{
if (type() != other.type())
return false;
@@ -284,8 +284,8 @@
return compareCSSValue(m_value, static_cast<const CSSCalcPrimitiveValue&>(other).m_value);
}
- Type type() const override { return CssCalcPrimitiveValue; }
- CSSPrimitiveValue::UnitTypes primitiveType() const override
+ Type type() const final { return CssCalcPrimitiveValue; }
+ CSSPrimitiveValue::UnitTypes primitiveType() const final
{
return CSSPrimitiveValue::UnitTypes(m_value->primitiveType());
}
@@ -420,12 +420,12 @@
}
private:
- bool isZero() const override
+ bool isZero() const final
{
return !doubleValue();
}
- std::unique_ptr<CalcExpressionNode> createCalcExpression(const CSSToLengthConversionData& conversionData) const override
+ std::unique_ptr<CalcExpressionNode> createCalcExpression(const CSSToLengthConversionData& conversionData) const final
{
std::unique_ptr<CalcExpressionNode> left(m_leftSide->createCalcExpression(conversionData));
if (!left)
@@ -436,12 +436,12 @@
return std::make_unique<CalcExpressionBinaryOperation>(WTFMove(left), WTFMove(right), m_operator);
}
- double doubleValue() const override
+ double doubleValue() const final
{
return evaluate(m_leftSide->doubleValue(), m_rightSide->doubleValue());
}
- double computeLengthPx(const CSSToLengthConversionData& conversionData) const override
+ double computeLengthPx(const CSSToLengthConversionData& conversionData) const final
{
const double leftValue = m_leftSide->computeLengthPx(conversionData);
const double rightValue = m_rightSide->computeLengthPx(conversionData);
@@ -462,12 +462,12 @@
return result.toString();
}
- String customCSSText() const override
+ String customCSSText() const final
{
return buildCssText(m_leftSide->customCSSText(), m_rightSide->customCSSText(), m_operator);
}
- bool equals(const CSSCalcExpressionNode& exp) const override
+ bool equals(const CSSCalcExpressionNode& exp) const final
{
if (type() != exp.type())
return false;
@@ -478,9 +478,9 @@
&& m_operator == other.m_operator;
}
- Type type() const override { return CssCalcBinaryOperation; }
+ Type type() const final { return CssCalcBinaryOperation; }
- CSSPrimitiveValue::UnitTypes primitiveType() const override
+ CSSPrimitiveValue::UnitTypes primitiveType() const final
{
switch (category()) {
case CalcNumber:
Modified: trunk/Source/WebCore/css/CSSCalculationValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSCalculationValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSCalculationValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -85,7 +85,7 @@
bool m_isInteger;
};
-class CSSCalcValue : public CSSValue {
+class CSSCalcValue final : public CSSValue {
public:
static RefPtr<CSSCalcValue> create(CSSParserString name, CSSParserValueList& arguments, CalculationPermittedValueRange);
static RefPtr<CSSCalcValue> create(const CalculationValue&, const RenderStyle&);
Modified: trunk/Source/WebCore/css/CSSCanvasValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSCanvasValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSCanvasValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -33,7 +33,7 @@
class Document;
class HTMLCanvasElement;
-class CSSCanvasValue : public CSSImageGeneratorValue {
+class CSSCanvasValue final : public CSSImageGeneratorValue {
public:
static Ref<CSSCanvasValue> create(const String& name) { return adoptRef(*new CSSCanvasValue(name)); }
~CSSCanvasValue();
@@ -71,15 +71,15 @@
}
private:
- void canvasChanged(HTMLCanvasElement& canvas, const FloatRect& changedRect) override
+ void canvasChanged(HTMLCanvasElement& canvas, const FloatRect& changedRect) final
{
m_ownerValue.canvasChanged(canvas, changedRect);
}
- void canvasResized(HTMLCanvasElement& canvas) override
+ void canvasResized(HTMLCanvasElement& canvas) final
{
m_ownerValue.canvasResized(canvas);
}
- void canvasDestroyed(HTMLCanvasElement& canvas) override
+ void canvasDestroyed(HTMLCanvasElement& canvas) final
{
m_ownerValue.canvasDestroyed(canvas);
}
Modified: trunk/Source/WebCore/css/CSSCharsetRule.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSCharsetRule.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSCharsetRule.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -35,14 +35,14 @@
virtual ~CSSCharsetRule() { }
- String cssText() const override;
- void reattach(StyleRuleBase&) override { }
+ String cssText() const final;
+ void reattach(StyleRuleBase&) final { }
const String& encoding() const { return m_encoding; }
void setEncoding(const String& encoding, ExceptionCode&) { m_encoding = encoding; }
private:
- CSSRule::Type type() const override { return CHARSET_RULE; }
+ CSSRule::Type type() const final { return CHARSET_RULE; }
CSSCharsetRule(CSSStyleSheet* parent, const String& encoding);
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -94,8 +94,8 @@
}
virtual ~CSSComputedStyleDeclaration();
- WEBCORE_EXPORT void ref() override;
- WEBCORE_EXPORT void deref() override;
+ WEBCORE_EXPORT void ref() final;
+ WEBCORE_EXPORT void deref() final;
String getPropertyValue(CSSPropertyID) const;
@@ -103,22 +103,22 @@
WEBCORE_EXPORT CSSComputedStyleDeclaration(Element&, bool allowVisitedStyle, const String&);
// CSSOM functions. Don't make these public.
- CSSRule* parentRule() const override;
- unsigned length() const override;
- String item(unsigned index) const override;
- RefPtr<CSSValue> getPropertyCSSValue(const String& propertyName) override;
- String getPropertyValue(const String& propertyName) override;
- String getPropertyPriority(const String& propertyName) override;
- String getPropertyShorthand(const String& propertyName) override;
- bool isPropertyImplicit(const String& propertyName) override;
- void setProperty(const String& propertyName, const String& value, const String& priority, ExceptionCode&) override;
- String removeProperty(const String& propertyName, ExceptionCode&) override;
- String cssText() const override;
- void setCssText(const String&, ExceptionCode&) override;
- RefPtr<CSSValue> getPropertyCSSValueInternal(CSSPropertyID) override;
- String getPropertyValueInternal(CSSPropertyID) override;
- bool setPropertyInternal(CSSPropertyID, const String& value, bool important, ExceptionCode&) override;
- Ref<MutableStyleProperties> copyProperties() const override;
+ CSSRule* parentRule() const final;
+ unsigned length() const final;
+ String item(unsigned index) const final;
+ RefPtr<CSSValue> getPropertyCSSValue(const String& propertyName) final;
+ String getPropertyValue(const String& propertyName) final;
+ String getPropertyPriority(const String& propertyName) final;
+ String getPropertyShorthand(const String& propertyName) final;
+ bool isPropertyImplicit(const String& propertyName) final;
+ void setProperty(const String& propertyName, const String& value, const String& priority, ExceptionCode&) final;
+ String removeProperty(const String& propertyName, ExceptionCode&) final;
+ String cssText() const final;
+ void setCssText(const String&, ExceptionCode&) final;
+ RefPtr<CSSValue> getPropertyCSSValueInternal(CSSPropertyID) final;
+ String getPropertyValueInternal(CSSPropertyID) final;
+ bool setPropertyInternal(CSSPropertyID, const String& value, bool important, ExceptionCode&) final;
+ Ref<MutableStyleProperties> copyProperties() const final;
RefPtr<CSSValue> getPropertyCSSValue(CSSPropertyID, EUpdateLayout = UpdateLayout) const;
Modified: trunk/Source/WebCore/css/CSSContentDistributionValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSContentDistributionValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSContentDistributionValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -32,7 +32,7 @@
namespace WebCore {
-class CSSContentDistributionValue : public CSSValue {
+class CSSContentDistributionValue final : public CSSValue {
public:
static Ref<CSSContentDistributionValue> create(CSSValueID distribution, CSSValueID position, CSSValueID overflow)
{
Modified: trunk/Source/WebCore/css/CSSCrossfadeValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSCrossfadeValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSCrossfadeValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -40,7 +40,7 @@
class RenderElement;
class Document;
-class CSSCrossfadeValue : public CSSImageGeneratorValue {
+class CSSCrossfadeValue final : public CSSImageGeneratorValue {
friend class CrossfadeSubimageObserverProxy;
public:
static Ref<CSSCrossfadeValue> create(Ref<CSSValue>&& fromValue, Ref<CSSValue>&& toValue, Ref<CSSPrimitiveValue>&& percentageValue, bool prefixed = false)
@@ -90,7 +90,7 @@
}
virtual ~CrossfadeSubimageObserverProxy() { }
- void imageChanged(CachedImage*, const IntRect* = nullptr) override;
+ void imageChanged(CachedImage*, const IntRect* = nullptr) final;
void setReady(bool ready) { m_ready = ready; }
private:
CSSCrossfadeValue* m_ownerValue;
Modified: trunk/Source/WebCore/css/CSSCursorImageValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSCursorImageValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSCursorImageValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -32,7 +32,7 @@
class SVGCursorElement;
class SVGElement;
-class CSSCursorImageValue : public CSSValue {
+class CSSCursorImageValue final : public CSSValue {
public:
static Ref<CSSCursorImageValue> create(Ref<CSSValue>&& imageValue, bool hasHotSpot, const IntPoint& hotSpot)
{
Modified: trunk/Source/WebCore/css/CSSCustomPropertyValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSCustomPropertyValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSCustomPropertyValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -32,7 +32,7 @@
namespace WebCore {
-class CSSCustomPropertyValue : public CSSValue {
+class CSSCustomPropertyValue final : public CSSValue {
public:
static Ref<CSSCustomPropertyValue> create(const AtomicString& name, Ref<CSSValue>&& value)
{
Modified: trunk/Source/WebCore/css/CSSFilterImageValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSFilterImageValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSFilterImageValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -43,7 +43,7 @@
class Document;
class StyleResolver;
-class CSSFilterImageValue : public CSSImageGeneratorValue {
+class CSSFilterImageValue final : public CSSImageGeneratorValue {
friend class FilterSubimageObserverProxy;
public:
static Ref<CSSFilterImageValue> create(Ref<CSSValue>&& imageValue, Ref<CSSValue>&& filterValue)
@@ -97,7 +97,7 @@
}
virtual ~FilterSubimageObserverProxy() { }
- void imageChanged(CachedImage*, const IntRect* = nullptr) override;
+ void imageChanged(CachedImage*, const IntRect* = nullptr) final;
void setReady(bool ready) { m_ready = ready; }
private:
CSSFilterImageValue* m_ownerValue;
Modified: trunk/Source/WebCore/css/CSSFontFaceLoadEvent.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSFontFaceLoadEvent.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSFontFaceLoadEvent.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -74,7 +74,7 @@
CSSFontFaceRule* fontface() const { return m_fontface.get(); }
DOMError* error() const { return m_error.get(); }
- EventInterface eventInterface() const override;
+ EventInterface eventInterface() const final;
private:
CSSFontFaceLoadEvent();
Modified: trunk/Source/WebCore/css/CSSFontFaceSrcValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSFontFaceSrcValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSFontFaceSrcValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -36,7 +36,7 @@
class Document;
class SVGFontFaceElement;
-class CSSFontFaceSrcValue : public CSSValue {
+class CSSFontFaceSrcValue final : public CSSValue {
public:
static Ref<CSSFontFaceSrcValue> create(const String& resource)
{
Modified: trunk/Source/WebCore/css/CSSFontFeatureValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSFontFeatureValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSFontFeatureValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -31,7 +31,7 @@
namespace WebCore {
-class CSSFontFeatureValue : public CSSValue {
+class CSSFontFeatureValue final : public CSSValue {
public:
static Ref<CSSFontFeatureValue> create(FontFeatureTag&& tag, int value)
{
Modified: trunk/Source/WebCore/css/CSSFontSelector.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSFontSelector.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSFontSelector.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -56,12 +56,12 @@
}
virtual ~CSSFontSelector();
- unsigned version() const override { return m_version; }
- unsigned uniqueId() const override { return m_uniqueId; }
+ unsigned version() const final { return m_version; }
+ unsigned uniqueId() const final { return m_uniqueId; }
- FontRanges fontRangesForFamily(const FontDescription&, const AtomicString&) override;
- size_t fallbackFontCount() override;
- RefPtr<Font> fallbackFontAt(const FontDescription&, size_t) override;
+ FontRanges fontRangesForFamily(const FontDescription&, const AtomicString&) final;
+ size_t fallbackFontCount() final;
+ RefPtr<Font> fallbackFontAt(const FontDescription&, size_t) final;
void clearDocument();
void buildStarted();
@@ -70,12 +70,12 @@
void addFontFaceRule(StyleRuleFontFace&, bool isInitiatingElementInUserAgentShadowTree);
void fontLoaded();
- void fontCacheInvalidated() override;
+ void fontCacheInvalidated() final;
bool isEmpty() const;
- void registerForInvalidationCallbacks(FontSelectorClient&) override;
- void unregisterForInvalidationCallbacks(FontSelectorClient&) override;
+ void registerForInvalidationCallbacks(FontSelectorClient&) final;
+ void unregisterForInvalidationCallbacks(FontSelectorClient&) final;
Document* document() const { return m_document; }
@@ -88,7 +88,7 @@
void dispatchInvalidationCallbacks();
- void fontModified() override;
+ void fontModified() final;
void beginLoadTimerFired();
Modified: trunk/Source/WebCore/css/CSSFontValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSFontValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSFontValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -28,7 +28,7 @@
class CSSPrimitiveValue;
class CSSValueList;
-class CSSFontValue : public CSSValue {
+class CSSFontValue final : public CSSValue {
public:
static Ref<CSSFontValue> create()
{
Modified: trunk/Source/WebCore/css/CSSFunctionValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSFunctionValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSFunctionValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -33,7 +33,7 @@
struct CSSParserFunction;
struct CSSParserValue;
-class CSSFunctionValue : public CSSValue {
+class CSSFunctionValue final : public CSSValue {
public:
static Ref<CSSFunctionValue> create(CSSParserFunction* function)
{
Modified: trunk/Source/WebCore/css/CSSGradientValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSGradientValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSGradientValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -130,7 +130,7 @@
bool m_repeating;
};
-class CSSLinearGradientValue : public CSSGradientValue {
+class CSSLinearGradientValue final : public CSSGradientValue {
public:
static Ref<CSSLinearGradientValue> create(CSSGradientRepeat repeat, CSSGradientType gradientType = CSSLinearGradient)
@@ -167,7 +167,7 @@
RefPtr<CSSPrimitiveValue> m_angle; // may be null.
};
-class CSSRadialGradientValue : public CSSGradientValue {
+class CSSRadialGradientValue final : public CSSGradientValue {
public:
static Ref<CSSRadialGradientValue> create(CSSGradientRepeat repeat, CSSGradientType gradientType = CSSRadialGradient)
{
Modified: trunk/Source/WebCore/css/CSSGridAutoRepeatValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSGridAutoRepeatValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSGridAutoRepeatValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -49,7 +49,7 @@
// better but the CSSWG has left the door open to allow more than one track in the
// future. That's why we're using a list, it's prepared for future changes and it also
// allows us to keep the parsing algorithm almost intact.
-class CSSGridAutoRepeatValue : public CSSValueList {
+class CSSGridAutoRepeatValue final : public CSSValueList {
public:
static Ref<CSSGridAutoRepeatValue> create(CSSValueID id)
{
Modified: trunk/Source/WebCore/css/CSSGridLineNamesValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSGridLineNamesValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSGridLineNamesValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -36,7 +36,7 @@
namespace WebCore {
-class CSSGridLineNamesValue : public CSSValueList {
+class CSSGridLineNamesValue final : public CSSValueList {
public:
static Ref<CSSGridLineNamesValue> create()
{
Modified: trunk/Source/WebCore/css/CSSGridTemplateAreasValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSGridTemplateAreasValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSGridTemplateAreasValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -39,7 +39,7 @@
namespace WebCore {
-class CSSGridTemplateAreasValue : public CSSValue {
+class CSSGridTemplateAreasValue final : public CSSValue {
public:
static Ref<CSSGridTemplateAreasValue> create(const NamedGridAreaMap& gridAreaMap, size_t rowCount, size_t columnCount)
{
Modified: trunk/Source/WebCore/css/CSSImageSetValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSImageSetValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSImageSetValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -36,7 +36,7 @@
class StyleImage;
struct ResourceLoaderOptions;
-class CSSImageSetValue : public CSSValueList {
+class CSSImageSetValue final : public CSSValueList {
public:
static Ref<CSSImageSetValue> create()
Modified: trunk/Source/WebCore/css/CSSImageValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSImageValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSImageValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -33,7 +33,7 @@
class RenderElement;
struct ResourceLoaderOptions;
-class CSSImageValue : public CSSValue {
+class CSSImageValue final : public CSSValue {
public:
static Ref<CSSImageValue> create(const String& url) { return adoptRef(*new CSSImageValue(url)); }
static Ref<CSSImageValue> create(const String& url, StyleImage* image) { return adoptRef(*new CSSImageValue(url, image)); }
Modified: trunk/Source/WebCore/css/CSSInheritedValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSInheritedValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSInheritedValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -26,7 +26,7 @@
namespace WebCore {
-class CSSInheritedValue : public CSSValue {
+class CSSInheritedValue final : public CSSValue {
public:
String customCSSText() const;
Modified: trunk/Source/WebCore/css/CSSInitialValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSInitialValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSInitialValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -26,7 +26,7 @@
namespace WebCore {
-class CSSInitialValue : public CSSValue {
+class CSSInitialValue final : public CSSValue {
public:
static Ref<CSSInitialValue> createExplicit()
{
Modified: trunk/Source/WebCore/css/CSSKeyframeRule.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSKeyframeRule.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSKeyframeRule.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -36,7 +36,7 @@
class StyleRuleCSSStyleDeclaration;
class CSSKeyframesRule;
-class StyleKeyframe : public RefCounted<StyleKeyframe> {
+class StyleKeyframe final : public RefCounted<StyleKeyframe> {
WTF_MAKE_FAST_ALLOCATED;
public:
static Ref<StyleKeyframe> create(Ref<StyleProperties>&& properties)
@@ -72,8 +72,8 @@
public:
virtual ~CSSKeyframeRule();
- String cssText() const override { return m_keyframe->cssText(); }
- void reattach(StyleRuleBase&) override;
+ String cssText() const final { return m_keyframe->cssText(); }
+ void reattach(StyleRuleBase&) final;
String keyText() const { return m_keyframe->keyText(); }
void setKeyText(const String& text) { m_keyframe->setKeyText(text); }
@@ -83,7 +83,7 @@
private:
CSSKeyframeRule(StyleKeyframe&, CSSKeyframesRule* parent);
- CSSRule::Type type() const override { return KEYFRAME_RULE; }
+ CSSRule::Type type() const final { return KEYFRAME_RULE; }
Ref<StyleKeyframe> m_keyframe;
mutable RefPtr<StyleRuleCSSStyleDeclaration> m_propertiesCSSOMWrapper;
Modified: trunk/Source/WebCore/css/CSSKeyframesRule.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSKeyframesRule.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSKeyframesRule.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -38,7 +38,7 @@
class StyleKeyframe;
class CSSKeyframeRule;
-class StyleRuleKeyframes : public StyleRuleBase {
+class StyleRuleKeyframes final : public StyleRuleBase {
public:
static Ref<StyleRuleKeyframes> create() { return adoptRef(*new StyleRuleKeyframes()); }
@@ -71,9 +71,9 @@
virtual ~CSSKeyframesRule();
- CSSRule::Type type() const override { return KEYFRAMES_RULE; }
- String cssText() const override;
- void reattach(StyleRuleBase&) override;
+ CSSRule::Type type() const final { return KEYFRAMES_RULE; }
+ String cssText() const final;
+ void reattach(StyleRuleBase&) final;
String name() const { return m_keyframesRule->name(); }
void setName(const String&);
Modified: trunk/Source/WebCore/css/CSSLineBoxContainValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSLineBoxContainValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSLineBoxContainValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -38,7 +38,7 @@
typedef unsigned LineBoxContain;
// Used for text-CSSLineBoxContain and box-CSSLineBoxContain
-class CSSLineBoxContainValue : public CSSValue {
+class CSSLineBoxContainValue final : public CSSValue {
public:
static Ref<CSSLineBoxContainValue> create(LineBoxContain value)
{
Modified: trunk/Source/WebCore/css/CSSNamedImageValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSNamedImageValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSNamedImageValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -34,7 +34,7 @@
class Document;
-class CSSNamedImageValue : public CSSImageGeneratorValue {
+class CSSNamedImageValue final : public CSSImageGeneratorValue {
public:
static Ref<CSSNamedImageValue> create(const String& name)
{
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -77,7 +77,7 @@
return static_cast<float>(value);
}
-class CSSPrimitiveValue : public CSSValue {
+class CSSPrimitiveValue final : public CSSValue {
public:
enum UnitTypes {
CSS_UNKNOWN = 0,
Modified: trunk/Source/WebCore/css/CSSReflectValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSReflectValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSReflectValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -33,7 +33,7 @@
class CSSPrimitiveValue;
-class CSSReflectValue : public CSSValue {
+class CSSReflectValue final : public CSSValue {
public:
static Ref<CSSReflectValue> create(Ref<CSSPrimitiveValue>&& direction, Ref<CSSPrimitiveValue>&& offset, RefPtr<CSSValue>&& mask)
{
Modified: trunk/Source/WebCore/css/CSSRevertValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSRevertValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSRevertValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -31,7 +31,7 @@
namespace WebCore {
-class CSSRevertValue : public CSSValue {
+class CSSRevertValue final : public CSSValue {
public:
String customCSSText() const;
Modified: trunk/Source/WebCore/css/CSSRuleList.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSRuleList.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSRuleList.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -50,19 +50,19 @@
public:
static Ref<StaticCSSRuleList> create() { return adoptRef(*new StaticCSSRuleList); }
- void ref() override { ++m_refCount; }
- void deref() override;
+ void ref() final { ++m_refCount; }
+ void deref() final;
Vector<RefPtr<CSSRule>>& rules() { return m_rules; }
- CSSStyleSheet* styleSheet() const override { return nullptr; }
+ CSSStyleSheet* styleSheet() const final { return nullptr; }
private:
StaticCSSRuleList();
~StaticCSSRuleList();
- unsigned length() const override { return m_rules.size(); }
- CSSRule* item(unsigned index) const override { return index < m_rules.size() ? m_rules[index].get() : nullptr; }
+ unsigned length() const final { return m_rules.size(); }
+ CSSRule* item(unsigned index) const final { return index < m_rules.size() ? m_rules[index].get() : nullptr; }
Vector<RefPtr<CSSRule>> m_rules;
unsigned m_refCount;
@@ -77,13 +77,13 @@
{
}
- void ref() override { m_rule.ref(); }
- void deref() override { m_rule.deref(); }
+ void ref() final { m_rule.ref(); }
+ void deref() final { m_rule.deref(); }
private:
- unsigned length() const override { return m_rule.length(); }
- CSSRule* item(unsigned index) const override { return m_rule.item(index); }
- CSSStyleSheet* styleSheet() const override { return m_rule.parentStyleSheet(); }
+ unsigned length() const final { return m_rule.length(); }
+ CSSRule* item(unsigned index) const final { return m_rule.item(index); }
+ CSSStyleSheet* styleSheet() const final { return m_rule.parentStyleSheet(); }
Rule& m_rule;
};
Modified: trunk/Source/WebCore/css/CSSSegmentedFontFace.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSSegmentedFontFace.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSSegmentedFontFace.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -54,12 +54,12 @@
Vector<Ref<CSSFontFace>, 1>& constituentFaces() { return m_fontFaces; }
// CSSFontFace::Client needs to be able to be held in a RefPtr.
- void ref() override { RefCounted<CSSSegmentedFontFace>::ref(); }
- void deref() override { RefCounted<CSSSegmentedFontFace>::deref(); }
+ void ref() final { RefCounted<CSSSegmentedFontFace>::ref(); }
+ void deref() final { RefCounted<CSSSegmentedFontFace>::deref(); }
private:
CSSSegmentedFontFace();
- void fontLoaded(CSSFontFace&) override;
+ void fontLoaded(CSSFontFace&) final;
HashMap<FontDescriptionKey, FontRanges, FontDescriptionKeyHash, WTF::SimpleClassHashTraits<FontDescriptionKey>> m_cache;
Vector<Ref<CSSFontFace>, 1> m_fontFaces;
Modified: trunk/Source/WebCore/css/CSSShadowValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSShadowValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSShadowValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -29,7 +29,7 @@
class CSSPrimitiveValue;
// Used for text-shadow and box-shadow
-class CSSShadowValue : public CSSValue {
+class CSSShadowValue final : public CSSValue {
public:
static Ref<CSSShadowValue> create(RefPtr<CSSPrimitiveValue>&& x,
RefPtr<CSSPrimitiveValue>&& y,
Modified: trunk/Source/WebCore/css/CSSStyleSheet.cpp (205092 => 205093)
--- trunk/Source/WebCore/css/CSSStyleSheet.cpp 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSStyleSheet.cpp 2016-08-28 00:40:24 UTC (rev 205093)
@@ -48,18 +48,18 @@
namespace WebCore {
-class StyleSheetCSSRuleList : public CSSRuleList {
+class StyleSheetCSSRuleList final : public CSSRuleList {
public:
StyleSheetCSSRuleList(CSSStyleSheet* sheet) : m_styleSheet(sheet) { }
private:
- void ref() override { m_styleSheet->ref(); }
- void deref() override { m_styleSheet->deref(); }
+ void ref() final { m_styleSheet->ref(); }
+ void deref() final { m_styleSheet->deref(); }
- unsigned length() const override { return m_styleSheet->length(); }
- CSSRule* item(unsigned index) const override { return m_styleSheet->item(index); }
+ unsigned length() const final { return m_styleSheet->length(); }
+ CSSRule* item(unsigned index) const final { return m_styleSheet->item(index); }
- CSSStyleSheet* styleSheet() const override { return m_styleSheet; }
+ CSSStyleSheet* styleSheet() const final { return m_styleSheet; }
CSSStyleSheet* m_styleSheet;
};
Modified: trunk/Source/WebCore/css/CSSStyleSheet.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSStyleSheet.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSStyleSheet.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -54,13 +54,13 @@
virtual ~CSSStyleSheet();
- CSSStyleSheet* parentStyleSheet() const override;
- Node* ownerNode() const override { return m_ownerNode; }
- MediaList* media() const override;
- String href() const override;
- String title() const override { return m_title; }
- bool disabled() const override { return m_isDisabled; }
- void setDisabled(bool) override;
+ CSSStyleSheet* parentStyleSheet() const final;
+ Node* ownerNode() const final { return m_ownerNode; }
+ MediaList* media() const final;
+ String href() const final;
+ String title() const final { return m_title; }
+ bool disabled() const final { return m_isDisabled; }
+ void setDisabled(bool) final;
WEBCORE_EXPORT RefPtr<CSSRuleList> cssRules();
WEBCORE_EXPORT unsigned insertRule(const String& rule, unsigned index, ExceptionCode&);
@@ -76,10 +76,10 @@
unsigned length() const;
CSSRule* item(unsigned index);
- void clearOwnerNode() override;
- CSSImportRule* ownerRule() const override { return m_ownerRule; }
- URL baseURL() const override;
- bool isLoading() const override;
+ void clearOwnerNode() final;
+ CSSImportRule* ownerRule() const final { return m_ownerRule; }
+ URL baseURL() const final;
+ bool isLoading() const final;
void clearOwnerRule() { m_ownerRule = 0; }
Document* ownerDocument() const;
@@ -126,8 +126,8 @@
CSSStyleSheet(Ref<StyleSheetContents>&&, CSSImportRule* ownerRule);
CSSStyleSheet(Ref<StyleSheetContents>&&, Node* ownerNode, const TextPosition& startPosition, bool isInlineStylesheet);
- bool isCSSStyleSheet() const override { return true; }
- String type() const override { return ASCIILiteral("text/css"); }
+ bool isCSSStyleSheet() const final { return true; }
+ String type() const final { return ASCIILiteral("text/css"); }
bool canAccessRules() const;
Modified: trunk/Source/WebCore/css/CSSSupportsRule.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSSupportsRule.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSSupportsRule.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -45,7 +45,7 @@
virtual ~CSSSupportsRule() { }
- String cssText() const override;
+ String cssText() const final;
String conditionText() const;
@@ -52,7 +52,7 @@
private:
CSSSupportsRule(StyleRuleSupports&, CSSStyleSheet*);
- CSSRule::Type type() const override { return SUPPORTS_RULE; }
+ CSSRule::Type type() const final { return SUPPORTS_RULE; }
};
} // namespace WebCore
Modified: trunk/Source/WebCore/css/CSSTimingFunctionValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSTimingFunctionValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSTimingFunctionValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -30,7 +30,7 @@
namespace WebCore {
-class CSSCubicBezierTimingFunctionValue : public CSSValue {
+class CSSCubicBezierTimingFunctionValue final : public CSSValue {
public:
static Ref<CSSCubicBezierTimingFunctionValue> create(double x1, double y1, double x2, double y2)
{
@@ -62,7 +62,7 @@
double m_y2;
};
-class CSSStepsTimingFunctionValue : public CSSValue {
+class CSSStepsTimingFunctionValue final : public CSSValue {
public:
static Ref<CSSStepsTimingFunctionValue> create(int steps, bool stepAtStart)
{
@@ -88,7 +88,7 @@
bool m_stepAtStart;
};
-class CSSSpringTimingFunctionValue : public CSSValue {
+class CSSSpringTimingFunctionValue final : public CSSValue {
public:
static Ref<CSSSpringTimingFunctionValue> create(double mass, double stiffness, double damping, double initialVelocity)
{
Modified: trunk/Source/WebCore/css/CSSUnicodeRangeValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSUnicodeRangeValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSUnicodeRangeValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -30,7 +30,7 @@
namespace WebCore {
-class CSSUnicodeRangeValue : public CSSValue {
+class CSSUnicodeRangeValue final : public CSSValue {
public:
static Ref<CSSUnicodeRangeValue> create(UChar32 from, UChar32 to)
{
Modified: trunk/Source/WebCore/css/CSSUnknownRule.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSUnknownRule.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSUnknownRule.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -35,11 +35,11 @@
virtual ~CSSUnknownRule() { }
- String cssText() const override { return String(); }
- void reattach(StyleRuleBase&) override { }
+ String cssText() const final { return String(); }
+ void reattach(StyleRuleBase&) final { }
private:
- CSSRule::Type type() const override { return UNKNOWN_RULE; }
+ CSSRule::Type type() const final { return UNKNOWN_RULE; }
};
} // namespace WebCore
Modified: trunk/Source/WebCore/css/CSSUnsetValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSUnsetValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSUnsetValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -31,7 +31,7 @@
namespace WebCore {
-class CSSUnsetValue : public CSSValue {
+class CSSUnsetValue final : public CSSValue {
public:
String customCSSText() const;
Modified: trunk/Source/WebCore/css/CSSValue.cpp (205092 => 205093)
--- trunk/Source/WebCore/css/CSSValue.cpp 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSValue.cpp 2016-08-28 00:40:24 UTC (rev 205093)
@@ -78,7 +78,7 @@
COMPILE_ASSERT(sizeof(CSSValue) == sizeof(SameSizeAsCSSValue), CSS_value_should_stay_small);
-class TextCloneCSSValue : public CSSValue {
+class TextCloneCSSValue final : public CSSValue {
public:
static Ref<TextCloneCSSValue> create(ClassType classType, const String& text)
{
Modified: trunk/Source/WebCore/css/CSSVariableDependentValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSVariableDependentValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSVariableDependentValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -32,7 +32,7 @@
namespace WebCore {
-class CSSVariableDependentValue : public CSSValue {
+class CSSVariableDependentValue final : public CSSValue {
public:
static Ref<CSSVariableDependentValue> create(Ref<CSSValueList>&& valueList, CSSPropertyID propId)
{
Modified: trunk/Source/WebCore/css/CSSVariableValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/CSSVariableValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/CSSVariableValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -34,7 +34,7 @@
class CSSParserValueList;
struct CSSParserVariable;
-class CSSVariableValue : public CSSValue {
+class CSSVariableValue final : public CSSValue {
public:
static Ref<CSSVariableValue> create(CSSParserVariable* Variable)
{
Modified: trunk/Source/WebCore/css/Counter.h (205092 => 205093)
--- trunk/Source/WebCore/css/Counter.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/Counter.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -25,7 +25,7 @@
namespace WebCore {
-class Counter : public RefCounted<Counter> {
+class Counter final : public RefCounted<Counter> {
public:
static Ref<Counter> create(Ref<CSSPrimitiveValue>&& identifier, Ref<CSSPrimitiveValue>&& listStyle, Ref<CSSPrimitiveValue>&& separator)
{
Modified: trunk/Source/WebCore/css/DOMCSSNamespace.h (205092 => 205093)
--- trunk/Source/WebCore/css/DOMCSSNamespace.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/DOMCSSNamespace.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -34,7 +34,7 @@
namespace WebCore {
-class DOMCSSNamespace : public RefCounted<DOMCSSNamespace> {
+class DOMCSSNamespace final : public RefCounted<DOMCSSNamespace> {
public:
static bool supports(const String& property, const String& value);
static bool supports(const String& conditionText);
Modified: trunk/Source/WebCore/css/DashboardRegion.h (205092 => 205093)
--- trunk/Source/WebCore/css/DashboardRegion.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/DashboardRegion.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -27,7 +27,7 @@
namespace WebCore {
-class DashboardRegion : public RectBase, public RefCounted<DashboardRegion> {
+class DashboardRegion final : public RectBase, public RefCounted<DashboardRegion> {
public:
static Ref<DashboardRegion> create() { return adoptRef(*new DashboardRegion); }
bool equals(const DashboardRegion& other) const
Modified: trunk/Source/WebCore/css/LengthRepeat.h (205092 => 205093)
--- trunk/Source/WebCore/css/LengthRepeat.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/LengthRepeat.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -34,7 +34,7 @@
namespace WebCore {
-class LengthRepeat : public RefCounted<LengthRepeat> {
+class LengthRepeat final : public RefCounted<LengthRepeat> {
public:
static Ref<LengthRepeat> create(PassRefPtr<CSSValue> interval) { return adoptRef(*new LengthRepeat(interval)); }
Modified: trunk/Source/WebCore/css/MediaList.h (205092 => 205093)
--- trunk/Source/WebCore/css/MediaList.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/MediaList.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -35,7 +35,7 @@
using ExceptionCode = int;
-class MediaQuerySet : public RefCounted<MediaQuerySet> {
+class MediaQuerySet final : public RefCounted<MediaQuerySet> {
public:
static Ref<MediaQuerySet> create()
{
@@ -81,7 +81,7 @@
Vector<MediaQuery> m_queries;
};
-class MediaList : public RefCounted<MediaList> {
+class MediaList final : public RefCounted<MediaList> {
public:
static Ref<MediaList> create(MediaQuerySet* mediaQueries, CSSStyleSheet* parentSheet)
{
Modified: trunk/Source/WebCore/css/MediaQueryList.h (205092 => 205093)
--- trunk/Source/WebCore/css/MediaQueryList.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/MediaQueryList.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -35,7 +35,7 @@
// retrieve the current value of the given media query and to add/remove listeners that
// will be called whenever the value of the query changes.
-class MediaQueryList : public RefCounted<MediaQueryList> {
+class MediaQueryList final : public RefCounted<MediaQueryList> {
public:
static Ref<MediaQueryList> create(MediaQueryMatcher&, Ref<MediaQuerySet>&&, bool);
~MediaQueryList();
Modified: trunk/Source/WebCore/css/MediaQueryMatcher.h (205092 => 205093)
--- trunk/Source/WebCore/css/MediaQueryMatcher.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/MediaQueryMatcher.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -38,7 +38,7 @@
// whenever it is needed and to call the listeners if the corresponding query has changed.
// The listeners must be called in the order in which they were added.
-class MediaQueryMatcher : public RefCounted<MediaQueryMatcher> {
+class MediaQueryMatcher final : public RefCounted<MediaQueryMatcher> {
public:
static Ref<MediaQueryMatcher> create(Document& document) { return adoptRef(*new MediaQueryMatcher(document)); }
~MediaQueryMatcher();
Modified: trunk/Source/WebCore/css/Pair.h (205092 => 205093)
--- trunk/Source/WebCore/css/Pair.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/Pair.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -30,7 +30,7 @@
// and border-spacing (all of which are space-separated sets of two values). At the moment we are only using it for
// border-radius and background-size, but (FIXME) border-spacing and background-position could be converted over to use
// it (eliminating some extra -webkit- internal properties).
-class Pair : public RefCounted<Pair> {
+class Pair final : public RefCounted<Pair> {
public:
enum class IdenticalValueEncoding {
DoNotCoalesce,
Modified: trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.h (205092 => 205093)
--- trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -91,8 +91,8 @@
void clearParentRule() { m_parentRule = 0; }
- void ref() override;
- void deref() override;
+ void ref() final;
+ void deref() final;
void reattach(MutableStyleProperties&);
@@ -99,12 +99,12 @@
private:
StyleRuleCSSStyleDeclaration(MutableStyleProperties&, CSSRule&);
- CSSStyleSheet* parentStyleSheet() const override;
+ CSSStyleSheet* parentStyleSheet() const final;
- CSSRule* parentRule() const override { return m_parentRule; }
+ CSSRule* parentRule() const final { return m_parentRule; }
- bool willMutate() override WARN_UNUSED_RETURN;
- void didMutate(MutationType) override;
+ bool willMutate() final WARN_UNUSED_RETURN;
+ void didMutate(MutationType) final;
unsigned m_refCount;
CSSRule* m_parentRule;
@@ -120,11 +120,11 @@
}
private:
- CSSStyleSheet* parentStyleSheet() const override;
- StyledElement* parentElement() const override { return m_parentElement; }
- void clearParentElement() override { m_parentElement = 0; }
+ CSSStyleSheet* parentStyleSheet() const final;
+ StyledElement* parentElement() const final { return m_parentElement; }
+ void clearParentElement() final { m_parentElement = 0; }
- void didMutate(MutationType) override;
+ void didMutate(MutationType) final;
StyledElement* m_parentElement;
};
Modified: trunk/Source/WebCore/css/RGBColor.h (205092 => 205093)
--- trunk/Source/WebCore/css/RGBColor.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/RGBColor.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -33,7 +33,7 @@
class CSSPrimitiveValue;
-class RGBColor : public RefCounted<RGBColor> {
+class RGBColor final : public RefCounted<RGBColor> {
public:
static Ref<RGBColor> create(unsigned rgbColor);
Modified: trunk/Source/WebCore/css/Rect.h (205092 => 205093)
--- trunk/Source/WebCore/css/Rect.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/Rect.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -65,7 +65,7 @@
RefPtr<CSSPrimitiveValue> m_left;
};
-class Rect : public RectBase, public RefCounted<Rect> {
+class Rect final : public RectBase, public RefCounted<Rect> {
public:
static Ref<Rect> create() { return adoptRef(*new Rect); }
@@ -85,7 +85,7 @@
}
};
-class Quad : public RectBase, public RefCounted<Quad> {
+class Quad final : public RectBase, public RefCounted<Quad> {
public:
static Ref<Quad> create() { return adoptRef(*new Quad); }
Modified: trunk/Source/WebCore/css/StyleMedia.h (205092 => 205093)
--- trunk/Source/WebCore/css/StyleMedia.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/StyleMedia.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -35,7 +35,7 @@
class Frame;
-class StyleMedia : public RefCounted<StyleMedia>, public DOMWindowProperty {
+class StyleMedia final : public RefCounted<StyleMedia>, public DOMWindowProperty {
public:
static Ref<StyleMedia> create(Frame* frame) { return adoptRef(*new StyleMedia(frame)); }
Modified: trunk/Source/WebCore/css/StyleProperties.h (205092 => 205093)
--- trunk/Source/WebCore/css/StyleProperties.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/StyleProperties.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -154,7 +154,7 @@
friend class PropertySetCSSStyleDeclaration;
};
-class ImmutableStyleProperties : public StyleProperties {
+class ImmutableStyleProperties final : public StyleProperties {
public:
WEBCORE_EXPORT ~ImmutableStyleProperties();
static Ref<ImmutableStyleProperties> create(const CSSProperty* properties, unsigned count, CSSParserMode);
@@ -184,7 +184,7 @@
return reinterpret_cast_ptr<const StylePropertyMetadata*>(&reinterpret_cast_ptr<const char*>(&(this->m_storage))[m_arraySize * sizeof(CSSValue*)]);
}
-class MutableStyleProperties : public StyleProperties {
+class MutableStyleProperties final : public StyleProperties {
public:
WEBCORE_EXPORT static Ref<MutableStyleProperties> create(CSSParserMode = CSSQuirksMode);
static Ref<MutableStyleProperties> create(const CSSProperty* properties, unsigned count);
Modified: trunk/Source/WebCore/css/StyleRule.h (205092 => 205093)
--- trunk/Source/WebCore/css/StyleRule.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/StyleRule.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -99,7 +99,7 @@
signed m_sourceLine : 27;
};
-class StyleRule : public StyleRuleBase {
+class StyleRule final : public StyleRuleBase {
WTF_MAKE_FAST_ALLOCATED;
public:
static Ref<StyleRule> create(int sourceLine, Ref<StyleProperties>&& properties)
@@ -133,7 +133,7 @@
CSSSelectorList m_selectorList;
};
-class StyleRuleFontFace : public StyleRuleBase {
+class StyleRuleFontFace final : public StyleRuleBase {
public:
static Ref<StyleRuleFontFace> create(Ref<StyleProperties>&& properties) { return adoptRef(*new StyleRuleFontFace(WTFMove(properties))); }
@@ -152,7 +152,7 @@
Ref<StyleProperties> m_properties;
};
-class StyleRulePage : public StyleRuleBase {
+class StyleRulePage final : public StyleRuleBase {
public:
static Ref<StyleRulePage> create(Ref<StyleProperties>&& properties) { return adoptRef(*new StyleRulePage(WTFMove(properties))); }
@@ -190,7 +190,7 @@
Vector<RefPtr<StyleRuleBase>> m_childRules;
};
-class StyleRuleMedia : public StyleRuleGroup {
+class StyleRuleMedia final : public StyleRuleGroup {
public:
static Ref<StyleRuleMedia> create(Ref<MediaQuerySet>&& media, Vector<RefPtr<StyleRuleBase>>& adoptRules)
{
@@ -208,7 +208,7 @@
RefPtr<MediaQuerySet> m_mediaQueries;
};
-class StyleRuleSupports : public StyleRuleGroup {
+class StyleRuleSupports final : public StyleRuleGroup {
public:
static Ref<StyleRuleSupports> create(const String& conditionText, bool conditionIsSupported, Vector<RefPtr<StyleRuleBase>>& adoptRules)
{
@@ -227,7 +227,7 @@
bool m_conditionIsSupported;
};
-class StyleRuleRegion : public StyleRuleGroup {
+class StyleRuleRegion final : public StyleRuleGroup {
public:
static Ref<StyleRuleRegion> create(Vector<std::unique_ptr<CSSParserSelector>>* selectors, Vector<RefPtr<StyleRuleBase>>& adoptRules)
{
@@ -246,7 +246,7 @@
};
#if ENABLE(CSS_DEVICE_ADAPTATION)
-class StyleRuleViewport : public StyleRuleBase {
+class StyleRuleViewport final : public StyleRuleBase {
public:
static Ref<StyleRuleViewport> create(Ref<StyleProperties>&& properties) { return adoptRef(*new StyleRuleViewport(WTFMove(properties))); }
Modified: trunk/Source/WebCore/css/StyleRuleImport.h (205092 => 205093)
--- trunk/Source/WebCore/css/StyleRuleImport.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/StyleRuleImport.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -33,7 +33,7 @@
class MediaQuerySet;
class StyleSheetContents;
-class StyleRuleImport : public StyleRuleBase {
+class StyleRuleImport final : public StyleRuleBase {
WTF_MAKE_FAST_ALLOCATED;
public:
static Ref<StyleRuleImport> create(const String& href, Ref<MediaQuerySet>&&);
@@ -55,7 +55,7 @@
private:
// NOTE: We put the CachedStyleSheetClient in a member instead of inheriting from it
// to avoid adding a vptr to StyleRuleImport.
- class ImportedStyleSheetClient : public CachedStyleSheetClient {
+class ImportedStyleSheetClient final : public CachedStyleSheetClient {
public:
ImportedStyleSheetClient(StyleRuleImport* ownerRule) : m_ownerRule(ownerRule) { }
virtual ~ImportedStyleSheetClient() { }
Modified: trunk/Source/WebCore/css/StyleSheetContents.h (205092 => 205093)
--- trunk/Source/WebCore/css/StyleSheetContents.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/StyleSheetContents.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -42,7 +42,7 @@
class StyleRuleBase;
class StyleRuleImport;
-class StyleSheetContents : public RefCounted<StyleSheetContents> {
+class StyleSheetContents final : public RefCounted<StyleSheetContents> {
public:
static Ref<StyleSheetContents> create(const CSSParserContext& context = CSSParserContext(CSSStrictMode))
{
Modified: trunk/Source/WebCore/css/StyleSheetList.h (205092 => 205093)
--- trunk/Source/WebCore/css/StyleSheetList.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/StyleSheetList.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -30,7 +30,7 @@
class HTMLStyleElement;
class StyleSheet;
-class StyleSheetList : public RefCounted<StyleSheetList> {
+class StyleSheetList final : public RefCounted<StyleSheetList> {
public:
static Ref<StyleSheetList> create(Document* document) { return adoptRef(*new StyleSheetList(document)); }
WEBCORE_EXPORT ~StyleSheetList();
Modified: trunk/Source/WebCore/css/ViewportStyleResolver.h (205092 => 205093)
--- trunk/Source/WebCore/css/ViewportStyleResolver.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/ViewportStyleResolver.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -44,7 +44,7 @@
class MutableStyleProperties;
class StyleRuleViewport;
-class ViewportStyleResolver : public RefCounted<ViewportStyleResolver> {
+class ViewportStyleResolver final : public RefCounted<ViewportStyleResolver> {
public:
static Ref<ViewportStyleResolver> create(Document* document)
{
Modified: trunk/Source/WebCore/css/WebKitCSSFilterValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/WebKitCSSFilterValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/WebKitCSSFilterValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -30,7 +30,7 @@
namespace WebCore {
-class WebKitCSSFilterValue : public CSSValueList {
+class WebKitCSSFilterValue final : public CSSValueList {
public:
// NOTE: these have to match the values in the IDL
enum FilterOperationType {
Modified: trunk/Source/WebCore/css/WebKitCSSRegionRule.h (205092 => 205093)
--- trunk/Source/WebCore/css/WebKitCSSRegionRule.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/WebKitCSSRegionRule.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -43,8 +43,8 @@
public:
static Ref<WebKitCSSRegionRule> create(StyleRuleRegion& rule, CSSStyleSheet* sheet) { return adoptRef(*new WebKitCSSRegionRule(rule, sheet)); }
- CSSRule::Type type() const override { return WEBKIT_REGION_RULE; }
- String cssText() const override;
+ CSSRule::Type type() const final { return WEBKIT_REGION_RULE; }
+ String cssText() const final;
private:
WebKitCSSRegionRule(StyleRuleRegion&, CSSStyleSheet* parent);
Modified: trunk/Source/WebCore/css/WebKitCSSTransformValue.h (205092 => 205093)
--- trunk/Source/WebCore/css/WebKitCSSTransformValue.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/WebKitCSSTransformValue.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -29,7 +29,7 @@
namespace WebCore {
-class WebKitCSSTransformValue : public CSSValueList {
+class WebKitCSSTransformValue final : public CSSValueList {
public:
// NOTE: these have to match the values in the IDL
enum TransformOperationType {
Modified: trunk/Source/WebCore/css/WebKitCSSViewportRule.h (205092 => 205093)
--- trunk/Source/WebCore/css/WebKitCSSViewportRule.h 2016-08-28 00:36:05 UTC (rev 205092)
+++ trunk/Source/WebCore/css/WebKitCSSViewportRule.h 2016-08-28 00:40:24 UTC (rev 205093)
@@ -49,8 +49,8 @@
}
virtual ~WebKitCSSViewportRule();
- String cssText() const override;
- void reattach(StyleRuleBase&) override;
+ String cssText() const final;
+ void reattach(StyleRuleBase&) final;
CSSStyleDeclaration& style();
@@ -57,7 +57,7 @@
private:
WebKitCSSViewportRule(StyleRuleViewport&, CSSStyleSheet*);
- CSSRule::Type type() const override { return WEBKIT_VIEWPORT_RULE; }
+ CSSRule::Type type() const final { return WEBKIT_VIEWPORT_RULE; }
Ref<StyleRuleViewport> m_viewportRule;
mutable RefPtr<StyleRuleCSSStyleDeclaration> m_propertiesCSSOMWrapper;
