Title: [205095] trunk/Source/WebCore
- Revision
- 205095
- Author
- [email protected]
- Date
- 2016-08-27 22:24:39 -0700 (Sat, 27 Aug 2016)
Log Message
Follow-up fixes after r205030.
https://bugs.webkit.org/show_bug.cgi?id=161216
Reviewed by Darin Adler.
* html/parser/HTMLParserIdioms.cpp:
(WebCore::isHTMLSpaceOrDelimiter):
(WebCore::isNumberStart):
(WebCore::parseHTMLListOfOfFloatingPointNumberValues):
* html/parser/HTMLParserIdioms.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (205094 => 205095)
--- trunk/Source/WebCore/ChangeLog 2016-08-28 01:27:41 UTC (rev 205094)
+++ trunk/Source/WebCore/ChangeLog 2016-08-28 05:24:39 UTC (rev 205095)
@@ -1,3 +1,16 @@
+2016-08-27 Chris Dumez <[email protected]>
+
+ Follow-up fixes after r205030.
+ https://bugs.webkit.org/show_bug.cgi?id=161216
+
+ Reviewed by Darin Adler.
+
+ * html/parser/HTMLParserIdioms.cpp:
+ (WebCore::isHTMLSpaceOrDelimiter):
+ (WebCore::isNumberStart):
+ (WebCore::parseHTMLListOfOfFloatingPointNumberValues):
+ * html/parser/HTMLParserIdioms.h:
+
2016-08-27 Rawinder Singh <[email protected]>
Add final keyword to final classes and overriden methods in WebCore/css
Modified: trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp (205094 => 205095)
--- trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp 2016-08-28 01:27:41 UTC (rev 205094)
+++ trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp 2016-08-28 05:24:39 UTC (rev 205095)
@@ -216,14 +216,12 @@
return signedValue;
}
-template <typename CharacterType>
-static inline bool isHTMLSpaceOrDelimiter(CharacterType character)
+static inline bool isHTMLSpaceOrDelimiter(UChar character)
{
return isHTMLSpace(character) || character == ',' || character == ';';
}
-template <typename CharacterType>
-static inline bool isNumberStart(CharacterType character)
+static inline bool isNumberStart(UChar character)
{
return isASCIIDigit(character) || character == '.' || character == '-';
}
@@ -259,19 +257,15 @@
return numbers;
}
-Vector<double> parseHTMLListOfOfFloatingPointNumberValues(const String& input)
+Vector<double> parseHTMLListOfOfFloatingPointNumberValues(StringView input)
{
- unsigned length = input.length();
- if (!length)
- return { };
-
if (LIKELY(input.is8Bit())) {
auto* start = input.characters8();
- return parseHTMLListOfOfFloatingPointNumberValuesInternal(start, start + length);
+ return parseHTMLListOfOfFloatingPointNumberValuesInternal(start, start + input.length());
}
auto* start = input.characters16();
- return parseHTMLListOfOfFloatingPointNumberValuesInternal(start, start + length);
+ return parseHTMLListOfOfFloatingPointNumberValuesInternal(start, start + input.length());
}
static bool threadSafeEqual(const StringImpl& a, const StringImpl& b)
Modified: trunk/Source/WebCore/html/parser/HTMLParserIdioms.h (205094 => 205095)
--- trunk/Source/WebCore/html/parser/HTMLParserIdioms.h 2016-08-28 01:27:41 UTC (rev 205094)
+++ trunk/Source/WebCore/html/parser/HTMLParserIdioms.h 2016-08-28 05:24:39 UTC (rev 205095)
@@ -68,7 +68,7 @@
WEBCORE_EXPORT Optional<int> parseHTMLNonNegativeInteger(const String&);
// https://html.spec.whatwg.org/multipage/infrastructure.html#rules-for-parsing-floating-point-number-values
-Vector<double> parseHTMLListOfOfFloatingPointNumberValues(const String&);
+Vector<double> parseHTMLListOfOfFloatingPointNumberValues(StringView);
// https://html.spec.whatwg.org/multipage/infrastructure.html#cors-settings-attribute
String parseCORSSettingsAttribute(const AtomicString&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
