Title: [98387] trunk/Tools
Revision
98387
Author
[email protected]
Date
2011-10-25 13:42:19 -0700 (Tue, 25 Oct 2011)

Log Message

[EFL] DRT: Force layout when sending events.
https://bugs.webkit.org/show_bug.cgi?id=70357

Patch by Raphael Kubo da Costa <[email protected]> on 2011-10-25
Reviewed by Antonio Gomes.

Some tests such as editing/input/page-up-down-scrolls.html rely on the
scrollbars being properly set up during the onload events.
Document::implicitClose(), however, dispatches the onload events before
calling FrameView::layout(), so these tests usually fail.

We now do the same as the GTK+ and Chromium ports and manually force the
layout when dispatching events.

* DumpRenderTree/efl/EventSender.cpp:
(sendMouseEvent):
(keyDownCallback):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (98386 => 98387)


--- trunk/Tools/ChangeLog	2011-10-25 20:38:25 UTC (rev 98386)
+++ trunk/Tools/ChangeLog	2011-10-25 20:42:19 UTC (rev 98387)
@@ -1,3 +1,22 @@
+2011-10-25  Raphael Kubo da Costa  <[email protected]>
+
+        [EFL] DRT: Force layout when sending events.
+        https://bugs.webkit.org/show_bug.cgi?id=70357
+
+        Reviewed by Antonio Gomes.
+
+        Some tests such as editing/input/page-up-down-scrolls.html rely on the
+        scrollbars being properly set up during the onload events.
+        Document::implicitClose(), however, dispatches the onload events before
+        calling FrameView::layout(), so these tests usually fail.
+
+        We now do the same as the GTK+ and Chromium ports and manually force the
+        layout when dispatching events.
+
+        * DumpRenderTree/efl/EventSender.cpp:
+        (sendMouseEvent):
+        (keyDownCallback):
+
 2011-10-25  Daniel Bates  <[email protected]>
 
         build-webkit --clean should only clean build directory for CMake-based ports

Modified: trunk/Tools/DumpRenderTree/efl/EventSender.cpp (98386 => 98387)


--- trunk/Tools/DumpRenderTree/efl/EventSender.cpp	2011-10-25 20:38:25 UTC (rev 98386)
+++ trunk/Tools/DumpRenderTree/efl/EventSender.cpp	2011-10-25 20:42:19 UTC (rev 98387)
@@ -129,6 +129,8 @@
 {
     unsigned timeStamp = 0;
 
+    DumpRenderTreeSupportEfl::layoutFrame(browser->mainFrame());
+
     setEvasModifiers(evas, modifiers);
     if (event & EvasMouseEventMove)
         evas_event_feed_mouse_move(evas, gLastMousePositionX, gLastMousePositionY, timeStamp++, 0);
@@ -423,6 +425,7 @@
     if (!keyName)
         keyName = cCharacter.data();
 
+    DumpRenderTreeSupportEfl::layoutFrame(browser->mainFrame());
     evas_event_feed_key_down(evas, keyName, keyName, keyName, 0, 0, 0);
     evas_event_feed_key_up(evas, keyName, keyName, keyName, 0, 1, 0);
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to