Title: [205299] trunk/Source/WebKit2
- Revision
- 205299
- Author
- [email protected]
- Date
- 2016-09-01 11:08:54 -0700 (Thu, 01 Sep 2016)
Log Message
[Mac] Web Inspector: Remove stale inspector process termination code
https://bugs.webkit.org/show_bug.cgi?id=161465
<rdar://problem/28106584>
Patch by Joseph Pecoraro <[email protected]> on 2016-09-01
Reviewed by Brian Burg.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::didRelaunchInspectorPageProcess): Deleted.
* UIProcess/WebInspectorProxy.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter didRelaunchProcess]): Deleted.
(-[WKWebInspectorWKWebView _didRelaunchProcess]): Deleted.
This code doesn't appear to be run when the WebContent process inside
of an Inspector process crashes. The general WebInspectorProxy has its
own handling of when the page inside an inspector process crashes, so
this Mac specific path appears to be unused and stale.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (205298 => 205299)
--- trunk/Source/WebKit2/ChangeLog 2016-09-01 18:00:55 UTC (rev 205298)
+++ trunk/Source/WebKit2/ChangeLog 2016-09-01 18:08:54 UTC (rev 205299)
@@ -1,3 +1,22 @@
+2016-09-01 Joseph Pecoraro <[email protected]>
+
+ [Mac] Web Inspector: Remove stale inspector process termination code
+ https://bugs.webkit.org/show_bug.cgi?id=161465
+ <rdar://problem/28106584>
+
+ Reviewed by Brian Burg.
+
+ * UIProcess/WebInspectorProxy.cpp:
+ (WebKit::WebInspectorProxy::didRelaunchInspectorPageProcess): Deleted.
+ * UIProcess/WebInspectorProxy.h:
+ * UIProcess/mac/WebInspectorProxyMac.mm:
+ (-[WKWebInspectorProxyObjCAdapter didRelaunchProcess]): Deleted.
+ (-[WKWebInspectorWKWebView _didRelaunchProcess]): Deleted.
+ This code doesn't appear to be run when the WebContent process inside
+ of an Inspector process crashes. The general WebInspectorProxy has its
+ own handling of when the page inside an inspector process crashes, so
+ this Mac specific path appears to be unused and stale.
+
2016-09-01 Jeremy Huddleston Sequoia <[email protected]>
[GTK] Fix configuration without wayland support
Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (205298 => 205299)
--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2016-09-01 18:00:55 UTC (rev 205298)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2016-09-01 18:08:54 UTC (rev 205299)
@@ -178,17 +178,6 @@
didClose();
}
-void WebInspectorProxy::didRelaunchInspectorPageProcess()
-{
- m_inspectorPage->process().addMessageReceiver(Messages::WebInspectorProxy::messageReceiverName(), m_inspectedPage->pageID(), *this);
- m_inspectorPage->process().assumeReadAccessToBaseURL(WebInspectorProxy::inspectorBaseURL());
-
- // When didRelaunchInspectorPageProcess is called we can assume it is during a load request.
- // Any messages we would have sent to a terminated process need to be re-sent.
-
- m_inspectorPage->process().send(Messages::WebInspectorUI::EstablishConnection(m_connectionIdentifier, m_inspectedPage->pageID(), m_underTest, inspectionLevel()), m_inspectorPage->pageID());
-}
-
void WebInspectorProxy::showConsole()
{
if (!m_inspectedPage)
Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h (205298 => 205299)
--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h 2016-09-01 18:00:55 UTC (rev 205298)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h 2016-09-01 18:08:54 UTC (rev 205299)
@@ -92,8 +92,6 @@
void hide();
void close();
- void didRelaunchInspectorPageProcess();
-
#if PLATFORM(MAC) && WK_API_ENABLED
void createInspectorWindow();
void updateInspectorWindowTitle() const;
Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (205298 => 205299)
--- trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2016-09-01 18:00:55 UTC (rev 205298)
+++ trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm 2016-09-01 18:08:54 UTC (rev 205299)
@@ -71,7 +71,6 @@
- (id)initWithWebInspectorProxy:(WebInspectorProxy*)inspectorProxy;
- (void)close;
-- (void)didRelaunchProcess;
@end
@@ -99,11 +98,6 @@
_inspectorProxy = nullptr;
}
-- (void)didRelaunchProcess
-{
- static_cast<WebInspectorProxy*>(_inspectorProxy)->didRelaunchInspectorPageProcess();
-}
-
- (void)windowDidMove:(NSNotification *)notification
{
static_cast<WebInspectorProxy*>(_inspectorProxy)->windowFrameDidChange();
@@ -162,11 +156,6 @@
return WKInspectorViewTag;
}
-- (void)_didRelaunchProcess
-{
- [self.inspectorProxyObjCAdapter didRelaunchProcess];
-}
-
@end
namespace WebKit {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
