Title: [205316] trunk/LayoutTests
- Revision
- 205316
- Author
- [email protected]
- Date
- 2016-09-01 14:18:44 -0700 (Thu, 01 Sep 2016)
Log Message
Fix a typo in the previous commit. I didn't mean to comment out this test case I added per a review comment.
* fast/custom-elements/CustomElementRegistry-expected.txt:
* fast/custom-elements/CustomElementRegistry.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (205315 => 205316)
--- trunk/LayoutTests/ChangeLog 2016-09-01 21:16:40 UTC (rev 205315)
+++ trunk/LayoutTests/ChangeLog 2016-09-01 21:18:44 UTC (rev 205316)
@@ -1,5 +1,12 @@
2016-09-01 Ryosuke Niwa <[email protected]>
+ Fix a typo in the previous commit. I didn't mean to comment out this test case I added per a review comment.
+
+ * fast/custom-elements/CustomElementRegistry-expected.txt:
+ * fast/custom-elements/CustomElementRegistry.html:
+
+2016-09-01 Ryosuke Niwa <[email protected]>
+
Add "whenDefined" to CustomElementRegistry
https://bugs.webkit.org/show_bug.cgi?id=161425
Modified: trunk/LayoutTests/fast/custom-elements/CustomElementRegistry-expected.txt (205315 => 205316)
--- trunk/LayoutTests/fast/custom-elements/CustomElementRegistry-expected.txt 2016-09-01 21:16:40 UTC (rev 205315)
+++ trunk/LayoutTests/fast/custom-elements/CustomElementRegistry-expected.txt 2016-09-01 21:18:44 UTC (rev 205316)
@@ -30,6 +30,7 @@
PASS "whenDefined" must return a promise for a valid custom element name
PASS "whenDefined" must return the same promise each time invoked for a valid custom element name which has not been defined
PASS "whenDefined" must return an unresolved promise when the registry does not contain the entry with the given name
+PASS "whenDefined" must return a rejected promise when the given name is not a valid custom element name
PASS "whenDefined" must return a resolved promise when the registry contains the entry with the given name
PASS "whenDefined" must return a new resolved promise each time invoked when the registry contains the entry with the given name
PASS A promise returned by "whenDefined" must be resolved by "define"
Modified: trunk/LayoutTests/fast/custom-elements/CustomElementRegistry.html (205315 => 205316)
--- trunk/LayoutTests/fast/custom-elements/CustomElementRegistry.html 2016-09-01 21:16:40 UTC (rev 205315)
+++ trunk/LayoutTests/fast/custom-elements/CustomElementRegistry.html 2016-09-01 21:18:44 UTC (rev 205316)
@@ -424,7 +424,7 @@
assert_false(rejected, 'The promise returned by "whenDefined" must not be rejected until a custom element is defined');
});
}, '"whenDefined" must return an unresolved promise when the registry does not contain the entry with the given name')
-/*
+
promise_test(function () {
var promise = customElements.whenDefined('badname');
promise.then(function (value) { promise.resolved = value; }, function (value) { promise.rejected = value; });
@@ -437,7 +437,7 @@
assert_true('rejected' in promise, 'The promise returned by "whenDefined" must not be rejected when a custom element is defined');
});
}, '"whenDefined" must return a rejected promise when the given name is not a valid custom element name');
-*/
+
promise_test(function () {
customElements.define('preexisting-custom-element', class extends HTMLElement { });
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
