Title: [205401] trunk/Source/WebInspectorUI
- Revision
- 205401
- Author
- [email protected]
- Date
- 2016-09-03 07:38:38 -0700 (Sat, 03 Sep 2016)
Log Message
Web Inspector: Address ESLint undefined variable errors in UserInterface/Views
https://bugs.webkit.org/show_bug.cgi?id=161565
Patch by Joseph Pecoraro <[email protected]> on 2016-09-03
Reviewed by Darin Adler.
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.columnWidthsMap):
* UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
* UserInterface/Views/TextContentView.js:
(WebInspector.TextContentView.prototype._togglePrettyPrint):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (205400 => 205401)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-09-03 14:09:58 UTC (rev 205400)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-09-03 14:38:38 UTC (rev 205401)
@@ -1,3 +1,17 @@
+2016-09-03 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Address ESLint undefined variable errors in UserInterface/Views
+ https://bugs.webkit.org/show_bug.cgi?id=161565
+
+ Reviewed by Darin Adler.
+
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGrid.prototype.columnWidthsMap):
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ (WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
+ * UserInterface/Views/TextContentView.js:
+ (WebInspector.TextContentView.prototype._togglePrettyPrint):
+
2016-09-02 Joseph Pecoraro <[email protected]>
Web Inspector: Provide a way to open an inspector frontend for a remote target
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (205400 => 205401)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-09-03 14:09:58 UTC (rev 205400)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-09-03 14:38:38 UTC (rev 205401)
@@ -872,7 +872,7 @@
var result = {};
for (var [identifier, column] of this.columns) {
var width = this._headerTableColumnGroupElement.children[column["ordinal"]].style.width;
- result[columnIdentifier] = parseFloat(width);
+ result[identifier] = parseFloat(width);
}
return result;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (205400 => 205401)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2016-09-03 14:09:58 UTC (rev 205400)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2016-09-03 14:38:38 UTC (rev 205401)
@@ -1015,7 +1015,7 @@
if (!WebInspector.isShowingDebuggerTab()) {
contextMenu.appendSeparator();
contextMenu.appendItem(WebInspector.UIString("Reveal in Debugger Tab"), () => {
- WebInspector.showDebuggerTab(breakpoint);
+ WebInspector.showDebuggerTab(breakpoints[0]);
});
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextContentView.js (205400 => 205401)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextContentView.js 2016-09-03 14:09:58 UTC (rev 205400)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextContentView.js 2016-09-03 14:38:38 UTC (rev 205401)
@@ -152,7 +152,7 @@
_togglePrettyPrint(event)
{
var activated = !this._prettyPrintButtonNavigationItem.activated;
- this._textEditor.updateFormattedState(formatted);
+ this._textEditor.updateFormattedState(activated);
}
_textEditorFormattingDidChange(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
