Title: [205430] trunk/Source/WebCore
- Revision
- 205430
- Author
- [email protected]
- Date
- 2016-09-05 00:15:50 -0700 (Mon, 05 Sep 2016)
Log Message
MediaPlayerPrivateGStreamerBase: improve build guards in nativeImageForCurrentTime()
https://bugs.webkit.org/show_bug.cgi?id=161594
Reviewed by Philippe Normand.
Guard the uses of cairo-gl API in nativeImageForCurrentTime() with the
USE(CAIRO) && ENABLE(ACCELERATED_2D_CANVAS) pair of build guards. This
API is only made available when the ACCELERATED_2D_CANVAS option is
enabled. Placing the guards this way thus avoids compilation errors
when compiling USE_GSTREAMER_GL code without the accelerated 2D canvas
support enabled.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (205429 => 205430)
--- trunk/Source/WebCore/ChangeLog 2016-09-05 07:14:41 UTC (rev 205429)
+++ trunk/Source/WebCore/ChangeLog 2016-09-05 07:15:50 UTC (rev 205430)
@@ -1,3 +1,20 @@
+2016-09-05 Zan Dobersek <[email protected]>
+
+ MediaPlayerPrivateGStreamerBase: improve build guards in nativeImageForCurrentTime()
+ https://bugs.webkit.org/show_bug.cgi?id=161594
+
+ Reviewed by Philippe Normand.
+
+ Guard the uses of cairo-gl API in nativeImageForCurrentTime() with the
+ USE(CAIRO) && ENABLE(ACCELERATED_2D_CANVAS) pair of build guards. This
+ API is only made available when the ACCELERATED_2D_CANVAS option is
+ enabled. Placing the guards this way thus avoids compilation errors
+ when compiling USE_GSTREAMER_GL code without the accelerated 2D canvas
+ support enabled.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+ (WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):
+
2016-09-04 Sam Weinig <[email protected]>
Remove the CREATE_DOM_WRAPPER macro
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (205429 => 205430)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2016-09-05 07:14:41 UTC (rev 205429)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2016-09-05 07:15:50 UTC (rev 205430)
@@ -682,10 +682,7 @@
#if USE(GSTREAMER_GL)
NativeImagePtr MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime()
{
-#if !USE(CAIRO) || !ENABLE(ACCELERATED_2D_CANVAS)
- return nullptr;
-#endif
-
+#if USE(CAIRO) && ENABLE(ACCELERATED_2D_CANVAS)
if (m_usingFallbackVideoSink)
return nullptr;
@@ -744,6 +741,9 @@
gst_video_frame_unmap(&videoFrame);
return rotatedSurface;
+#else
+ return nullptr;
+#endif
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
