Title: [205456] trunk/Source/WebCore
- Revision
- 205456
- Author
- [email protected]
- Date
- 2016-09-05 10:19:44 -0700 (Mon, 05 Sep 2016)
Log Message
[Mac] Static Analyzer warnings about unused values in CDMSessionAVStreamSession.mm
https://bugs.webkit.org/show_bug.cgi?id=161598
Patch by Joseph Pecoraro <[email protected]> on 2016-09-05
Reviewed by Darin Adler.
* platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
* platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):
Make this parameter a reference again, accidentally lost in r195410.
Now assignments to the parameter make sense.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (205455 => 205456)
--- trunk/Source/WebCore/ChangeLog 2016-09-05 16:58:48 UTC (rev 205455)
+++ trunk/Source/WebCore/ChangeLog 2016-09-05 17:19:44 UTC (rev 205456)
@@ -1,3 +1,16 @@
+2016-09-05 Joseph Pecoraro <[email protected]>
+
+ [Mac] Static Analyzer warnings about unused values in CDMSessionAVStreamSession.mm
+ https://bugs.webkit.org/show_bug.cgi?id=161598
+
+ Reviewed by Darin Adler.
+
+ * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
+ * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
+ (WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):
+ Make this parameter a reference again, accidentally lost in r195410.
+ Now assignments to the parameter make sense.
+
2016-09-05 Youenn Fablet <[email protected]>
Clean CSS stylesheets should be accessible from _javascript_
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h (205455 => 205456)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h 2016-09-05 16:58:48 UTC (rev 205455)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h 2016-09-05 17:19:44 UTC (rev 205456)
@@ -58,7 +58,7 @@
void setStreamSession(AVStreamSession*);
protected:
- PassRefPtr<Uint8Array> generateKeyReleaseMessage(unsigned short& errorCode, uint32_t systemCode);
+ PassRefPtr<Uint8Array> generateKeyReleaseMessage(unsigned short& errorCode, uint32_t& systemCode);
WeakPtrFactory<CDMSessionAVStreamSession> m_weakPtrFactory;
RetainPtr<AVStreamSession> m_streamSession;
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm (205455 => 205456)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm 2016-09-05 16:58:48 UTC (rev 205455)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm 2016-09-05 17:19:44 UTC (rev 205456)
@@ -303,7 +303,7 @@
[m_streamSession removeStreamDataParser:parser];
}
-PassRefPtr<Uint8Array> CDMSessionAVStreamSession::generateKeyReleaseMessage(unsigned short& errorCode, uint32_t systemCode)
+PassRefPtr<Uint8Array> CDMSessionAVStreamSession::generateKeyReleaseMessage(unsigned short& errorCode, uint32_t& systemCode)
{
ASSERT(m_mode == KeyRelease);
m_certificate = m_initData;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
