Title: [205472] trunk/Tools
- Revision
- 205472
- Author
- [email protected]
- Date
- 2016-09-06 02:48:18 -0700 (Tue, 06 Sep 2016)
Log Message
[Win] Crash logs have incorrect symbols.
https://bugs.webkit.org/show_bug.cgi?id=161603
Reviewed by Darin Adler.
Add build path to _NT_SYMBOL_PATH environment variable.
* Scripts/webkitpy/port/win.py:
(WinPort.setup_crash_log_saving):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (205471 => 205472)
--- trunk/Tools/ChangeLog 2016-09-06 07:09:01 UTC (rev 205471)
+++ trunk/Tools/ChangeLog 2016-09-06 09:48:18 UTC (rev 205472)
@@ -1,3 +1,15 @@
+2016-09-06 Per Arne Vollan <[email protected]>
+
+ [Win] Crash logs have incorrect symbols.
+ https://bugs.webkit.org/show_bug.cgi?id=161603
+
+ Reviewed by Darin Adler.
+
+ Add build path to _NT_SYMBOL_PATH environment variable.
+
+ * Scripts/webkitpy/port/win.py:
+ (WinPort.setup_crash_log_saving):
+
2016-08-31 Filip Pizlo <[email protected]>
Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
Modified: trunk/Tools/Scripts/webkitpy/port/win.py (205471 => 205472)
--- trunk/Tools/Scripts/webkitpy/port/win.py 2016-09-06 07:09:01 UTC (rev 205471)
+++ trunk/Tools/Scripts/webkitpy/port/win.py 2016-09-06 09:48:18 UTC (rev 205472)
@@ -299,6 +299,10 @@
if '_NT_SYMBOL_PATH' not in os.environ:
_log.warning("The _NT_SYMBOL_PATH environment variable is not set. Using Microsoft Symbol Server.")
os.environ['_NT_SYMBOL_PATH'] = 'SRV*http://msdl.microsoft.com/download/symbols'
+
+ # Add build path to symbol path
+ os.environ['_NT_SYMBOL_PATH'] += ";" + self._build_path()
+
ntsd_path = self._ntsd_location()
if not ntsd_path:
_log.warning("Can't find ntsd.exe. Crash logs will not be saved.")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
