Title: [205478] trunk/Tools
- Revision
- 205478
- Author
- [email protected]
- Date
- 2016-09-06 07:32:02 -0700 (Tue, 06 Sep 2016)
Log Message
Unreviewed, rolling out r205461.
https://bugs.webkit.org/show_bug.cgi?id=161628
Introduced "Use of uninitialized value $original in sprintf"
warning (Requested by mcatanzaro on #webkit).
Reverted changeset:
""Redundant argument in sprintf" warning spam from prepare-
ChangeLog"
https://bugs.webkit.org/show_bug.cgi?id=161606
http://trac.webkit.org/changeset/205461
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (205477 => 205478)
--- trunk/Tools/ChangeLog 2016-09-06 14:29:43 UTC (rev 205477)
+++ trunk/Tools/ChangeLog 2016-09-06 14:32:02 UTC (rev 205478)
@@ -1,3 +1,18 @@
+2016-09-06 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r205461.
+ https://bugs.webkit.org/show_bug.cgi?id=161628
+
+ Introduced "Use of uninitialized value $original in sprintf"
+ warning (Requested by mcatanzaro on #webkit).
+
+ Reverted changeset:
+
+ ""Redundant argument in sprintf" warning spam from prepare-
+ ChangeLog"
+ https://bugs.webkit.org/show_bug.cgi?id=161606
+ http://trac.webkit.org/changeset/205461
+
2016-09-06 Youenn Fablet <[email protected]>
W3C test importer should be able to identify slow test
Modified: trunk/Tools/Scripts/prepare-ChangeLog (205477 => 205478)
--- trunk/Tools/Scripts/prepare-ChangeLog 2016-09-06 14:29:43 UTC (rev 205477)
+++ trunk/Tools/Scripts/prepare-ChangeLog 2016-09-06 14:32:02 UTC (rev 205478)
@@ -2325,21 +2325,21 @@
my $propertyDescription = defined $propertyChanges ? propertyChangeDescription($propertyChanges) : "";
my %svn = (
- "A" => defined $original ? sprintf(" Copied from \%s.", $original) : " Added.",
+ "A" => defined $original ? " Copied from \%s." : " Added.",
"D" => " Removed.",
"M" => "",
- "R" => defined $original ? sprintf(" Replaced with \%s.", $original) : " Replaced.",
+ "R" => defined $original ? " Replaced with \%s." : " Replaced.",
" " => "",
);
my %git = %svn;
$git{"A"} = " Added.";
- $git{"C"} = sprintf(" Copied from \%s.", $original);
- $git{"R"} = sprintf(" Renamed from \%s.", $original);
+ $git{"C"} = " Copied from \%s.";
+ $git{"R"} = " Renamed from \%s.";
my $description;
- $description = $svn{$status} if isSVN() && exists $svn{$status};
- $description = $git{$status} if isGit() && exists $git{$status};
+ $description = sprintf($svn{$status}, $original) if isSVN() && exists $svn{$status};
+ $description = sprintf($git{$status}, $original) if isGit() && exists $git{$status};
return unless defined $description;
$description .= $propertyDescription unless isAddedStatus($status);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
