Title: [205598] trunk
Revision
205598
Author
[email protected]
Date
2016-09-08 00:45:27 -0700 (Thu, 08 Sep 2016)

Log Message

[Win] Exception fuzz tests fail
https://bugs.webkit.org/show_bug.cgi?id=140928

Reviewed by Mark Lam.

JSTests:

Unskip tests.

* exceptionFuzz.yaml:

Source/_javascript_Core:

Flush stdout when throwing the exception to make sure the output comes before output in the exception handler.
The tests depend on the output to stdout being written in the correct order.

* runtime/ExceptionFuzz.cpp:
(JSC::doExceptionFuzzing):

Modified Paths

Diff

Modified: trunk/JSTests/ChangeLog (205597 => 205598)


--- trunk/JSTests/ChangeLog	2016-09-08 07:44:57 UTC (rev 205597)
+++ trunk/JSTests/ChangeLog	2016-09-08 07:45:27 UTC (rev 205598)
@@ -1,3 +1,14 @@
+2016-09-08  Per Arne Vollan  <[email protected]>
+
+        [Win] Exception fuzz tests fail
+        https://bugs.webkit.org/show_bug.cgi?id=140928
+
+        Reviewed by Mark Lam.
+
+        Unskip tests.
+
+        * exceptionFuzz.yaml:
+
 2016-09-06  Saam Barati  <[email protected]>
 
         ProxyObject's structure should not have ObjectPrototype as its prototype and it should not have special behavior for intercepting "__proto__"

Modified: trunk/JSTests/exceptionFuzz.yaml (205597 => 205598)


--- trunk/JSTests/exceptionFuzz.yaml	2016-09-08 07:44:57 UTC (rev 205597)
+++ trunk/JSTests/exceptionFuzz.yaml	2016-09-08 07:45:27 UTC (rev 205598)
@@ -22,9 +22,4 @@
 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 - path: exceptionFuzz
-  cmd: |
-      if ($hostOS == "windows")
-          skip
-      else
-          runExceptionFuzz
-      end
+  cmd: runExceptionFuzz

Modified: trunk/Source/_javascript_Core/ChangeLog (205597 => 205598)


--- trunk/Source/_javascript_Core/ChangeLog	2016-09-08 07:44:57 UTC (rev 205597)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-09-08 07:45:27 UTC (rev 205598)
@@ -1,3 +1,16 @@
+2016-09-08  Per Arne Vollan  <[email protected]>
+
+        [Win] Exception fuzz tests fail
+        https://bugs.webkit.org/show_bug.cgi?id=140928
+
+        Reviewed by Mark Lam.
+
+        Flush stdout when throwing the exception to make sure the output comes before output in the exception handler.
+        The tests depend on the output to stdout being written in the correct order.
+
+        * runtime/ExceptionFuzz.cpp:
+        (JSC::doExceptionFuzzing):
+
 2016-09-07  Simon Fraser  <[email protected]>
 
         Enable the <meter> element on iOS

Modified: trunk/Source/_javascript_Core/runtime/ExceptionFuzz.cpp (205597 => 205598)


--- trunk/Source/_javascript_Core/runtime/ExceptionFuzz.cpp	2016-09-08 07:44:57 UTC (rev 205597)
+++ trunk/Source/_javascript_Core/runtime/ExceptionFuzz.cpp	2016-09-08 07:45:27 UTC (rev 205598)
@@ -49,6 +49,7 @@
     unsigned fireTarget = Options::fireExceptionFuzzAt();
     if (fireTarget == s_numberOfExceptionFuzzChecks) {
         printf("JSC EXCEPTION FUZZ: Throwing fuzz exception with call frame %p, seen in %s and return address %p.\n", exec, where, returnPC);
+        fflush(stdout);
         throwException(exec, scope, createError(exec, ASCIILiteral("Exception Fuzz")));
     }
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to